From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07B8E3F39C6 for ; Tue, 9 Jun 2026 10:34:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781001301; cv=none; b=tKYx1PM950mfEyG7eMk5jnSEiNIA6O8CAWnk+bToSyIVIhE4zJt/DQGtEHUYFHdoxdUV++UchydsvFdFfrqU3fB260m+YSKEN61FzdByJIHV4F+Q28fugpGZ3q6Qy9qFz3jzkC2KUuYIJNP9BVsYj+dzuwNKzaE8U49azS1ye5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781001301; c=relaxed/simple; bh=JtA0re8kidO3gfQkDn8ChGhRgxdcG02cRmDUFQXfcrI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t8ufAZNOd/FHxAgKFmWu51iKUbpfPvJr7a1W5Fi63QtxGsOz76ibZ2Zp8TEXpGXJJZeGf9R5HynjZvfug/Ys9gTuF8s198ejoWUWDxyQS/k1VDkDa/df6wcn59h0I2uwnyHHqEV3bGalijdfCOOPIIDqkIxqjEZH2bsXYqaL5+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gJvZHNzS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OlozP4Y/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gJvZHNzS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OlozP4Y/" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6599wnrQ2311314 for ; Tue, 9 Jun 2026 10:34:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mPr84Bdv3vOiH6osuLFjd2Cuwh2MgJdCXKl5w0JclkE=; b=gJvZHNzSRI49RMSG 7NfTKi7GFGAwCQ6LJNWNjXqHMvLvdSyRQCgqkxgjidq+JZBsGFI5805Z4wRaKvP1 nIhPhzAmQPvyomeyJI0tDyNt/i87Q9hRA+wT+p2NE5GgBTlWvIMWB3STQBO0jkfd QA1gCjO1DxKoNk+UN4Me71NLjIgwh+D7X+q/PFW0BqwLbPXRGgjJoESKcAXgRVnS BxX590lG9/lfzviTH4JA0qJurpB7CN/rHBX4p+YXHYfPx0pzqDVOIddVC59xSXSM 3B8oD7C5M04OgTvIosZfNeNEBq/k91iXUCul0FmaEIKLVw0jY/+Q+nu2NFGX6wzt cILigA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epg3v091a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 10:34:58 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-36bcfce8a33so4930388a91.1 for ; Tue, 09 Jun 2026 03:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781001298; x=1781606098; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mPr84Bdv3vOiH6osuLFjd2Cuwh2MgJdCXKl5w0JclkE=; b=OlozP4Y/ah00jnADkGG1tUEHnHuvL+nQBeYidQRl1E6GYKQ2bnUTc6KrAVw6srjceE VzvDBJrtI8TCKemA2xpmEqxs7uI6hGBRpTrVbFNkLUpNpK8SFxSyX/fRwmij0Dur7kQ1 DvBBZSrEgj3pMyVmd+VLH9BBALPxItuFDyKQmIetvimQaBwqUnkFWgjgEhjV6pX//HxA hEkJXH3xBqsQMdvjW2yTmQf51XqBSjUP9mxCyu22rgkLNK3GHgFfdYjo1QzcJDbBRSX9 1/HKNGCrL2ToEs41cGGJdaABTWzU6PmoKGmYqG2xk+APJsMezm+XhUnaPpdKq8DG06QY nlIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781001298; x=1781606098; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mPr84Bdv3vOiH6osuLFjd2Cuwh2MgJdCXKl5w0JclkE=; b=g9ypkaf6fnLH+UcQY+BEOD+aeFxZCIMkBxWy4kseZq1Mo0wKB2TqYyhXGshQDFh68n nRru7mnaLiWNEbya0AfzIXG0W92SwURs5RQSx7+MfoAB7m13S1fj9Ja8NHK61rVDONaX 0IHNm7hT3ifMehVqsH9anMrJsHcsgj1Kmm3LacaOiT68wIADUtXB+sHhon0zAA6z63+y r8Mjf7WYFNdEaBOtahQJQLj6uoYYeiOaSgKFmhZz48qzaOwn6kBaDfOC9mf7dDePhyBn r5YR7A7ukINgcRdazq94OHz2GisUm5VRgZZmJ5NfH4ozH7zHtpYsNCd1wj6fbex+Y3Is oIgA== X-Forwarded-Encrypted: i=1; AFNElJ/nI8PseCQr6u7hAPxBRzEHJ+aBXQ7zta6wV7eRqed/WoBU4GbO5T9qU8xAhwLzdkyovkwBcq0j4ZYxNPk=@vger.kernel.org X-Gm-Message-State: AOJu0YyvXHfK/5iEJkxMtYfnCNPDAe7y3/ofe3uZYfNmB4eocnDRp4Dt yOUeV0/zQYmtEs6kbb2xT4vuu6AtG1k4Z3rxkMj9qjcbgP9zEka+Yuzu2XMYIaAx90eARMEBL6k /K+Yo3+/o6OqgWidCLUIJm5rO/Q8itMVABQ+iHKba3cyyv5nAwarPzpoOskEEqMKYxbw= X-Gm-Gg: Acq92OE58qW5WQFZgnahXqA6syVcCnVOyxRplGHSVSAJ53eu2Bddz8KjUdmXwIfRRR/ 58XjL0DZlUQFP2DZiSlgNDWiTTkyDG9cpTcB45igC5BVyMvc5pVEwDb535unjoFEhkIFcz7Xeoh 5sdZ/3MhJZaVIw+KNr5qnXhH7rGi63gzid/j+6LuKeUSkB4Y864A1IkbEbCB7aTbKhSnN9BZkbT Dt/sGU5lotnzhuceuyyhYssenpJU6R3zTp7BB2F2dt/Y5eBNtUBjXWzkFSWKkhIK1PEf/j9RUQm tcRxQzl4iinsD88jjjtYdzS/VNCO9gM4n5KXJoZIJGcPc2eJIXyaFxC+RKlh8HmZ0+F3x31ijac mcrSJWnYI3KfkEMM6HtZBOn5qZZoySuMSBukZiSX0+aovJFgQxngiKaI= X-Received: by 2002:a17:903:94d:b0:2c0:d94f:50c7 with SMTP id d9443c01a7336-2c1ec508177mr177538865ad.7.1781001297851; Tue, 09 Jun 2026 03:34:57 -0700 (PDT) X-Received: by 2002:a17:903:94d:b0:2c0:d94f:50c7 with SMTP id d9443c01a7336-2c1ec508177mr177538505ad.7.1781001297298; Tue, 09 Jun 2026 03:34:57 -0700 (PDT) Received: from [10.152.201.53] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16629d042sm217458055ad.60.2026.06.09.03.34.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 03:34:56 -0700 (PDT) Message-ID: <89a95a6f-1dce-4141-9b7c-12d7ab6bc0af@oss.qualcomm.com> Date: Tue, 9 Jun 2026 16:04:52 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] dma: qcom: bam_dma: Fix command element mask field for BAM v1.6.0+ To: Dmitry Baryshkov Cc: Varadarajan Narayanan , Vinod Koul , Frank Li , Abhishek Sahu , mani@kernel.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, lakshmi.d@oss.qualcomm.com References: <20260514-bam-fix-v5-1-58f6edb34969@oss.qualcomm.com> <5c24a3f3-a4c0-43ec-9653-bc374a9c5e22@oss.qualcomm.com> <6qkgzmrr3oxzj47so4jqw6gk6stzjkxbnaflajk5zw5fgf65cn@yj3d55p5b7do> Content-Language: en-US From: Md Sadre Alam In-Reply-To: <6qkgzmrr3oxzj47so4jqw6gk6stzjkxbnaflajk5zw5fgf65cn@yj3d55p5b7do> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=St6gLvO0 c=1 sm=1 tr=0 ts=6a27ec52 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=I2Tm49LE0oniHcX1gG8A:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: nu9vLQ_k_LniKpjDAnjJTYY39Cu_umIx X-Proofpoint-GUID: nu9vLQ_k_LniKpjDAnjJTYY39Cu_umIx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDA5OSBTYWx0ZWRfX3H1o6S+BkfAP x5J0Se5ujJcpEAeCPxo1ww6BSOuMXoUr0qaodQNsQujggw/g+AQKbBUA3KTKY3Ow+u66Yp8BP08 nQLIRZusdJyFTerN0xqv+MXxNVPYhrY1LyNCYR/qtiEmf7BMNOSVQ5Ri2tAgfUzB4Is8Tj8MT3O lCNV45L7FVHzh9rk8NnUI4AkQeP9dHbrPtzrg6XH2WxVrI+CnXKnlkxRZMFSnP23/fh5XSNYjAB Vm5bznJtH5SuZf9g0eQRvrM7sHnmPMA1d7fo2Is5M/AZDVfslpVSMYMtBqNGRyoK0OKIzJfSqTS wF1yvbChOIgXXlXqIypTL767rRcEB479eRwiY2/o9jKu7KNNOE5Za3Je3udAvphginlXVT9Bidq H6i4rZs5QTW0U24bGpTS1aRCeZdyBcq4cljPRmmmCGSYhZyWXFtmb+0upd/eX4Nio1iwdvv/GF+ bsM5QtcN5Ekxnb38yAA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 bulkscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090099 Hi, On 6/8/2026 11:33 AM, Dmitry Baryshkov wrote: > On Mon, Jun 08, 2026 at 11:20:01AM +0530, Md Sadre Alam wrote: >> Hi, >> >> On 6/4/2026 4:15 PM, Varadarajan Narayanan wrote: >>> On Tue, May 19, 2026 at 11:01:51PM +0530, Vinod Koul wrote: >>>> On 14-05-26, 12:09, Varadarajan Narayanan wrote: >>>>> From: Md Sadre Alam >>>>> >>>>> BAM version 1.6.0 and later changed the behavior of the mask field in >>>>> command elements for read operations. In newer BAM versions, the mask >>>>> field for read commands contains the upper 4 bits of the destination >>>>> address to support 36-bit addressing, while for write commands it >>>>> continues to function as a traditional write mask. >>>> >>>> But this changes behaviour for all versions. What happens to folks on older >>>> versions, wont this break for them, if not what am I missing >> >> It will not have any impact on older version of BAM controller. Konrad also >> had a similar concern. Please refer to [1] >> >> [1] https://lore.kernel.org/linux-arm-msm/2394e63f-1df7-764e-5489-3567065707a1@quicinc.com/ > > So, you got this question once, have resent the patches, but didn't > guess that there will be the similar question from other reviewers? > > Usually a question means that the commit needs to be improved. Adding a > simple "Previously this field was ignored for read commands" would have > saved you from futher questions. Will update the commit message and post the new version. Thanks, Alam.