mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tuo Li <islituo@gmail.com>
To: martin.petersen@oracle.com
Cc: baijiaju1990@gmail.com, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [BUG] scsi: iscsi: possible null-pointer dereference in iscsit_tpg_add_network_portal()
Date: Tue, 10 Aug 2021 21:48:03 +0800	[thread overview]
Message-ID: <89aaa039-2f03-f657-a555-a6a99f38db6d@gmail.com> (raw)

Hello,

Our static analysis tool finds a possible null-pointer dereference in 
the iscsi driver in Linux 5.14.0-rc3:

The variable tpg->tpg_tiqn is checked in:
496:    if (tpg->tpg_tiqn)

This indicates that it can be NULL. If so, a null-pointer dereference 
will occur:
508:    pr_debug("CORE[%s] - Added Network Portal: %pISpc,%hu on %s\n", 
tpg->tpg_tiqn->tiqn, ...)

I am not quite sure whether this possible null-pointer dereference is 
real and how to fix it if it is real.
Any feedback would be appreciated, thanks!

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>

Best wishes,
Tuo Li

                 reply	other threads:[~2021-08-10 13:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89aaa039-2f03-f657-a555-a6a99f38db6d@gmail.com \
    --to=islituo@gmail.com \
    --cc=baijiaju1990@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®