From: Hans de Goede <hdegoede@redhat.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Jingjing Xiong <jingjing.xiong@intel.com>,
Hao Yao <hao.yao@intel.com>, Jim Lai <jim.lai@intel.com>,
You-Sheng Yang <vicamo.yang@canonical.com>,
Alan Stern <stern@rowland.harvard.edu>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 0/8] RFT/RFC: Import IPU6 ov02e10 sensor driver and enable OF usage of it
Date: Mon, 17 Mar 2025 10:02:41 +0100 [thread overview]
Message-ID: <89af0891-3bbe-4964-8d19-205cdab79497@redhat.com> (raw)
In-Reply-To: <20250317-b4-media-comitters-next-25-03-13-ov02e10-v1-0-bd924634b889@linaro.org>
Hi Bryan, Alan,
On 17-Mar-25 01:39, Bryan O'Donoghue wrote:
> Similar to Hans' progressive series on ov02c10 I've picked up via Hans the
> IPU6 driver with some additional fixes from Alan Stern.
>
> https://lore.kernel.org/linux-media/20250313184314.91410-1-hdegoede@redhat.com
>
> I've made a number of initial changes to this driver sufficient to get it
> working on the Dell Inspiron 14 Plus 7441 with the Qualcomm X Elite
> x1e80100 SoC and its CAMSS stack.
>
> link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/x1e80100-6.14-rc6-inspirion14-slim7x-camss?ref_type=heads
>
> This is a first pass which adds in the minimum to get the sensor going on
> the Qualcomm platform. What would be nice would be someone on the IPU6 side
> giving it a test.
>
> A big TBD here is the YAML for this file but, I'd like to make sure nothing
> has broken for IPU6/IPU7 with the modifications before diving into
> Documentation.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Bryan, thank you for your work on this.
Alan, can you give this version of the driver a test run on your laptop?
Note you need to skip patch 3/8 for now until I've implemented the
solution for handshake handling in the INT3472 driver. Also you need
keep the sleep of at least 25 ms after setting the handshake GPIO.
Regards,
Hans
> ---
> Bryan O'Donoghue (7):
> media: i2c: ov02e10: Fix initial indentation and spacing
> media: i2c: ov02e10: Drop IPU6 FPGA specific handshake GPIO
> media: i2c: ov02e10: Convert to regulator_bulk API
> media: i2c: ov02e10: Rework MCLK clock get logic to facilitate OF
> media: i2c: ov02e10: Implement specification t3 and t5 delays on power-up
> media: i2c: ov02e10: Remove redundant dev_dbg() and some extra dev_err()
> media: i2c: ov02e10: Add OF probe support
>
> Jingjing Xiong (1):
> media: i2c: add OV02E10 image sensor driver
>
> drivers/media/i2c/Kconfig | 10 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/ov02e10.c | 978 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 989 insertions(+)
> ---
> base-commit: f2151613e040973c868d28c8b00885dfab69eb75
> change-id: 20250317-b4-media-comitters-next-25-03-13-ov02e10-23e68307d589
>
> Best regards,
next prev parent reply other threads:[~2025-03-17 9:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 0:39 Bryan O'Donoghue
2025-03-17 0:39 ` [PATCH 1/8] media: i2c: add OV02E10 image sensor driver Bryan O'Donoghue
2025-03-21 16:38 ` Dan Carpenter
2025-03-17 0:39 ` [PATCH 2/8] media: i2c: ov02e10: Fix initial indentation and spacing Bryan O'Donoghue
2025-03-17 0:39 ` [PATCH 3/8] media: i2c: ov02e10: Drop IPU6 FPGA specific handshake GPIO Bryan O'Donoghue
2025-03-17 0:39 ` [PATCH 4/8] media: i2c: ov02e10: Convert to regulator_bulk API Bryan O'Donoghue
2025-03-17 0:39 ` [PATCH 5/8] media: i2c: ov02e10: Rework MCLK clock get logic to facilitate OF Bryan O'Donoghue
2025-03-17 0:39 ` [PATCH 6/8] media: i2c: ov02e10: Implement specification t3 and t5 delays on power-up Bryan O'Donoghue
2025-03-17 9:04 ` Hans de Goede
2025-03-17 0:39 ` [PATCH 7/8] media: i2c: ov02e10: Remove redundant dev_dbg() and some extra dev_err() Bryan O'Donoghue
2025-03-17 0:39 ` [PATCH 8/8] media: i2c: ov02e10: Add OF probe support Bryan O'Donoghue
2025-03-17 9:02 ` Hans de Goede [this message]
2025-03-17 17:33 ` [PATCH 0/8] RFT/RFC: Import IPU6 ov02e10 sensor driver and enable OF usage of it Alan Stern
2025-03-17 20:56 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89af0891-3bbe-4964-8d19-205cdab79497@redhat.com \
--to=hdegoede@redhat.com \
--cc=broonie@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hao.yao@intel.com \
--cc=jim.lai@intel.com \
--cc=jingjing.xiong@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=vicamo.yang@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®