From: Markus Elfring <Markus.Elfring@web.de>
To: vulab@iscas.ac.cn, linux-gpio@vger.kernel.org,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
Charles Keepax <ckeepax@opensource.cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
Linus Walleij <linus.walleij@linaro.org>,
Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] pinctrl: cirrus: Fix fwnode leak in cs42l43_pin_probe()
Date: Wed, 29 Oct 2025 14:34:15 +0100 [thread overview]
Message-ID: <89af2621-7688-49ba-8246-22d79a2b8b20@web.de> (raw)
In-Reply-To: <20251028030509.835-1-vulab@iscas.ac.cn>
…
> +++ b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c
…
> @@ -563,10 +568,20 @@ static int cs42l43_pin_probe(struct platform_device *pdev)
> priv->gpio_chip.ngpio = CS42L43_NUM_GPIOS;
>
> if (is_of_node(fwnode)) {
…
> + child = fwnode_get_named_child_node(fwnode, "pinctrl");
> + if (child) {
> + ret = devm_add_action_or_reset(&pdev->dev,
> + cs42l43_fwnode_put, child);
> + if (ret) {
> + fwnode_handle_put(child);
> + return ret;
> + }
…
I doubt that such a function call is needed in this if branch.
https://elixir.bootlin.com/linux/v6.18-rc3/source/include/linux/device/devres.h#L152-L168
Regards,
Markus
next prev parent reply other threads:[~2025-10-29 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250929031031.2230-1-vulab@iscas.ac.cn>
2025-10-28 3:05 ` Haotian Zhang
2025-10-29 13:34 ` Markus Elfring [this message]
2025-11-09 23:01 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89af2621-7688-49ba-8246-22d79a2b8b20@web.de \
--to=markus.elfring@web.de \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®