From: Danilo Krummrich <dakr@kernel.org>
To: Philipp Stanner <phasta@kernel.org>
Cc: "Lyude Paul" <lyude@redhat.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Matthew Brost" <matthew.brost@intel.com>,
"Christian König" <ckoenig.leichtzumerken@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Tvrtko Ursulin" <tvrtko.ursulin@igalia.com>,
"Pierre-Eric Pelloux-Prayer" <pierre-eric.pelloux-prayer@amd.com>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v2 7/7] drm/nouveau: Remove waitque for sched teardown
Date: Mon, 7 Jul 2025 15:47:27 +0200 [thread overview]
Message-ID: <89b0a4bf-2a66-4610-93d2-8f2f096592a3@kernel.org> (raw)
In-Reply-To: <20250707134221.34291-9-phasta@kernel.org>
On 7/7/25 3:42 PM, Philipp Stanner wrote:
> struct nouveau_sched contains a waitque needed to prevent
> drm_sched_fini() from being called while there are still jobs pending.
> Doing so so far would have caused memory leaks.
>
> With the new memleak-free mode of operation switched on in
> drm_sched_fini() by providing the callback
> nouveau_sched_fence_context_kill() the waitque is not necessary anymore.
>
> Remove the waitque.
>
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
Doesn't this break the driver until fixed up by the subsequent patch?
next prev parent reply other threads:[~2025-07-07 13:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 13:42 [PATCH v2 0/7] drm/sched: Fix memory leaks with cancel_job() callback Philipp Stanner
2025-07-07 13:42 ` [PATCH v2 1/7] drm/sched: Avoid " Philipp Stanner
2025-07-07 13:42 ` [PATCH v2 2/7] drm/sched/tests: Implement " Philipp Stanner
2025-07-07 15:25 ` Tvrtko Ursulin
2025-07-07 13:42 ` [PATCH v2 3/7] drm/sched/tests: Add unit test for cancel_job() Philipp Stanner
2025-07-07 15:20 ` Tvrtko Ursulin
2025-07-07 13:42 ` [PATCH v2 4/7] drm/sched: Warn if pending list is not empty Philipp Stanner
2025-07-07 13:42 ` [PATCH v2 5/7] drm/nouveau: Make fence container helper usable driver-wide Philipp Stanner
2025-07-07 13:45 ` Danilo Krummrich
2025-07-07 13:42 ` [PATCH v2 6/7] drm/nouveau: Add new callback for scheduler teardown Philipp Stanner
2025-07-07 14:26 ` Danilo Krummrich
2025-07-07 13:42 ` [PATCH v2 7/7] drm/nouveau: Remove waitque for sched teardown Philipp Stanner
2025-07-07 13:47 ` Danilo Krummrich [this message]
2025-07-07 13:54 ` Philipp Stanner
2025-07-07 14:26 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89b0a4bf-2a66-4610-93d2-8f2f096592a3@kernel.org \
--to=dakr@kernel.org \
--cc=airlied@gmail.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=phasta@kernel.org \
--cc=pierre-eric.pelloux-prayer@amd.com \
--cc=simona@ffwll.ch \
--cc=sumit.semwal@linaro.org \
--cc=tvrtko.ursulin@igalia.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®