From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF26AC433EF for ; Wed, 20 Oct 2021 09:29:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5EBF61359 for ; Wed, 20 Oct 2021 09:29:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229972AbhJTJbr (ORCPT ); Wed, 20 Oct 2021 05:31:47 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:58044 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229764AbhJTJbp (ORCPT ); Wed, 20 Oct 2021 05:31:45 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 08B1E1F43FDB Subject: Re: [PATCH v2 3/9] media: platform: mtk-mdp3: add chip independence architecture To: "roy-cw.yeh" , Rob Herring , Matthias Brugger , Chun-Kuang Hu Cc: Mauro Carvalho Chehab , Fabien Parent , "jason-jh . lin" , daoyuan huang , Ping-Hsun Wu , Moudy Ho , "river . cheng" , Yongqiang Niu , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20211020071448.14187-1-roy-cw.yeh@mediatek.com> <20211020071448.14187-4-roy-cw.yeh@mediatek.com> From: AngeloGioacchino Del Regno Message-ID: <89b3f65d-3ad1-5f81-7e16-0c00db74678b@collabora.com> Date: Wed, 20 Oct 2021 11:29:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211020071448.14187-4-roy-cw.yeh@mediatek.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 20/10/21 09:14, roy-cw.yeh ha scritto: > From: "Roy-CW.Yeh" > > Add chip independence architecture > - Add hal architecture for mt8183 > - Add driver data to adapt other soc > > Signed-off-by: Roy-CW.Yeh > --- > .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.c | 154 ++++--- > .../media/platform/mtk-mdp3/mtk-mdp3-comp.c | 181 ++++----- > .../media/platform/mtk-mdp3/mtk-mdp3-comp.h | 193 ++++++++- > .../media/platform/mtk-mdp3/mtk-mdp3-core.c | 383 +++++++++++++++++- > .../media/platform/mtk-mdp3/mtk-mdp3-core.h | 19 + > .../media/platform/mtk-mdp3/mtk-mdp3-m2m.c | 10 +- > .../media/platform/mtk-mdp3/mtk-mdp3-regs.c | 259 +----------- > .../media/platform/mtk-mdp3/mtk-mdp3-regs.h | 268 ++++++------ > 8 files changed, 925 insertions(+), 542 deletions(-) > snip... > diff --git a/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c b/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c > index a6caefb097be..50fd5430a565 100644 > --- a/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c > +++ b/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c snip.. > @@ -732,7 +514,7 @@ int mdp_frameparam_init(struct mdp_frameparam *param) > param->num_captures = 1; > frame = ¶m->captures[0]; > frame->format.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE; > - frame->mdp_fmt = mdp_try_fmt_mplane(&frame->format, param, 0); > + frame->mdp_fmt = mdp_try_fmt_mplane(mdp, &frame->format, param, 0); > frame->ycbcr_prof = > mdp_map_ycbcr_prof_mplane(&frame->format, > frame->mdp_fmt->mdp_color); > @@ -744,3 +526,4 @@ int mdp_frameparam_init(struct mdp_frameparam *param) > > return 0; > } > + Please remove this empty new line. Apart from that, Acked-by: AngeloGioacchino Del Regno