From: David Woodhouse <dwmw2@infradead.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: wireguard@lists.zx2c4.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S.Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Antonio Quartulli <antonio@openvpn.net>,
Ralf Lici <ralf@mandelbit.com>,
Sabrina Dubroca <sd@queasysnail.net>,
openvpn-devel@lists.sourceforge.net
Subject: Re: [PATCH] wireguard: socket: fix sticky source address on p2p
Date: Tue, 10 Nov 2026 08:46:53 -0800 [thread overview]
Message-ID: <89b5e08e2a48c33be4cf2d495266d04a2dcf406e.camel@infradead.org> (raw)
In-Reply-To: <avNCdbpjxM752XSw@zx2c4.com>
[-- Attachment #1: Type: text/plain, Size: 421 bytes --]
On Tue, 2026-11-10 at 17:12 +0100, Jason A. Donenfeld wrote:
>
> Hmm... How did you choose __ip_dev_find() over, say,
> inet_lookup_ifaddr_rcu(), which is structurally more similar to
> ipv6_chk_addr()?
__ip_dev_find() is what's exported to modules. It internally takes the
RCU lock and calls inet_lookup_ifaddr_rcu(). It also falls back to a
RT_TABLE_LOCAL lookup, which I think is the right thing here too.
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 6179 bytes --]
prev parent reply other threads:[~2026-11-10 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 16:38 David Woodhouse
2026-11-08 21:47 ` David Woodhouse
2026-11-10 16:12 ` Jason A. Donenfeld
2026-11-10 16:46 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89b5e08e2a48c33be4cf2d495266d04a2dcf406e.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=Jason@zx2c4.com \
--cc=andrew+netdev@lunn.ch \
--cc=antonio@openvpn.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openvpn-devel@lists.sourceforge.net \
--cc=pabeni@redhat.com \
--cc=ralf@mandelbit.com \
--cc=sd@queasysnail.net \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®