From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E7C2218EB7 for ; Tue, 15 Apr 2025 08:53:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744707211; cv=none; b=AT2BRpQxrnUZk3G/jl24KX9drkJErCC1q80GJ/kN+qlSftqhEAm5A6sPBpUYIp+FXOGPf6Momy1uiACOmQrxNlFpEPMhAf+JjCZWly5/sqAyCrVDPNg66B3uxoppykeqkNO+4gvrkBNCue7rkfqaUe/STurwh+5yVexvuPL06pk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744707211; c=relaxed/simple; bh=1JQts2RTv7RmyS6fNpRWxHBgq3NtsoZVF2mSxQgpZB0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=sow+Pp9b1NzAT/D0h/m02ZxC/7VLXukinHm1zMImtCCt3i5XoJuxcNfSbvGYbTFdEbVcjQf1hP+fyA+OSXoAA6QVF/HmhaHr4uZE421zvbln6VQ2D0YpteXe0rUBFgVWxMNlUAPBFZVCbsQs73vCTw2lzxojhwpR12WY6ZNYuU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u4c2O-00072J-DA; Tue, 15 Apr 2025 10:53:00 +0200 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u4c2L-000OEt-1G; Tue, 15 Apr 2025 10:52:57 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1u4c2L-0004e1-0w; Tue, 15 Apr 2025 10:52:57 +0200 Message-ID: <89b6142bacecd4a7742341b88dc1e28c4454527a.camel@pengutronix.de> Subject: Re: [PATCH 1/9] dt-bindings: pwm: marvell,pxa: add optional property resets From: Philipp Zabel To: Conor Dooley , Guodong Xu Cc: ukleinek@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, dlan@gentoo.org, drew@pdp7.com, inochiama@gmail.com, geert+renesas@glider.be, heylenay@4d2.org, tglx@linutronix.de, hal.feng@starfivetech.com, unicorn_wang@outlook.com, duje.mihanovic@skole.hr, elder@riscstar.com, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev Date: Tue, 15 Apr 2025 10:52:57 +0200 In-Reply-To: <20250411-confider-spinster-35f23040d188@spud> References: <20250411131423.3802611-1-guodong@riscstar.com> <20250411131423.3802611-2-guodong@riscstar.com> <20250411-confider-spinster-35f23040d188@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Fr, 2025-04-11 at 17:44 +0100, Conor Dooley wrote: > On Fri, Apr 11, 2025 at 09:14:15PM +0800, Guodong Xu wrote: > > Add an optional resets property for the Marvell PWM PXA binding. > >=20 > > Signed-off-by: Guodong Xu > > --- > > Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml= b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > > index 9ee1946dc2e1..9640d4b627c2 100644 > > --- a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > > +++ b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > > @@ -31,6 +31,9 @@ properties: > > clocks: > > maxItems: 1 > > =20 > > + resets: > > + maxItems: 1 >=20 > Do any of the currently supported devices use a reset? If not, then add > this in tandem with the new compatible and only allow it there please. Also, if spacemit,k1-pwm can not work without the reset being deasserted, mark it as required. The driver can still use reset_control_get_optional. regards Philipp