From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marc Olberding <molberding@nvidia.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: dts: aspeed: Add device tree includes for the cx8 switchboard
Date: Tue, 19 Aug 2025 21:19:26 +0200 [thread overview]
Message-ID: <89b7bbe5-604f-4990-8055-9ea8ba4cb934@kernel.org> (raw)
In-Reply-To: <aKTMA/006Nl/tOPT@molberding.nvidia.com>
On 19/08/2025 21:09, Marc Olberding wrote:
> On Sat, Aug 16, 2025 at 10:16:06AM +0200, Krzysztof Kozlowski wrote:
>>
>>
>>> +// SPDX-License-Identifier: GPL-2.0-or-later
>>
>> Odd license. Since when GPL-3.0 is okay?
>>
> Ack, missed this. Will fix.
>>> +
>>> +eeprom@56 {
>>> + compatible = "atmel,24c128";
>>> + reg = <0x56>;
>>> +};
>>> +
>>
>> This is some completely misplaced DTSI style. Don't do this...
>
> Thanks for the feedback. I'm not sure which piece of this is wrong.
> Is the issue with having the contents of an i2c bus in a dtsi file?
> If so, would you prefer that we abandon the dtsi all together and
I think this should be just included in each bus needing it. It's really
odd to see a DTSI with top-level I2C devices.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-19 19:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 19:45 [PATCH 0/3] Adding device tree and binding for Nvidia mgx " Marc Olberding
2025-08-15 19:45 ` [PATCH 1/3] dt-bindings: arm: aspeed: Add Nvidia's mgx4u BMC Marc Olberding
2025-08-16 8:15 ` Krzysztof Kozlowski
2025-08-15 19:45 ` [PATCH 2/3] ARM: dts: aspeed: Add device tree includes for the cx8 switchboard Marc Olberding
2025-08-16 8:16 ` Krzysztof Kozlowski
2025-08-19 19:09 ` Marc Olberding
2025-08-19 19:19 ` Krzysztof Kozlowski [this message]
2025-08-15 19:45 ` [PATCH 3/3] ARM: dts: aspeed: Add device tree for mgx4u BMC Marc Olberding
2025-08-16 1:02 ` Andrew Lunn
2025-08-16 8:17 ` Krzysztof Kozlowski
2025-08-15 23:38 ` [PATCH 0/3] Adding device tree and binding for Nvidia mgx cx8 switchboard Rob Herring (Arm)
2025-08-18 13:28 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89b7bbe5-604f-4990-8055-9ea8ba4cb934@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=molberding@nvidia.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®