From: Jay Dolan <jay.dolan@accesio.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v2 0/2] serial: 8250_pci patches to address issues with pericom_do_set_divisor()
Date: Wed, 17 Nov 2021 20:16:52 -0800 [thread overview]
Message-ID: <89c2f319-b0b9-3c64-e9f8-6c4081cdcce4@accesio.com> (raw)
In-Reply-To: <20211117145502.43645-1-andriy.shevchenko@linux.intel.com>
On 11/17/21 6:55 AM, Andy Shevchenko wrote:
> A series patches to address three issues one customer managed to hit
> all at once.
>
> 1) Fourth port not being setup correctly on some Pericom chips. Fix
> the entries in pci_serial_quirks array.
>
> 2) Rewrite pericom_do_set_divisor() to always calc divisor and to use
> the uartclk instead of a hard coded value. Always calculate divisor
> without passing control to serial8250_do_set_divisor().
>
> Jay, can you retest this, please?
I was able to verify that the fourth port was placed at the fixed
address for the card that previously had it at the wrong offset.
I was also able to verify all of the standard baud rates for 24 and
14.7456 MHz crystals from 50 to their respective uartclk speed on the
oscilloscope.
>
> Changelog v2:
> - dropped no-fixes patch, left only fixes here
> - amended refactoring of the ->set_divisor()
> - fixed Fixes tags
>
> Jay Dolan (2):
> serial: 8250_pci: Fix ACCES entries in pci_serial_quirks array
> serial: 8250_pci: rewrite pericom_do_set_divisor()
>
> drivers/tty/serial/8250/8250_pci.c | 39 +++++++++++++++++++-----------
> 1 file changed, 25 insertions(+), 14 deletions(-)
>
next prev parent reply other threads:[~2021-11-18 4:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 14:55 Andy Shevchenko
2021-11-17 14:55 ` [PATCH v2 1/2] serial: 8250_pci: Fix ACCES entries in pci_serial_quirks array Andy Shevchenko
2021-11-17 14:55 ` [PATCH v2 2/2] serial: 8250_pci: rewrite pericom_do_set_divisor() Andy Shevchenko
2021-11-18 4:16 ` Jay Dolan [this message]
2021-11-18 9:52 ` [PATCH v2 0/2] serial: 8250_pci patches to address issues with pericom_do_set_divisor() Andy Shevchenko
2021-11-22 11:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89c2f319-b0b9-3c64-e9f8-6c4081cdcce4@accesio.com \
--to=jay.dolan@accesio.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®