From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B43693F99E5 for ; Thu, 9 Jul 2026 10:18:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783592310; cv=none; b=qYW6+6Ivno7A6kLECmqcHpY0dDXUMC7utXIGgqB7zao0iER9HyMCbF9oyQ/1bZbsfB4gm68QKgSxUxkputk3ZobnC68oKkZQWEhrCPVf/5tAyaY9guhH+UDBjSqOGMdOG5n2/Q3b4GCpkyWhrFdXRwAGtBUrrFuajCCSfwlHm/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783592310; c=relaxed/simple; bh=yaj0W5X6oCbo4WUumWzVBVwkSEBMzMLAlQ6ucjWEMFw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cMvi3YvGA/WE9CJgGA4bPj8qjUfXE+OXTEXwC6T5cDtAEWXdUMeniVA6JzcIhd9iWlQLm8gNs32ggWMWus4YWjt+80N7jJ1EBEShjkFF85SPFTzLuYJM9lje4fjxZ13pJ25YMv/h3/VLwVxGJRTrI4V8KhYagjF8gtyckIG/CrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Fyb7d6Ju; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Fyb7d6Ju" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5aeb99bc721so179540e87.1 for ; Thu, 09 Jul 2026 03:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1783592307; x=1784197107; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=zrROiXI0zNUVTumAeHoman/juLPQPZ/xLG3NWye+Z/c=; b=Fyb7d6JuGilbcpyaQj2EFT5YTxZNFhmWDMD7IAaQ4m7antd4YUJ+mmbnARpRawgm3q tebchlo6bQ8mcMikjqs2+92KovTTEsWsN6aGLp3lI0rqyDsvvAlilt6YYqXTaE8xvGMS qmCZHEnLT/CPrk93aJgsWF58cUTe0zW8thZUpdb+U9BpMipZhLPVnymNicwCRrduCka9 BzjX6/MnjX22GGp4WePCwEUo62I1YuykEei80m4mcwMVoEZkIFeWcKEWS/Cf5ntE0I8F 8aie6gvXzTdya8ZZPy2XewjxQwBeOBczeP9sz4AAUC2C62IMab1+eRPrkTkfT03bbax7 AXZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783592307; x=1784197107; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zrROiXI0zNUVTumAeHoman/juLPQPZ/xLG3NWye+Z/c=; b=MQFpvyVfunEDTmBJRnKLuXKnMVCFl83fFSxuu5o6qN9uUKfjjHZ4dI627HekbPqe9d w/fbp7GEieqoLAzneMfFeDr8ENryhy4wFdz6GFStoHl4A9EVgybPj+w4n9y1z0/GgGxG qitGuTBvjKkr86wDwYOhPku66yXYrFFB1L2XO0qX8JSA9S70yaAGxMQYysLTQLUgbEzv ReHUguZvG8fzOjaFQxy3DCaYmInlJc6J5XfuahLIQXt0hchywpA1Ldon14xwg8GrcSRk DhxiYZUHQOsBLuXdCWPeQOeVW72ML+FL3eaNkGmTwb8zotias6lZWFZMQsNI7UluEwHu UdUg== X-Forwarded-Encrypted: i=1; AHgh+RpkJJ1rSAXckM9yuH276P7gNtZ+iA6BMxwVk757XhlC+cAMZKJpI5SDSnX1DcFXhlqrQz02h6wCgGORg38=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1vhckj8FvIAG13Ej5SVc//GMkEWRM0of6g5jdl1q6fw542Cns +hnl/kgS1mBBpWbnuQ2M3l9Ixp7bqFToIv8qqplu66GzcnMoe4PEcb+pPGQ97+YfoT4= X-Gm-Gg: AfdE7cmjil2Njfng3zNPyV1hqkSFbF2WsFfwiNIcd94I8XgObkghPHhhuLc9S0CLxAY 5GG+ue3x02iMyDllM+9pz14zvg6COW7GAYrr+D5ZIjNcjynJxGYq9y7fGF4+gcvNn5BFol/U0ZR dCXYehWgbZXvVSaGpUj65Td/gofIzIEUtQU+x7+XFISCmZaOLQbvjnbOCDQSbC11uKMJR1QH26Q zyDFP5IpB7T1SWiaMI+yYj8H/umK8fD/FqlJujgoxVHlJjmDYz195OXiagWupTK/oQIrX1Xj0tv Yvifqxv4aSC5yLCgM7pH/o8s9ZWwUKIX56n4P1RrmNe2+Ka9/7A19TW2MbV74HSfc7cn2ptj4UL xktf8Zd6uaTqeAQDrmsCJ235sfmR0FPNUoHR5+c7F31W+sujOes0rNgbpc0dDXul7vz7I7ewnCp vtOpJBsou32ntQ7gdP5mfHkZpmedLD+Czrq/lpNhGnsWyPypvJx7i0bXPwBiK9HpegkSw= X-Received: by 2002:a05:6512:a351:b0:5ae:bf93:d65a with SMTP id 2adb3069b0e04-5b01552c6bamr289400e87.7.1783592306874; Thu, 09 Jul 2026 03:18:26 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b0151b89cfsm531244e87.14.2026.07.09.03.18.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 03:18:26 -0700 (PDT) Message-ID: <89cc9f43-891d-4ef6-948f-37341c04411e@linaro.org> Date: Thu, 9 Jul 2026 13:18:25 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] clk: qcom: common: Register reset controller only when resets are present To: Imran Shaik , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: Ajit Pandey , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260708-shikra-audiocorecc-v2-0-b320d822cdd0@oss.qualcomm.com> <20260708-shikra-audiocorecc-v2-1-b320d822cdd0@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <20260708-shikra-audiocorecc-v2-1-b320d822cdd0@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/8/26 21:25, Imran Shaik wrote: > Some clock controller descriptors do not define resets. Avoid registering > a reset controller in such cases by checking desc->num_resets. > > Signed-off-by: Imran Shaik > --- > drivers/clk/qcom/common.c | 24 +++++++++++++----------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c > index eec369d2173b5ce24bc1ca860d2ac1bbdce04524..be9b6ebb2fffde05e3f209571c53b601d823d479 100644 > --- a/drivers/clk/qcom/common.c > +++ b/drivers/clk/qcom/common.c > @@ -359,17 +359,19 @@ int qcom_cc_really_probe(struct device *dev, > qcom_cc_clk_regs_configure(dev, desc->driver_data, regmap); > } > > - reset = &cc->reset; > - reset->rcdev.of_node = dev->of_node; > - reset->rcdev.ops = &qcom_reset_ops; > - reset->rcdev.owner = dev->driver->owner; > - reset->rcdev.nr_resets = desc->num_resets; > - reset->regmap = regmap; > - reset->reset_map = desc->resets; > - > - ret = devm_reset_controller_register(dev, &reset->rcdev); > - if (ret) > - goto put_rpm; > + if (desc->num_resets) { > + reset = &cc->reset; > + reset->rcdev.of_node = dev->of_node; > + reset->rcdev.ops = &qcom_reset_ops; > + reset->rcdev.owner = dev->driver->owner; > + reset->rcdev.nr_resets = desc->num_resets; > + reset->regmap = regmap; > + reset->reset_map = desc->resets; > + > + ret = devm_reset_controller_register(dev, &reset->rcdev); > + if (ret) > + goto put_rpm; > + } > > if (desc->gdscs && desc->num_gdscs) { > scd = devm_kzalloc(dev, sizeof(*scd), GFP_KERNEL); > Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir