From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF3FD2DA76A for ; Tue, 23 Jun 2026 09:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782205636; cv=none; b=m8pKjkwB0C7ZJJ2pv1UyTAyfp+9BZzzBYLHBkRrNjK3l4qZouiVCy+U2tLVKv96P7r4Uy6/rYOzEBL6ivuLyjl9od0tAcJrl/nMvevuDecA+cz9aX/EeEb1f3V62L6h4yhTuMqYIXYwdUA8COvH/LUA6/aasuxvTeqUm4X3aVDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782205636; c=relaxed/simple; bh=WukhzqxNcZwMEQXcGdz89FN159EkYgGHDb4TCOJ19SU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S7dHiZpO+kYuAh9g8RP/57Mkz1HZrfIKQ0SUt0xK2EYPbMoR4hiIqimt+/ZS4IQKhHf/mJwslKvutFSx7lSHuIdG1cXt/FtMSxIx+HYh70HKbJ1UMc0J959OfMw4OcaU3qv3N9GoNKm9gOa0sd4mAY3/Oedze/DaEvwnAx3zMJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Mgp0G0dF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jK9W367I; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Mgp0G0dF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jK9W367I" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N6coJS3547288 for ; Tue, 23 Jun 2026 09:07:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ynNpB9XvAD6eSLMQywfDBUNke/Uf1A8kYmXY2NhjcL8=; b=Mgp0G0dFB8pbwVk0 wj9ryNpuqJbsNfD0LfJuCfFhYshjeTITf8942Z2YbyqEF5QhWqpEwGzz96VTF5dr 94Jo07mIDrkXisOOUXKwyJby7AXRU0CmqX5D9jNg3s4mC9Fp7YfqFxycjZWSfGu/ r3NWrAyJ0z9oVnlvnOXV9mo1HabYIYRwipKYtFhASmM5A1he1pjWjsZiakVYqYi1 R966iBcb0fUwcrWgxIRuygV+GYFFsXiankjWL+6MLton7ac+q9ag6Zc8HR80NiRZ ARFbUttYAfJOJNxr5Fl1LB5tjUc0sDxsNzs2gWnx3R952Dei1U4GRC57Bjq7/m/8 n0YvCg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey3ebcc9b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 09:07:13 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-37c89e480easo5856120a91.3 for ; Tue, 23 Jun 2026 02:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782205633; x=1782810433; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ynNpB9XvAD6eSLMQywfDBUNke/Uf1A8kYmXY2NhjcL8=; b=jK9W367IT4DOi3pyzW+JYy/woyV2Wm33NodipDAnQlRd00M7DuSa0epui4mZumwKJX pI3DQPjcvy3iv4K4oicOiRoSEefO8JEFJbGIrGHVrlg7jMztS/xWqQ6vIAznQ77o7Lde rcRfSJkb+fAHLogFu1O+/E3gns/OFHhXOBYaxkfzYexlqNl6xYic27tFShT/fns59xso /oZCsdF72v1uVPUCYrhh//Kc2IlMsp+0Ve1AA/yGVLmYKgEHmQuA3KFYebJhIZdCS1+F LpSFe+l/Tzt5kigYnHWEKBxRlF2z+o/vgtofGsd/ihUjMIKgG2ANIDLf0h39/dW++RET j6YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782205633; x=1782810433; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ynNpB9XvAD6eSLMQywfDBUNke/Uf1A8kYmXY2NhjcL8=; b=gsQhdLQjRmiFh8meNz1UttWUwgLq2UCFVlBl4fAymY0QKiO/QtqXMqo69FUoZZ+//k I/sfSpzalbbH+cK2J1Sme/NIYYHMlEVGZk1J9U0LiKTzvel/fNKS0yx4CmpnaemHaiJ9 VZDgba+yRF8hBEyUXSrEEaI5yBQF5Pkaxrh9pDVR9hW9x6gxVdwNClwZwwL4jjK6OPQp 3FhXHj4jbjb43Rg1JK9/nIQtx+nKXcsS7AMm+EGoKq+9PjaKKNR3cFyorGA1bJQsjnse B4GM3g4xu2dI73eYXZry7tFn1Le7sm9Z8XRf5XL/Z4Jlv0g7PCFkTlki0/L5/ELLOQVL Zq6A== X-Forwarded-Encrypted: i=1; AHgh+RqpqTCw/+pDXgSVZ+p5bRugfaU5lIZiqkAX8n52YBbsznqXQqGYqJMdQ2WNCDGJ17tIfhKmNnK00LEQtP0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7MdtFFkVuNZMR54ZsHW76TXGYavfpnTxp0cpprgknla/vDFXZ YowQTjH5Ph/kqgLVQ1Izq4jHcGUJo0y7DmiDpB2fvFwpP+VdbhTL7hXdBad5CvULB83AAsuWTyV AeJQAOLPnsPHqfypQMHiSTpua2JKr/cBYVcLJIPknr+LVtrCHskhDxGpdUb12s81M+Ds= X-Gm-Gg: AfdE7cm9kuto+B4KHvdlhSgivKxTLeSf8s96oGC1fWJ+SUCG6igS+8kGgMzBND9An6j pLEC1nTbttSzYSFp5EMvc6i04db2LCKB6nVN1krN1caNxMdr7OReuARBjdQYJjIHvWI1IFl/wXM pjLax8wS9Sj5+uirTQPEJ4kd+7DgYhUyySxmV/0BWLjWB4iNXHwK+K0jYbDZFceZf2tOfSWeaTQ cW4Sbp6b6lFh/3/GDo98tltlHwFJrqI6xzZ272T9imOsm3DmyDT4cRccYVDW7gHBeFutTsPSNyy ofkcTa9lAmz9F+5z28lhV1fUttg3Jf2mouYvPn8HmDWMYW2XaSDPxx8DNiY6sli+DLylVUtfMRG 8zF2kuJuvZczh2k67htG8GDx9hV1NUe2WeH7K2fwTX1Cy X-Received: by 2002:a17:903:1a68:b0:2c0:b19b:ef0d with SMTP id d9443c01a7336-2c7c99de67dmr14775675ad.19.1782205632579; Tue, 23 Jun 2026 02:07:12 -0700 (PDT) X-Received: by 2002:a17:903:1a68:b0:2c0:b19b:ef0d with SMTP id d9443c01a7336-2c7c99de67dmr14775255ad.19.1782205631977; Tue, 23 Jun 2026 02:07:11 -0700 (PDT) Received: from [172.20.10.7] ([106.192.20.130]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7436d3505sm102101125ad.19.2026.06.23.02.07.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 02:07:11 -0700 (PDT) Message-ID: <89dad28f-c691-488c-bfc2-6ca3bd2068a8@oss.qualcomm.com> Date: Tue, 23 Jun 2026 14:37:01 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] dt-bindings: sound: add qcom,wsa885x-i2c To: Krzysztof Kozlowski Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20260610155708.151067-1-prasad.kumpatla@oss.qualcomm.com> <20260610155708.151067-2-prasad.kumpatla@oss.qualcomm.com> <20260611-debonair-barnacle-of-action-ee9d22@quoll> Content-Language: en-US From: Prasad Kumpatla In-Reply-To: <20260611-debonair-barnacle-of-action-ee9d22@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA3MiBTYWx0ZWRfXx09cOqRkIaWB xW44zux5API6KMxrciaT6QbHyD7ispSuIfRBO/yjHzO4GFagwLvGEzIZ4JlE3EnDP1KkxX/JSG3 nzGjaixPVMRSKKCC+Rf9+M3tfH96fPI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA3MiBTYWx0ZWRfX2TO0fIF+Jmte jGtgSJOCg376W+O4XBfGsrKdsAFEMFTX+SzMNfH10m3ehRL7f3dn3fWNmXT8SODBtNJQ6uSRzFB e2WvgNnZ8RFF6U1QPA8S9PndkF3zJ8NEtYiYFPLSCBdoPi9ZfUM2q8/kAK5dk5V3q64nb9qHSX9 DkZrnwF5dLcuBwLSnsQGlH8o6DjgZosey3+s5nIcVe/MV48Qw349aoPC4e6vMH7vpqFDKGgDTs7 tNPDc0ETC/h0fI/lheTdlG4fPAIBYOjq8WkFOGwO1gpN/l2QhLiKKx1iMc7BQo03PXIYlfSne2w 99Ve/xixEWIgOuVaubYPhCsI0SNBqGjpjR5LNw2jOQP+OMLscp0nNr/DeSUaJGs4swJyk4tiWT7 Snh+5/AZJyabJ0uliZSQwo4qIzggeiZhwQve2QGcjpA552ZqmFVT7gDJNNPR9elT12Vne7qDcdc Q5V8pULRgpSn1f5KgqA== X-Authority-Analysis: v=2.4 cv=ILIyzAvG c=1 sm=1 tr=0 ts=6a3a4cc1 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=GtHFPjVsJ1z6j8OeKiQY1g==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=gEfo2CItAAAA:8 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=1GWs3Cmanii3QIT9qZoA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=sptkURWiP4Gy88Gu7hUp:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: 2fxxEhy4TMSoBMRhpbWpy3Ahsx1PYlU8 X-Proofpoint-ORIG-GUID: 2fxxEhy4TMSoBMRhpbWpy3Ahsx1PYlU8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230072 On 6/11/2026 3:04 PM, Krzysztof Kozlowski wrote: > On Wed, Jun 10, 2026 at 09:27:07PM +0530, Prasad Kumpatla wrote: >> Document the Qualcomm WSA885X I2C smart amplifier binding. >> >> Describe the required supplies, powerdown and interrupt GPIOs, the >> optional battery configuration, and the optional init-table property >> used to program the device during codec initialization. >> >> This matches the driver programming model and documents the DT data > Binding matches hardware, not driver. Please describe the hardware. Hi Krzysztof, Thanks for reviewing the patch and for the feedback. Ack, Will add more HW details in next version. > >> needed to use the codec on platforms with Audio IF playback. >> >> Signed-off-by: Prasad Kumpatla >> --- >> .../bindings/sound/qcom,wsa885x-i2c.yaml | 89 +++++++++++++++++++ >> 1 file changed, 89 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/qcom,wsa885x-i2c.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa885x-i2c.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa885x-i2c.yaml >> new file mode 100644 >> index 000000000..1069f470d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/qcom,wsa885x-i2c.yaml > There is no I2C in device name. Ack, Will remove. > >> @@ -0,0 +1,89 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/qcom,wsa885x-i2c.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm WSA885x I2C smart speaker amplifier >> + >> +maintainers: >> + - Srinivas Kandagatla >> + - Prasad Kumpatla >> + >> +description: | > Do not need '|' unless you need to preserve formatting. Ack, Will Update. > >> + WSA885x is a Qualcomm Aqstic smart speaker amplifier with an I2C control >> + interface and a digital audio interface exposed through ASoC DAI callbacks. >> + >> +allOf: >> + - $ref: dai-common.yaml# >> + >> +properties: >> + compatible: >> + const: qcom,wsa885x-i2c > Same here > > Also, incorrect usage of wildcard. Look at other bindings how this is > written, so you will not repeat the same comments: > https://lore.kernel.org/all/20250522-rb2_audio_v3-v3-3-9eeb08cab9dc@linaro.org/ > > Read writing bindings before posting next version. > > I also cannot find traces of internal review of this. Did it happen? Did > you receive toolset comments? Ack, Thanks for the reference link, will cross check and update the bindings. No, there is o internal review done for this patch due to timelines. > >> + >> + reg: >> + maxItems: 1 >> + >> + '#sound-dai-cells': >> + const: 0 >> + >> + powerdown-gpios: >> + description: GPIO controlling the SD_N powerdown pin. >> + maxItems: 1 >> + >> + interrupt-gpios: > No, interrupts are never written as GPIOs. > > Where is this binding coming from? Agree, Will remove this and come up standard interrupt bindings in next version. > >> + description: GPIO used for the codec interrupt output. >> + maxItems: 1 >> + >> + vdd-1p8-supply: true >> + >> + vdd-io-supply: true >> + >> + qcom,battery-config: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: Speaker battery configuration, 1 for 1S and 2 for 2S. > Use string Ack. > >> + default: 1 >> + enum: [1, 2] >> + >> + qcom,wsa885x-init-table: >> + $ref: /schemas/types.yaml#/definitions/uint32-array >> + minItems: 2 >> + maxItems: 256 >> + description: | >> + Sequence of register/value pairs applied during codec hardware > No, we don't store register values usually. Ack,I'll move them into the driver as a register table, making them easier to maintain and avoiding opaque DT data. >> + initialization. Entries are encoded as alternating register address and >> + register value cells. The number of entries must be even (register/value >> + pairs); maxItems is 256 (128 pairs). >> + >> +required: >> + - compatible >> + - reg >> + - '#sound-dai-cells' >> + - powerdown-gpios >> + - interrupt-gpios >> + - vdd-1p8-supply >> + - vdd-io-supply >> + >> +additionalProperties: false > unevaluated instead. Again, OPEN other existing bindings. Why doing > something completely different? Is there any WSA88xx binding with > additionalProperties? No. Thanks for pointing this out. I'll align the schema with the existing WSA88xx bindings and replace additionalProperties: false with unevaluatedProperties: false in the next revision. Thanks, Prasad > > Best regards, > Krzysztof >