From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBBE6CA0FE2 for ; Tue, 5 Sep 2023 16:51:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241954AbjIEQsm (ORCPT ); Tue, 5 Sep 2023 12:48:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354539AbjIEMZm (ORCPT ); Tue, 5 Sep 2023 08:25:42 -0400 Received: from smtpout.efficios.com (unknown [IPv6:2607:5300:203:b2ee::31e5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6C3A1A8; Tue, 5 Sep 2023 05:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1693916735; bh=CPBdmsVi+RC8AZkE/89HdSzguIfSlQf/+GkllycK6Lo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RJcgXDpdCUilrU70w2ztD+Aqbe4WFPwMiS7gS3VQZkcqmxUeLdoJ+ujNMxc+5WJZP 2Z8ig75ftP+Pqcg06lZpFAKWqPs4V29AvJIJWZ8wYHQxhkOSi/FTIYLBp48+uplUux 3DhB+Ue5SnFudd6moHRjytH53ff1fyg+6I8rb1G+rECM8JHnOyyNTt/AGetfjp4hG2 7FAT/UZZi6U5g2Xm3PmJkD77xIcTSnmvf9G/m2Nn5P0OffxYdHUnMt46egYrqJG84L osugeOPdywqRKOw5OV0qr/6QIYC7x5oPO0+eikMkqi9OTvWZbL5eYUgtx9cb4UQISc t0+hA2cSdGBZg== Received: from [172.16.0.134] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4Rg4Tq2KcMz1NMR; Tue, 5 Sep 2023 08:25:35 -0400 (EDT) Message-ID: <89dc5f3f-f959-0586-6f3c-1481c5d3efc4@efficios.com> Date: Tue, 5 Sep 2023 08:26:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2] The value may overflow Content-Language: en-US To: David Laight , Denis Arefev , Lai Jiangshan , "Paul E. McKenney" Cc: Josh Triplett , Steven Rostedt , "rcu@vger.kernel.org" , "lvc-project@linuxtesting.org" , "linux-kernel@vger.kernel.org" , "trufanov@swemel.ru" , "vfh@swemel.ru" References: <20230904094251.64022-1-arefev@swemel.ru> <429249323d5f41ebbfa4f9e0294b2ddb@AcuMS.aculab.com> From: Mathieu Desnoyers In-Reply-To: <429249323d5f41ebbfa4f9e0294b2ddb@AcuMS.aculab.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/5/23 05:31, David Laight wrote: > From: Mathieu Desnoyers >> Sent: 04 September 2023 11:24 >> >> On 9/4/23 05:42, Denis Arefev wrote: >>> The value of an arithmetic expression 1 << (cpu - sdp->mynode->grplo) >>> is subject to overflow due to a failure to cast operands to a larger >>> data type before performing arithmetic >> >> The patch title should identify more precisely its context, e.g.: >> >> "srcu: Fix srcu_struct node grpmask overflow on 64-bit systems" >> >> Also, as I stated in my reply to the previous version, the patch commit >> message should describe the impact of the bug it fixes. > > And is the analysis complete? > Is 1UL right for 32bit archs?? > Is 64 bits even enough?? I understand from include/linux/rcu_node_tree.h and kernel/rcu/Kconfig RCU_FANOUT and RCU_FANOUT_LEAF ranges that a 32-bit integer is sufficient to hold the mask on 32-bit architectures, and a 64-bit integer is enough on 64-bit architectures given the current implementation. At least this appears to be the intent. I did not do a thorough analysis of the various parameter limits. Thanks, Mathieu > > David > >> >> Thanks, >> >> Mathieu >> >> >>> >>> Found by Linux Verification Center (linuxtesting.org) with SVACE. >>> >>> Signed-off-by: Denis Arefev >>> --- >>> v2: Added fixes to the srcu_schedule_cbs_snp function as suggested by >>> Mathieu Desnoyers >>> kernel/rcu/srcutree.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c >>> index 20d7a238d675..6c18e6005ae1 100644 >>> --- a/kernel/rcu/srcutree.c >>> +++ b/kernel/rcu/srcutree.c >>> @@ -223,7 +223,7 @@ static bool init_srcu_struct_nodes(struct srcu_struct *ssp, gfp_t gfp_flags) >>> snp->grplo = cpu; >>> snp->grphi = cpu; >>> } >>> - sdp->grpmask = 1 << (cpu - sdp->mynode->grplo); >>> + sdp->grpmask = 1UL << (cpu - sdp->mynode->grplo); >>> } >>> smp_store_release(&ssp->srcu_sup->srcu_size_state, SRCU_SIZE_WAIT_BARRIER); >>> return true; >>> @@ -833,7 +833,7 @@ static void srcu_schedule_cbs_snp(struct srcu_struct *ssp, struct srcu_node *snp >>> int cpu; >>> >>> for (cpu = snp->grplo; cpu <= snp->grphi; cpu++) { >>> - if (!(mask & (1 << (cpu - snp->grplo)))) >>> + if (!(mask & (1UL << (cpu - snp->grplo)))) >>> continue; >>> srcu_schedule_cbs_sdp(per_cpu_ptr(ssp->sda, cpu), delay); >>> } >> >> -- >> Mathieu Desnoyers >> EfficiOS Inc. >> https://www.efficios.com > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com