From: Michal Luczaj <mhal@rbox.co>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
virtualization@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH net-next v5 4/5] vsock/test: Introduce enable_so_linger() helper
Date: Thu, 22 May 2025 01:08:09 +0200 [thread overview]
Message-ID: <89df5f4b-6955-4f01-97a5-4d24dd82ed51@rbox.co> (raw)
In-Reply-To: <3uci6mlihjdst7iksimvsabnjggwpgskbhxz2262pmwdnrq3lx@v2dz7lsvpxew>
On 5/21/25 16:41, Stefano Garzarella wrote:
> On Wed, May 21, 2025 at 12:55:22AM +0200, Michal Luczaj wrote:
>> ...
>> static void test_stream_linger_client(const struct test_opts *opts)
>> {
>> - struct linger optval = {
>> - .l_onoff = 1,
>> - .l_linger = 1
>
> So, we are changing the timeout from 1 to 5, right?
> Should we mention in the commit description?
Yup, we do, but the value (as long as it's positive) is meaningless in the
context of this test. That's way I didn't bother. But since
enable_so_linger() is gaining @timeout, I'll pass the original `1` to keep
things as they are.
Thanks,
Michal
next prev parent reply other threads:[~2025-05-21 23:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 22:55 [PATCH net-next v5 0/5] vsock: SOCK_LINGER rework Michal Luczaj
2025-05-20 22:55 ` [PATCH net-next v5 1/5] vsock/virtio: Linger on unsent data Michal Luczaj
2025-05-20 22:55 ` [PATCH net-next v5 2/5] vsock: Move lingering logic to af_vsock core Michal Luczaj
2025-05-21 14:37 ` Stefano Garzarella
2025-05-20 22:55 ` [PATCH net-next v5 3/5] vsock/test: Introduce vsock_wait_sent() helper Michal Luczaj
2025-05-21 15:01 ` Stefano Garzarella
2025-05-21 23:06 ` Michal Luczaj
2025-05-20 22:55 ` [PATCH net-next v5 4/5] vsock/test: Introduce enable_so_linger() helper Michal Luczaj
2025-05-21 14:41 ` Stefano Garzarella
2025-05-21 23:08 ` Michal Luczaj [this message]
2025-05-20 22:55 ` [PATCH net-next v5 5/5] vsock/test: Add test for an unexpectedly lingering close() Michal Luczaj
2025-05-21 14:56 ` Stefano Garzarella
2025-05-21 23:17 ` Michal Luczaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89df5f4b-6955-4f01-97a5-4d24dd82ed51@rbox.co \
--to=mhal@rbox.co \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®