From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A7B0126BF7 for ; Thu, 13 Nov 2025 19:31:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763062305; cv=none; b=Rtg5/0EP9Ot9kyl1osP/1nY/jr2Qkc4v0Bo8Q7ZFq3iOfSMy1LBfZ4prTFdSCL2QJKrUI8w1wmi5BW09G7lF+BNuks1l0WMkARIJKE+hHQywzSJZiu/RPfVTgviEuxIkKg5JogsfqZwDdxETpJcqPo1SanIgbBMyCsNWjEpfX0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763062305; c=relaxed/simple; bh=hjONu7s8QYU7+5r+4+8392Rb/ODrCfjvMIjJFGLzOCs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NsttqKd9i68YOgwG2NMWdRohVPm9BfwjN8eH6gqwqTYgawt05TAGxJITtIn7mbjFMfw46yzZpFJbyFK8rl0WeSwSpINdh/JsjOmKzNfBB4OrGyXytrMSv89YnFw/II5xBsUG4R6AQqI/hL+est8kxC2tVLdHBh91HOzIIprmN6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZJJYYdCT; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZJJYYdCT" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-bc09b3d3afeso754651a12.0 for ; Thu, 13 Nov 2025 11:31:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763062303; x=1763667103; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=BK63ptxrNw7hKJ7SsWCptYH60Qc4eWwWIsrTT31syRM=; b=ZJJYYdCTZiRJMbOAB9TlopbbNbesQeWYwutDzrCiksJzVlvHB1koxOBgexDi2NGkEJ OKRmoCne9ExEBgayqQ2E8YkFakzEAauj/eTb+yPjoIBeozYVADd72VfGjYFR6uJtGaga CeiLVea354zmarrZtblps7+knx8VtWATbHE2tF7bLGcGCO4k59UjycRPZO684sfUEL0I 4LcFUl1fdlatwU2jQnlePZqChPEM5B04OmiNG9ZAq6k1fVFJQ6NNIbJ24446Yy0E9FUO M84vaUsLQhWDvpe+33ZGQkra5k5QZ1W58RFzFY7PLGINBFXK7NgDfmtrz+XmpvkX5sok 9wSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763062303; x=1763667103; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=BK63ptxrNw7hKJ7SsWCptYH60Qc4eWwWIsrTT31syRM=; b=EcrMmpCBdRmK/eDK92LXRMl+ShZZSJmbTzQ9rfL9U0Cnr4keXf11yTQV1DiDrFx+Fo siNW6H4lM2CBF8ITfiG+yhLtZnV6bsTKL0jcbk3j6eeiZmMkwACYryE/XjLmBMERgFZr elhdRPsZZCsuCX8iUbxdE3igsuEdfMpXMKLtTsfb4eSzCKiMptpKKofr8f3mgGLVA27+ 83ZQu00z6ccKyWb3xs8LW7HJKJKhb7rE2zE31iScqQOb4OiZbEZDNmcSEqwhsMMHGrir cJvrrGwpqUYy9mny045SoD+GZFKSJZqI8Xna5yldcq15tL2qHV96t+hnsAy3fbLR35CE PxzQ== X-Forwarded-Encrypted: i=1; AJvYcCULJmHSJ6dJnI7ruLgq6uiry4Ca+HHW67z3/P6mzbLAkga5A+ZcRPBhALLQ6kjiFgieWcvJ3rIOOMPGEGE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2+S3BqCa19SA8JncmKXAFEv8xP1KijlHKiBXFKKEG7a1iQrnl 1bfsS/dJYWqE4rGENIA2rc0ksCzZIqkHt/vqj9Rsb6zAf4qHmCuUvXLxB9ur3Q== X-Gm-Gg: ASbGncvmQOYeapUR110y+jglpEQwswMowdmHxafl1RnVjT2uoXe+TK4k3kxLVyBFFUj MTPoNtO25RGID2pqpNnya9doYHvwHHpLrklU5sYzMci9Ac9Nh8BM/HDT2m2cgs+UJFpCUJ+7lJX vR0FpzDHSYv0HcT3MQ+4qwQ53Vd7RwbdwP1dKnqaC815YZmrwtvUM4XKTZcyPGf7YFzcRilp57P WbyqmYtDie9SEHGY3CNRE6Phjfk/bWLcmt11Dz6KISwAIQ1sWzKGQ1qYKHwAg+x/KVUNFDdKQNq AODz1g672qmLqoc4pmRjeVEfGCvHecDKwkXQd/LNs/YI7QLU49wgMZZ9yhy8zQT3pSM+2Dxmbwa 3oY4VZt6Pzc29k/g7+dZSpWuUP41uYZ/AGEtVrR3v6uTL7D4X5iEkEmjA+QvPR+Vabj4xPX4U9W DZ/jrkyAqQI1yM X-Google-Smtp-Source: AGHT+IF8Qs3oK8rVfUqYvXgnjaYZ4iR3B3XnGJ1AUqt96hYmbod0XJb8usQsl7Escp+TSr657zoeDg== X-Received: by 2002:a05:7022:3b85:b0:119:e56b:91d9 with SMTP id a92af1059eb24-11b40f98615mr210070c88.10.1763062302783; Thu, 13 Nov 2025 11:31:42 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11b060885e3sm900826c88.0.2025.11.13.11.31.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 11:31:42 -0800 (PST) Sender: Guenter Roeck Date: Thu, 13 Nov 2025 11:31:41 -0800 From: Guenter Roeck To: Haotian Zhang Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] watchdog: wdat_wdt: Fix ACPI table leak in probe function Message-ID: <89e111c7-868f-4476-8a7d-98936674dee2@roeck-us.net> References: <20251113023032.547-1-vulab@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251113023032.547-1-vulab@iscas.ac.cn> On Thu, Nov 13, 2025 at 10:30:32AM +0800, Haotian Zhang wrote: > wdat_wdt_probe() calls acpi_get_table() to obtain the WDAT ACPI table but > never calls acpi_put_table() on any paths. This causes a permanent ACPI > table memory leak. > > Add a single cleanup path which calls acpi_put_table() to ensure > the ACPI table is always released. > > Fixes: 058dfc767008 ("ACPI / watchdog: Add support for WDAT hardware watchdog") > Suggested-by: Guenter Roeck > Signed-off-by: Haotian Zhang Reviewed-by: Guenter Roeck