From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2023C34026 for ; Tue, 18 Feb 2020 18:57:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8FDA22B48 for ; Tue, 18 Feb 2020 18:57:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Z+vOz7ZS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726415AbgBRS5s (ORCPT ); Tue, 18 Feb 2020 13:57:48 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:44490 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726318AbgBRS5s (ORCPT ); Tue, 18 Feb 2020 13:57:48 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 01IIv4AT108923; Tue, 18 Feb 2020 12:57:04 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1582052224; bh=lg/2Z6zca55Iu7jvMKJqSywmZdemYSmrtaUYfeNcE7M=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=Z+vOz7ZS7gut4Dor2Y7wFP7TzZRCGlKyp/WI42DHESu/+pb9F7FGCJ1V56vQ/klNO X/KMNTqyLgCLNgVKoj4JI3TGVjmhyPmnlcueD34g3yQjUDAvzNvkkz77CZBJMi5zFz 6N9pI3PPPoX2zhLS1xVWMWaJ1saaZ4T6qzXLp2ms= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 01IIv3wf023051 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 18 Feb 2020 12:57:03 -0600 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Tue, 18 Feb 2020 12:57:03 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Tue, 18 Feb 2020 12:57:03 -0600 Received: from [10.250.65.13] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 01IIv3qu066914; Tue, 18 Feb 2020 12:57:03 -0600 Subject: Re: [PATCH] ASoC: tas2562: Return invalid for when bitwidth is invalid To: Mark Brown CC: , , , , References: <20200218174706.27309-1-dmurphy@ti.com> <20200218184832.GL4232@sirena.org.uk> From: Dan Murphy Message-ID: <89e205b4-ba03-8db6-ff75-acec3d954b52@ti.com> Date: Tue, 18 Feb 2020 12:52:20 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200218184832.GL4232@sirena.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark On 2/18/20 12:48 PM, Mark Brown wrote: > On Tue, Feb 18, 2020 at 11:47:06AM -0600, Dan Murphy wrote: >> If the bitwidth passed in to the set_bitwidth function is not supported >> then return an error. >> >> Fixes: 29b74236bd57 ("ASoC: tas2562: Introduce the TAS2562 amplifier") >> Signed-off-by: Dan Murphy >> --- >> scripts/conmakehash | Bin 0 -> 13120 bytes >> scripts/sortextable | Bin 0 -> 18040 bytes >> sound/soc/codecs/tas2562.c | 3 ++- >> 3 files changed, 2 insertions(+), 1 deletion(-) >> create mode 100755 scripts/conmakehash >> create mode 100755 scripts/sortextable >> >> diff --git a/scripts/conmakehash b/scripts/conmakehash >> new file mode 100755 >> index 0000000000000000000000000000000000000000..17eec37019b8ae45f42f3c82046d1a55a6f69cb3 >> GIT binary patch >> literal 13120 >> zcmeHOeQ;D&mcN}25CU`u1i`Q23C#=v(j@XB0Wx-n4!le?@~!SFHl6fK(rc$X+x=RD > This is... fun? I'm guessing it's not intentional, it's certainly a > litt Ugh! Resending without the extra files. Dan > le difficult to review. :)