mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Polyakov <appro@cryptogams.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
	Danny Tsen <dtsen@linux.ibm.com>,
	linux-crypto@vger.kernel.org
Cc: herbert@gondor.apana.org.au, leitao@debian.org,
	nayna@linux.ibm.com, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, ltcgcw@linux.vnet.ibm.com,
	dtsen@us.ibm.com
Subject: Re: [PATCH 1/3] crypto: X25519 low-level primitives for ppc64le.
Date: Thu, 16 May 2024 10:38:43 +0200	[thread overview]
Message-ID: <89e7b4b0-9804-41be-b9b1-aeba57cd3cc6@cryptogams.org> (raw)
In-Reply-To: <87a5kqwe59.fsf@mail.lhotse>

Hi,

>> +.abiversion	2
> 
> I'd prefer that was left to the compiler flags.

Problem is that it's the compiler that is responsible for providing this 
directive in the intermediate .s prior invoking the assembler. And there 
is no assembler flag to pass through -Wa. If concern is ABI neutrality, 
then solution would rather be #if (_CALL_ELF-0) == 2/#endif. One can 
also make a case for

#ifdef _CALL_ELF
.abiversion _CALL_ELF
#endif

Cheers.


  reply	other threads:[~2024-05-16  8:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-14 17:38 [PATCH 0/3] crypto: X25519 supports " Danny Tsen
2024-05-14 17:38 ` [PATCH 1/3] crypto: X25519 low-level primitives " Danny Tsen
2024-05-15  8:11   ` Andy Polyakov
2024-05-15 12:59     ` Danny Tsen
2024-05-15  9:06   ` Andy Polyakov
2024-05-15 13:04     ` Danny Tsen
2024-05-16  4:53   ` Michael Ellerman
2024-05-16  8:38     ` Andy Polyakov [this message]
2024-05-16 11:39       ` Danny Tsen
2024-05-16 12:06       ` Michael Ellerman
2024-05-16 13:42         ` Andy Polyakov
2024-05-16 19:48         ` Segher Boessenkool
2024-05-16 11:38     ` Danny Tsen
2024-05-14 17:38 ` [PATCH 2/3] crypto: X25519 core functions " Danny Tsen
2024-05-15  8:29   ` Andy Polyakov
2024-05-15 13:06     ` Danny Tsen
2024-05-15 13:33     ` Andy Polyakov
2024-05-15 13:58       ` Danny Tsen
2024-05-15 14:20         ` Andy Polyakov
2024-05-16 19:28     ` Segher Boessenkool
2024-05-14 17:38 ` [PATCH 3/3] crypto: Update Kconfig and Makefile for ppc64le x25519 Danny Tsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89e7b4b0-9804-41be-b9b1-aeba57cd3cc6@cryptogams.org \
    --to=appro@cryptogams.org \
    --cc=dtsen@linux.ibm.com \
    --cc=dtsen@us.ibm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=leitao@debian.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=ltcgcw@linux.vnet.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=nayna@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®