From: Markus Elfring <Markus.Elfring@web.de>
To: "Duoming Zhou" <duoming@zju.edu.cn>,
linux-hams@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Jörg Reuter" <jreuter@yaina.de>,
"Paolo Abeni" <pabeni@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Lars Kellogg-Stedman <lars@oddbit.com>
Subject: Re: [PATCH net v2 1/2] ax25: change kfree in ax25_dev_free to ax25_dev_free
Date: Fri, 3 May 2024 07:36:54 +0200 [thread overview]
Message-ID: <89f07a73-90c6-4a81-9cec-7a1b7d61ea6b@web.de> (raw)
In-Reply-To: <81bc171fb2246201236c341e9b7d799f509d7dd4.1714690906.git.duoming@zju.edu.cn>
> The ax25_dev is managed by reference counting, so it should not be
> deallocated directly by kfree() in ax25_dev_free(), replace it with
> ax25_dev_put() instead.
You repeated a wording mistake in the summary phrase from a previous cover letter.
Please avoid confusion about desired code replacements.
How do you think about to append parentheses to involved function names?
Would you find the following change description a bit nicer?
The object “ax25_dev” is managed by reference counting.
Thus it should not be directly released by a kfree() call in ax25_dev_free().
Replace it with a ax25_dev_put() call instead.
Would you like to extend patch version descriptions (or changelogs) accordingly?
Regards,
Markus
next prev parent reply other threads:[~2024-05-03 5:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 23:36 [PATCH net v2 0/2] ax25: fix reference counting issue of ax25_dev Duoming Zhou
2024-05-02 23:36 ` [PATCH net v2 1/2] ax25: change kfree in ax25_dev_free to ax25_dev_free Duoming Zhou
2024-05-03 5:36 ` Markus Elfring [this message]
2024-05-03 11:33 ` Dan Carpenter
2024-05-02 23:36 ` [PATCH net v2 2/2] ax25: fix potential reference counting leak in ax25_addr_ax25dev Duoming Zhou
2024-05-03 7:30 ` Markus Elfring
2024-05-03 11:38 ` Dan Carpenter
2024-05-03 13:39 ` [v2 " Markus Elfring
2024-05-03 5:10 ` [PATCH net v2 0/2] ax25: fix reference counting issue of ax25_dev Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89f07a73-90c6-4a81-9cec-7a1b7d61ea6b@web.de \
--to=markus.elfring@web.de \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=duoming@zju.edu.cn \
--cc=edumazet@google.com \
--cc=jreuter@yaina.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=lars@oddbit.com \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®