From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: andersson@kernel.org, mathieu.poirier@linaro.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] rpmsg: glink_native: remove duplicate code for rpmsg device remove
Date: Fri, 22 Aug 2025 11:20:09 +0100 [thread overview]
Message-ID: <89f8bfd0-d8d6-45b4-bd06-d5507da258ee@oss.qualcomm.com> (raw)
In-Reply-To: <54moh5c4s4hssl47tabtlqm5mu33frf3x4k3fdhsrlc6abfltg@n6igz6vf5yd4>
On 8/22/25 11:14 AM, Dmitry Baryshkov wrote:
> On Fri, Aug 22, 2025 at 11:00:43AM +0100, srinivas.kandagatla@oss.qualcomm.com wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
>>
>> rpmsg device remove code is duplicated in at-least 2-3 places, add a
>> helper function to remove this duplicated code.
>
> I think it's better to sqiash this into the previous patch. Otherwise
> you are fixing the code that you've just added.
I did not wanted to add new cleanup code for backports, which is why I
split this up as fix and cleanup.
Am happy to merge these two if Bjorn prefers that way.
--srini
>
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
>> ---
>> drivers/rpmsg/qcom_glink_native.c | 43 ++++++++++++-------------------
>> 1 file changed, 16 insertions(+), 27 deletions(-)
>>
next prev parent reply other threads:[~2025-08-22 10:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 10:00 [PATCH 0/2] rpmsg: glink_native: fix leak and cleanup srinivas.kandagatla
2025-08-22 10:00 ` [PATCH 1/2] rpmsg: glink_native: fix rpmsg device leak srinivas.kandagatla
2025-08-22 10:12 ` Dmitry Baryshkov
2025-08-22 10:00 ` [PATCH 2/2] rpmsg: glink_native: remove duplicate code for rpmsg device remove srinivas.kandagatla
2025-08-22 10:14 ` Dmitry Baryshkov
2025-08-22 10:20 ` Srinivas Kandagatla [this message]
2025-11-26 20:10 ` [PATCH 0/2] rpmsg: glink_native: fix leak and cleanup Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89f8bfd0-d8d6-45b4-bd06-d5507da258ee@oss.qualcomm.com \
--to=srinivas.kandagatla@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®