Re: [PATCH v3 2/4] xen: add sysfs node for guest type

[Boris Ostrovsky <boris.ostrovsky@oracle.com>]

> diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
> index 84106f9c456c..d641e9970d5d 100644
> --- a/drivers/xen/sys-hypervisor.c
> +++ b/drivers/xen/sys-hypervisor.c
> @@ -50,6 +50,18 @@ static int __init xen_sysfs_type_init(void)
>  	return sysfs_create_file(hypervisor_kobj, &type_attr.attr);
>  }
>  
> +static ssize_t guest_type_show(struct hyp_sysfs_attr *attr, char *buffer)
> +{
> +	return sprintf(buffer, "%s\n", xen_guest_type);
> +}


So I know I gave my R-b for this patch but can't we just key off
xen_domain_type and not have xen_guest_type at all?

-boris