From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB8BC77B73 for ; Wed, 31 May 2023 17:05:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230117AbjEaRFk (ORCPT ); Wed, 31 May 2023 13:05:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230161AbjEaRFe (ORCPT ); Wed, 31 May 2023 13:05:34 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E45B1BD for ; Wed, 31 May 2023 10:05:13 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4f4db9987f8so1527578e87.1 for ; Wed, 31 May 2023 10:05:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685552708; x=1688144708; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jjHfNn96o09ujq49twnbOyS7k4yu4ycZG77+8eeKj3w=; b=BUbJeARTDHVcNqtk4Mk4rNIiLV1ECybQfKHTZ3clfEdZ3j2vELQLf7bEWqbay2M2zh y5S2amxX2y0tsjb6XQxNPlaXW9jR/1N8/6WI3wQ1Mg7oSX42/Rm9UUbtzaQurHFkNnqB /kfjBa8lY3IOBen+s6am3G93I3OMgmpIc00tiH/7/GBv96HtSgm4AKLLp2BfhJrIq17/ wwNh/iCPTUqzdPhLREl7SqaGsDC22rITFzaEM+R1p2NRefF3fZyH9rNfjq7pfIZW2JKe RMY+CHRFsgrhBNz/LhgPeHkUNQMPyYLbQYyPpszgJaWuE8OZc0YB05ma21mAD7tv3N3+ cwzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685552708; x=1688144708; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jjHfNn96o09ujq49twnbOyS7k4yu4ycZG77+8eeKj3w=; b=KWa9Sv19wJ8XfjlD9Ep1hn3PjiihDkTMaPrAErqLZoEAB/7GAFEq+9Ur60YwAIqhNx RwkQtDGLApqZD7sw+AlNI+DM13Em5w7+RQG6lbhsXCgQRxcHMzCQ+GsGx0itWiva8zKf ZwopZLtDumZuXMPFoOpGb0lsM1MRCAJi1Ky1gUK7RotQLSfcBMOZR67bZWXrg7dKODFR ikAVJ+viWWPGsbJlwzlWQlQE03pl3kWVnNdLNWQ9z2xaFYJca9THqMwYyHjQCmpCKVAh JK5Jc43yispYr8F/K1sNmxX+Dj1KMV+OuGKW3Q1obzZuRDyJk4MsFJHavg9Y0L+r7cTN mOmw== X-Gm-Message-State: AC+VfDyK0Me1cOitLlXK0gUveU+WgeuehKa559psDIzeX1Ip4+uiS5+2 fuugwjpzWIifWt2UKVAESoJWlg== X-Google-Smtp-Source: ACHHUZ7h+3mDDncWqXQw7osyAc9nTDp6PuIgnOVnqhDyhT9b+CMRpgeHZpqxRRCr7w38UY2ZG7RYKA== X-Received: by 2002:a05:651c:2044:b0:2af:222d:9695 with SMTP id t4-20020a05651c204400b002af222d9695mr4734651ljo.9.1685552707751; Wed, 31 May 2023 10:05:07 -0700 (PDT) Received: from [192.168.1.101] (abyj77.neoplus.adsl.tpnet.pl. [83.9.29.77]) by smtp.gmail.com with ESMTPSA id w6-20020a05651c102600b002ac833114besm3376606ljm.47.2023.05.31.10.05.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 10:05:07 -0700 (PDT) Message-ID: <89faee17-7858-194e-8af7-953a2631eb8d@linaro.org> Date: Wed, 31 May 2023 19:05:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] soc: qcom: icc-bwmon: Fix MSM8998 count unit Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230531-topic-msm8998-bwmon-v1-1-454f9d550ee5@linaro.org> <693a36cf-e9d5-a6f1-3953-3a7c7567a754@linaro.org> From: Konrad Dybcio In-Reply-To: <693a36cf-e9d5-a6f1-3953-3a7c7567a754@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31.05.2023 19:03, Krzysztof Kozlowski wrote: > On 31/05/2023 18:33, Konrad Dybcio wrote: >> MSM8998's BWMON counts in megabytes. Fix it. >> >> Signed-off-by: Konrad Dybcio >> --- >> drivers/soc/qcom/icc-bwmon.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > If this is > https://lore.kernel.org/all/33c61f23-6442-6d9b-492f-dd6e9c64a8c1@quicinc.com/ > (and QLT 1872) then add reported-by tag. It's not, I fired up 8998, added debug prints and ran mybw. > > Change seems logical, although not really documented (a bit > contradictory information for sdm845), so assuming this was really tested: It's not for sdm845, after the last cleanup both BWMONs on that one got its own driver data struct. Konrad > > Acked-by: Krzysztof Kozlowski > > Best regards, > Krzysztof >