From: Chris Wilson <chris@chris-wilson.co.uk>
To: maciej.rutecki@gmail.com, "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, airlied@linux.ie
Subject: Re: [REGRESSION] [2.6.36-rc1] [DRM INTEL] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for plane, expect flickering: entries required = 36, available = 28.
Date: Wed, 18 Aug 2010 20:13:12 +0100 [thread overview]
Message-ID: <89k83a$9bjd6q@azsmga001.ch.intel.com> (raw)
In-Reply-To: <201008182046.37732.maciej.rutecki@gmail.com>
On Wed, 18 Aug 2010 20:46:37 +0200, Maciej Rutecki <maciej.rutecki@gmail.com> wrote:
> Last known good: 2.6.35
> Failing kernel: 2.6.36-rc1
>
> During boot kernel display this message:
> [ 0.831906] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for plane,
> expect flickering: entries required = 36, available = 28.
To be honest, I was shocked at how often we were actually computing that
we required a larger FIFO for scanout than was available. Typically, it is
the result of the pessimistic latency we guess for the memory fetch and so
we err on the side of extreme caution when computing the watermark. So in
effect, we have been clamping the FIFO since the beginning, but we only
just added the warning message as an aide to diagnosing some FIFO
underruns. We could tone down the error message, the real goal though is
to improve the accuracy of the calculation and thereby reduce power.
> Systems seems work OK, but in 2.6.35 I don't have this message. On another
> system with 2.6.36-rc1 kernel I have the same message.
Yes, there was just a couple of places where we changed the calculation to
round-up but otherwise the wm logic remained mostly the same. So if you
haven't been experiencing FIFO underruns, e.g. the screen flickering, then
it is likely that the error is benign (and just wasting power).
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-08-18 19:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 18:46 Maciej Rutecki
2010-08-18 19:13 ` Chris Wilson [this message]
2010-08-19 7:55 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='89k83a$9bjd6q@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome