From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A8D7C0650E for ; Sat, 6 Jul 2019 11:03:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC421214AF for ; Sat, 6 Jul 2019 11:03:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726800AbfGFLD3 (ORCPT ); Sat, 6 Jul 2019 07:03:29 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:37173 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbfGFLD3 (ORCPT ); Sat, 6 Jul 2019 07:03:29 -0400 Received: from [192.168.0.113] (CMPC-089-239-107-172.CNet.Gawex.PL [89.239.107.172]) by mail.holtmann.org (Postfix) with ESMTPSA id DC2ADCEFAE; Sat, 6 Jul 2019 13:11:59 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH] Bluetooth: hci_bcsp: Fix memory leak in rx_skb From: Marcel Holtmann In-Reply-To: <20190528134258.3743-1-tomasbortoli@gmail.com> Date: Sat, 6 Jul 2019 13:03:21 +0200 Cc: Johan Hedberg , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <8B92FC2D-0E72-479B-8BF8-ADCCC3816286@holtmann.org> References: <20190528134258.3743-1-tomasbortoli@gmail.com> To: Tomas Bortoli X-Mailer: Apple Mail (2.3445.104.11) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomas, > Syzkaller found that it is possible to provoke a memory leak by > never freeing rx_skb in struct bcsp_struct. > > Fix by freeing in bcsp_close() > > Signed-off-by: Tomas Bortoli > Reported-by: syzbot+98162c885993b72f19c4@syzkaller.appspotmail.com > --- > drivers/bluetooth/hci_bcsp.c | 4 ++++ > 1 file changed, 4 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel