From: Joel Fernandes <joelagnelf@nvidia.com>
To: paulmck@kernel.org
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
Saravana Kannan <saravanak@kernel.org>
Subject: Re: [PATCH RFC] rcutorture: Fully test lazy RCU
Date: Sat, 28 Feb 2026 22:09:11 -0500 [thread overview]
Message-ID: <8C3B3E86-91D9-4F27-B385-CCCD0041B733@nvidia.com> (raw)
In-Reply-To: <07395baa-806d-4e12-84b2-c393aee064cd@paulmck-laptop>
> On Feb 27, 2026, at 7:39 PM, Paul E. McKenney <paulmck@kernel.org> wrote:
>
> Currently, rcutorture bypasses lazy RCU by using call_rcu_hurry().
> This works, avoiding the dreaded rtort_pipe_count WARN(), but fails to
> fully test lazy RCU. The rtort_pipe_count WARN() splats because lazy RCU
> could delay the start of an RCU grace period for a full stutter period,
> which defaults to only three seconds.
But call_rcu_hurry() should completely flush, so if we are still
splatting with it, does that not mean that there is a real bug the
splat uncovered?
> This commit therefore reverts the call_rcu_hurry() instances
> back to call_rcu(), but, in kernels built with CONFIG_RCU_LAZY=y,
> queues a workqueue handler just before the call to stutter_wait() in
> rcu_torture_writer(). This workqueue handler invokes rcu_barrier(),
> which motivates any lingering lazy callbacks, thus avoiding the splat.
But nothing should be lingering with _hurry().
> Questions for review:
>
> 1. Should we avoid queueing work for RCU implementations not
> supporting lazy callbacks?
I think so, best to isolate non Lazy cases so the barrier call does
not cause side effects.
> 2. Should we avoid queueing work in kernels built with
> CONFIG_RCU_LAZY=y, but that were not booted with the
> rcutree.enable_rcu_lazy kernel boot parameter set? (Note that
> this requires some ugliness to access this parameter, and must
> also handle Tiny RCU.)
Yes I think we should avoid.
> 3. Does the rcu_torture_ops structure need a ->call_hurry() field,
> and if so, why? If not, why not?
>
> 4. Your additional questions here!
Do we have a reproducer for the splat? If there is a link to the
report, I could take a look and investigate.
thanks,
--
Joel Fernandes
next prev parent reply other threads:[~2026-03-01 3:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 0:39 Paul E. McKenney
2026-03-01 3:09 ` Joel Fernandes [this message]
2026-03-01 4:14 ` Paul E. McKenney
2026-03-01 10:11 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8C3B3E86-91D9-4F27-B385-CCCD0041B733@nvidia.com \
--to=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=saravanak@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®