mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zack Rusin <zackr@vmware.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux-graphics-maintainer <Linux-graphics-maintainer@vmware.com>,
	"Roland Scheidegger" <sroland@vmware.com>,
	"DRI Development" <dri-devel@lists.freedesktop.org>,
	"Dave Airlie" <airlied@redhat.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH -next] drm: vmwgfx: add header file for ttm_range_manager
Date: Wed, 30 Jun 2021 20:36:29 +0000	[thread overview]
Message-ID: <8CB463FC-BF27-48CD-8843-975AE600DE35@vmware.com> (raw)
In-Reply-To: <20210630203252.32471-1-rdunlap@infradead.org>



> On Jun 30, 2021, at 16:32, Randy Dunlap <rdunlap@infradead.org> wrote:
> 
> Add a header file for ttm_range_manager function prototypes to
> eliminate build errors:
> 
> ../drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_init’:
> ../drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:678:8: error: implicit declaration of function ‘ttm_range_man_init’; did you mean ‘ttm_tt_mgr_init’? [-Werror=implicit-function-declaration]
>  ret = ttm_range_man_init(&dev_priv->bdev, TTM_PL_VRAM, false,
> ../drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_fini’:
> ../drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:690:2: error: implicit declaration of function ‘ttm_range_man_fini’; did you mean ‘ttm_pool_mgr_fini’? [-Werror=implicit-function-declaration]
>  ttm_range_man_fini(&dev_priv->bdev, TTM_PL_VRAM);
> 
> Fixes: 9c3006a4cc1b ("drm/ttm: remove available_caching")
> Fixes: a343160235f5 ("drm/vmwgfx/ttm: fix the non-THP cleanup path.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: "VMware Graphics" <linux-graphics-maintainer@vmware.com>
> Cc: Roland Scheidegger <sroland@vmware.com>
> Cc: Zack Rusin <zackr@vmware.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Christian König <christian.koenig@amd.com>

Thank you. That change has been part of drm-misc for a few weeks now:
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=352a81b71ea0a3ce8f929aa60afe369d738a0c6a
I think it should be part of the next merge of drm-misc to linux-next. If not I’ll port it to drm-misc-fixes.

z

  reply	other threads:[~2021-06-30 20:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30 20:32 Randy Dunlap
2021-06-30 20:36 ` Zack Rusin [this message]
2021-07-02 19:10   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CB463FC-BF27-48CD-8843-975AE600DE35@vmware.com \
    --to=zackr@vmware.com \
    --cc=Linux-graphics-maintainer@vmware.com \
    --cc=airlied@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sroland@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®