From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 340E72F3600 for ; Thu, 25 Jun 2026 07:21:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782372108; cv=none; b=DrHQQN+xpUC3JZLuw5lOYbsJF2zgYaiGD4vpkZgfxSew0YK3jg/7GC6R7osPEbcYqyUklVrBEk/JxWbR3x+2VyWFxCFSj3W+ikBqIpwVamNbKBVvnRVpFlLQprpQO0ZtYHMfgFG9HRgnwDa2p45NfY01xbYTk9vVPePu69g4ff8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782372108; c=relaxed/simple; bh=GK5OCCGpaPCkWmQItyOrt7IoPN7Vm7IoHjk4uyDscH8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DWNgS5lr1NDDbBblJxDC2hlTFlOCfrKMZRijIPOqflQviwRGjNPKRQnoc0WzotpYb/vAhvfGfHn0wP4ZbbyLFrYhTlnYdjVwg1n8Li/zD7HseQ45kLTyQcvGbjKx6jzBkdHSmSF5tH5ZFRVN6Cg5wuIMlu1UvZiDnAxCX9xXsk4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZmNyFAQK; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=H4UpW//G; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZmNyFAQK"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="H4UpW//G" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782372106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GK5OCCGpaPCkWmQItyOrt7IoPN7Vm7IoHjk4uyDscH8=; b=ZmNyFAQK1sYMDox9x2Qba99MlhwU75BuVCJrtlbHD+pLqG+frDR+NLMz+PDe26pISwiiyR vA6tf3S7wiww+k9e6jzCDEZm14ha1nPe746VsU3lJ33q24rLOxrcq10oNgQpDPJssOEEFw JGK+lOTA+I08FTWLHI5159qjGhAmuDI= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-52-eHJaKxyQN52N7mgq7S5WRA-1; Thu, 25 Jun 2026 03:21:44 -0400 X-MC-Unique: eHJaKxyQN52N7mgq7S5WRA-1 X-Mimecast-MFC-AGG-ID: eHJaKxyQN52N7mgq7S5WRA_1782372104 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-c0afbf73482so165667466b.0 for ; Thu, 25 Jun 2026 00:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782372103; x=1782976903; darn=vger.kernel.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=GK5OCCGpaPCkWmQItyOrt7IoPN7Vm7IoHjk4uyDscH8=; b=H4UpW//GlrrbeY+Zyx8CWhUcYRMV8+9RFC0o3iw2iqEBuMsZyciwYQlZnUmx+PWOgS o3yjZRND/t5NnFy5hMLx1gQ0gl23rTeadD7PLWRQG3kA8tPiluAYOKvq/LL9V3DR6JL6 IzMSzHAVhXPHoK203fUBUUowrQWY9UMy7/qHHxbRLUiLfi/wFp5UeoJO7hNQLgRp868D PJMZTqFyp+M0vx/woayIuekiIFYWOnpb9aJrrh1YsoPmRmvMTAG1wIMwr3eQIAYzD3qC BYR5GKZSSH5/xxjmxPD+RUUt/Yo8xgxr3iMUnAdw1mXfk4Zda9MrmILTc201yq4uMjtE wxoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782372103; x=1782976903; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GK5OCCGpaPCkWmQItyOrt7IoPN7Vm7IoHjk4uyDscH8=; b=blAAEemJomspf6xZgo0Vh4jmSX0tmlNIa1kpM3kOsY/6rjKYrB0T88z4g/9x+dhWDM jA5DOqdtS6+yzzm56/QbGbgqlmqJDDtc3GR7SdMfMW9h+PgWYAoKuZtX2mMg5QhMIe5t Mjqa6Th0pq2qqrAKeTqLtx5f+/TP82ne7r8nNxP0u6Lo1+A6EcvIoxjRWhetCjedMLp9 rda8L6XHGsoAbfxioWIBxlMtDH94QVe4Upq9bl1WaXMMgPupuFHSUNLYgZ2IIJad5R7q Fvsx6qWyStPaDlfv6SqSF8cKoAEREVIW/snyjSnkTspqmHY2p3IiL9VCAmC8zZrbQAXc aovQ== X-Forwarded-Encrypted: i=1; AHgh+RrjPYnchpDcSunQiuECJ21oRQ8CdxYSQin0IsbpT/Bl4BT1q+2dlAcmG09pUWnFRC8I8lBvDK6yq+Lc+co=@vger.kernel.org X-Gm-Message-State: AOJu0YwbUnDCUbTFPGwZ7Mo2B9A6XnTPwRB4Nfy1geVHwP1CKn0KNnlE p9UQm0zEdBRs1X9MbPDZxrpuG7BTTO+BKgkAhw2kuT0OxbahbTwD9CSvuZIaohvXaNLFuFAM5D0 n4/h0eIYH2NTOFNEAHJ2f0Z52PE6PeB6PhpOTQ+Sa8oSFYXVFTiI3bmANUZFU40LXqQ== X-Gm-Gg: AfdE7cnYkxUGzQXEV5jh64ZQg2xClYlijcLH16wMSWq8TwGsSdVr+3bDDkJ3kHJQJRT +zONDzvmZ+3GZuevna7RJxy4WiP2SPGlgZ6bGTtGdCzTsJkdx4bEn8HRchRoR1gVLY38WXzoDs7 DAEZy1jLcdvemK5HxtgXY+by+fthBif9eCyyzdRG+/9VCeBE4JTMGv5Pzk8X6dHViRq3HzegFEQ 6A/rrz5LCNwlXjzeTOpUy7q3fdtyWPYbavZ8xX1rwOqMQleLIWwt30myaBpEGnWyuvmVVmnIHmp ZgWwc18KH4aFqcz2plfFGQaYC+9czuQ8HU1s3fxFKggHDKiKFBpYhfcDrkA8bG3hmGmhr+eoisG ILrWTHM1o1JyvA+mnnGNdtASWwfHU0R+/dIgQ2Jwjt+ogbgUX0xl0VTSgVi3C X-Received: by 2002:a17:907:97cc:b0:bee:9809:3ccd with SMTP id a640c23a62f3a-c1205d98c17mr70145466b.4.1782372103567; Thu, 25 Jun 2026 00:21:43 -0700 (PDT) X-Received: by 2002:a17:907:97cc:b0:bee:9809:3ccd with SMTP id a640c23a62f3a-c1205d98c17mr70142866b.4.1782372103024; Thu, 25 Jun 2026 00:21:43 -0700 (PDT) Received: from [10.44.49.141] (5920ab7b.static.cust.trined.nl. [89.32.171.123]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c11fbe05c22sm117182866b.39.2026.06.25.00.21.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jun 2026 00:21:42 -0700 (PDT) From: Eelco Chaudron To: Runyu Xiao Cc: aconole@redhat.com, i.maximets@ovn.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn Subject: Re: [PATCH net-next] openvswitch: conntrack: annotate ct limit hlist traversal Date: Thu, 25 Jun 2026 09:21:39 +0200 X-Mailer: MailMate (2.0r6292) Message-ID: <8D2F8228-CA85-4522-8B39-07C1DB463AEE@redhat.com> In-Reply-To: <20260624150149.3510541-1-runyu.xiao@seu.edu.cn> References: <20260624150149.3510541-1-runyu.xiao@seu.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 24 Jun 2026, at 17:01, Runyu Xiao wrote: > ct_limit_set() is documented as being called with ovs_mutex held. It > walks the ct limit hlist with hlist_for_each_entry_rcu(), but the > iterator does not currently pass the OVS lockdep condition used > elsewhere for RCU-protected OVS objects. > > Pass lockdep_ovsl_is_held() to the iterator. This matches the function's > existing caller contract and lets CONFIG_PROVE_RCU_LIST distinguish the > ovs_mutex-protected update path from the RCU read-side ct_limit_get() > path. > > This was found by our static analysis tool and then manually reviewed > against the current tree. In the reviewed CONFIG_PROVE_RCU_LIST triage > run, the writer-side ct limit update produced the expected "RCU-list > traversed in non-reader section!!" warning while ovs_mutex was held, > with the stack matching ct_limit_set() and ovs_ct_limit_set_zone_limit(). > The change is limited to documenting the existing protection contract. > > This is a lockdep annotation cleanup. It does not change the conntrack > limit list update or release behavior. > > Signed-off-by: Runyu Xiao > --- Hi Runyu, I think net-next is still closed, so you might need to resend it once it opens. But the patch itself looks good to me. Reviewed-by: Eelco Chaudron