From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754408AbbBZS10 (ORCPT ); Thu, 26 Feb 2015 13:27:26 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:50978 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753770AbbBZS1Y convert rfc822-to-8bit (ORCPT ); Thu, 26 Feb 2015 13:27:24 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH 02/12] ARM: dts: apq8064: Add usb host support. From: Kumar Gala In-Reply-To: <1424678101-13009-1-git-send-email-srinivas.kandagatla@linaro.org> Date: Thu, 26 Feb 2015 12:27:18 -0600 Cc: linux-arm-msm@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <8D3BE083-44A4-4BCD-B09F-F6EC3EFECD77@codeaurora.org> References: <424678035-12862-1-git-send-email-srinivas.kandagatla@linaro.org> <1424678101-13009-1-git-send-email-srinivas.kandagatla@linaro.org> To: Srinivas Kandagatla X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Feb 23, 2015, at 1:55 AM, Srinivas Kandagatla wrote: > This patch adds device tree nodes to support two usb hosts on APQ8064 > SOC. > > Signed-off-by: Srinivas Kandagatla > --- > arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 40 +++++++++++++++++++++++++ > arch/arm/boot/dts/qcom-apq8064.dtsi | 47 ++++++++++++++++++++++++++++++ > 2 files changed, 87 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > index e641001..40657a4 100644 > --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > @@ -49,6 +49,46 @@ > }; > }; > > + rpm@108000 { > + pm8921_s3: pm8921-s3 { > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1400000>; > + qcom,switch-mode-frequency = <4800000>; > + }; > + > + pm8921_l3: pm8921-l3 { > + regulator-min-microvolt = <3050000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + pm8921_l23: pm8921-l23 { > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <1900000>; > + }; > + }; > + > + usb3_phy: phy@12520000 { > + status = "okay"; > + vddcx-supply = <&pm8921_s3>; > + v3p3-supply = <&pm8921_l3>; > + v1p8-supply = <&pm8921_l23>; > + }; > + > + usb4_phy: phy@12530000 { > + status = "okay"; > + vddcx-supply = <&pm8921_s3>; > + v3p3-supply = <&pm8921_l3>; > + v1p8-supply = <&pm8921_l23>; > + }; > + > + usb3: usb@12520000 { > + status = "okay"; > + }; > + > + usb4: usb@12530000 { > + status = "okay"; > + }; > + > amba { > /* eMMC */ > sdcc1: sdcc@12400000 { > diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi > index db5fc59..e33eb03 100644 > --- a/arch/arm/boot/dts/qcom-apq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi > @@ -2,6 +2,7 @@ > > #include "skeleton.dtsi" > #include > +#include > #include > #include > #include > @@ -487,6 +488,52 @@ > }; > }; > > + usb3_phy: phy@12520000 { > + compatible = "qcom,usb-otg-ci"; > + reg = <0x12520000 0x400>; > + interrupts = <0 188 IRQ_TYPE_NONE>; I think the IRQ_TYPE should be IRQ_TYPE_LEVEL_HIGH (same for all other interrupts) Also can we use GIC_SPI > + status = "disabled"; > + dr_mode = "host"; > + > + clocks = <&gcc USB_HS3_XCVR_CLK>, > + <&gcc USB_HS3_H_CLK>; > + clock-names = "core", "iface"; > + > + resets = <&gcc USB_HS3_RESET>; > + reset-names = "link"; > + }; > + > + usb4_phy: phy@12530000 { > + compatible = "qcom,usb-otg-ci"; > + reg = <0x12530000 0x400>; > + interrupts = <0 215 IRQ_TYPE_NONE>; > + status = "disabled"; > + dr_mode = "host"; > + > + clocks = <&gcc USB_HS4_XCVR_CLK>, > + <&gcc USB_HS4_H_CLK>; > + clock-names = "core", "iface"; > + > + resets = <&gcc USB_HS4_RESET>; > + reset-names = "link"; > + }; > + > + usb3: usb@12520000 { > + compatible = "qcom,ehci-host"; > + reg = <0x12520000 0x400>; > + interrupts = <0 188 IRQ_TYPE_NONE>; > + status = "disabled"; > + usb-phy = <&usb3_phy>; > + }; > + > + usb4: usb@12530000 { > + compatible = "qcom,ehci-host"; > + reg = <0x12530000 0x400>; > + interrupts = <0 215 IRQ_TYPE_NONE>; > + status = "disabled"; > + usb-phy = <&usb4_phy>; > + }; > + > /* Temporary fixed regulator */ > vsdcc_fixed: vsdcc-regulator { > compatible = "regulator-fixed"; > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project