From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754060AbaIPXuh (ORCPT ); Tue, 16 Sep 2014 19:50:37 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:45729 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753163AbaIPXug convert rfc822-to-8bit (ORCPT ); Tue, 16 Sep 2014 19:50:36 -0400 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH] ARM: dts: Add initial DTS file for Sony Xperia Z1 phone From: Kumar Gala In-Reply-To: <5418C471.9000807@sonymobile.com> Date: Tue, 16 Sep 2014 16:50:33 -0700 Cc: "linux-arm-msm@vger.kernel.org" , =?windows-1252?Q?=22Andersson=2C_Bj=F6rn=22?= , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "arnd.bergmann@linaro.org" Content-Transfer-Encoding: 8BIT Message-Id: <8F13381C-BBEF-4602-B5C4-A885B946BDBB@codeaurora.org> References: <5418C1D2.4000303@sonymobile.com> <27E278AA-EBC0-4368-B75C-DCB2DD906612@codeaurora.org> <5418C471.9000807@sonymobile.com> To: Tim Bird X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sep 16, 2014, at 4:14 PM, Tim Bird wrote: > > > On 09/16/2014 04:08 PM, Kumar Gala wrote: >> >> On Sep 16, 2014, at 4:03 PM, Tim Bird wrote: >> >>> This DTS has initial support for just a serial console, for the >>> Sony Xperia Z1 phone. This phone uses a QualComm 8074 processor. >>> >> >> Qualcomm, the C isn’t caps. > > Will fix. >> >>> Signed-off-by: Tim Bird >>> --- >>> arch/arm/boot/dts/Makefile | 1 + >>> arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts | 18 ++++++++++++++++++ >>> 2 files changed, 19 insertions(+) >>> create mode 100644 arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts >>> >>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >>> index b8c5cd3..680ce7e 100644 >>> --- a/arch/arm/boot/dts/Makefile >>> +++ b/arch/arm/boot/dts/Makefile >>> @@ -341,6 +341,7 @@ dtb-$(CONFIG_ARCH_PRIMA2) += prima2-evb.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += \ >>> qcom-apq8064-ifc6410.dtb \ >>> qcom-apq8074-dragonboard.dtb \ >>> + qcom-apq8074-xperia-z1.dtb \ >>> qcom-apq8084-mtp.dtb \ >>> qcom-msm8660-surf.dtb \ >>> qcom-msm8960-cdp.dtb >>> diff --git a/arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts b/arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts >>> new file mode 100644 >>> index 0000000..59b3fa1 >>> --- /dev/null >>> +++ b/arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts >>> @@ -0,0 +1,18 @@ >>> +#include "qcom-msm8974.dtsi" >>> + >>> +/ { >>> + model = "Sony Xperia Z1 phone"; >>> + compatible = "qcom,msm8974”; >> >> Should have a board compat as well > I'll ask Bjorn what we want to do here. There was a compat that I stripped, > but I'm not sure we settled on the official name we want. In any event, > will fix. >> >>> + qcom,msm-id = <126 8 0>, <185 8 0>, <186 8 0>; >> >> We don’t have qcom,msm-id upstream at this time. > Do I just leave this out, then? yes, lets drop it for now, unless you guys need it to boot the upstream kernel on your hw. > > Thanks. > -- Tim > > P.S. By now you probably noticed I mis-typed device-tree@vger.kernel.org. I'll fix that also. -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation