From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E13153D7D69 for ; Fri, 24 Jul 2026 09:28:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784885302; cv=none; b=V/s3BMzsOfWn+g4kAT6Pl1oByCevYGThJKhP0GwlD0K0LqRF77gVz8hulveBjVPWPLK4WnnAkptU74hL9qtm06K0t673hHw5mxIbMaRAKGA3QqkgIrG8KyA0U78ezBsqkbx9xYqSFw0hkOIDGGr4wcF3AUEK+KUdKuywLMaEzDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784885302; c=relaxed/simple; bh=JS+IFyx0Nx5QnGWEAUcELDS9dig3ky8MVWpuyJmtYrU=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=cwomZWBUkqMLN0Bp2UJB4Jd4LdsJSzaaUyLg7mgUXv1gn5qKf+ZuWCQSZIdtXFPHad4ZYgxi9Ck4nF//7ImrF0jqNNLgtODS8aF1FJ6bsqUXfOB4n8utwNVtVJMylE6eSlmvbSxK6YEH+brn1s82H/8XW+8ENJ4mi4V7HvDFeeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HQF6eere; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HQF6eere" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cf420670bbso412365ad.1 for ; Fri, 24 Jul 2026 02:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784885300; x=1785490100; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:from:to:cc :subject:date:message-id:reply-to:content-type; bh=JS+IFyx0Nx5QnGWEAUcELDS9dig3ky8MVWpuyJmtYrU=; b=HQF6eereYndxrC2OYConm7qiAcfHitE8pQHzCChkydi8QkWQUXHSyxFX5pdjo92UrY kVD4q0wVwaQfXEMyaRNNXHRrcHEwwvHbTqa7qJPY6At7OsA4PsmtQvP8VVYOJNOoW+hV OyfY7fGXtVH7yNsuj9ZuHlgGYF1bNfEFJByU8W9VvmYrFx/WAC0bc4HAF8J+SUcd7sdm zZ8GQIIJE/rR/bOKmrGQG0BfarUv7OD+OR/dHa8HsKkih/kwPbo7GHAAHG0hqG/RgjN9 NCX9P0hFRsyEVi1Qm55NwG+XW+OivHNQrGyGkz7nHyiixRYyPYMYfVVjGNLlStgaXEcu udPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784885300; x=1785490100; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JS+IFyx0Nx5QnGWEAUcELDS9dig3ky8MVWpuyJmtYrU=; b=e8ixQtvpyrNoMhHHdOYnyT/g4scDDgnAO8rvalNBWai8GYf80yWGKPZxE9kbPyvy8P KmrZIBfQh6XE2uvmvWF9vDzMvr/G9QBq0mrh5KLjX43xeKoQ2iK91VCQJMv0Trg08AoT ZeLV0AoJUdbV6+0cPWYbxm8EwU3ZEE/j3REOTgZ19elAQejgw416LE0Gyo9dZ9mIUXC/ X3zJrw6v6LEPfdqZ1BUBXH1+VodUpy1DtgDQybuF/2ZH3ot2oaoSs6J0jb8D3eBJhKBq 3VdO4DQPasWA07mDUWzUUqtw1+eiqaYuILCVSg6Mw4dOYPHEkjcfJDiRCzwVxDtyWwac JKKA== X-Forwarded-Encrypted: i=1; AHgh+RqxKlIF8r45mDzdA9a24QJ2hm4XC7Z8QXwcsbRI8yVIpf/654T6szHpiBxhvFUd2BL2MpthS1S3Q/FDEBU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/cgN65AH1iNknzcHHoP8bxzfbjhZzIuNiMVSAWVjiNPVgHPXF sbQ2j7uOM8jjnv7PG/2fcG+/3iXQeUU2OAKS7q3ARcSJOE6li1y42MQqQLd7/RPQHXk2L7J2 X-Gm-Gg: AR+sD12gP/WaiiculAK2CzewFtTvy+/ese57kFcV+jehoRcTIqQANjKNUnCoOxMW/iy 8XWAKo020BUXsA8Gq6NQ2b3i4MyTUETX+twoM90T1e3BayIS8hE52JlvQ9z4M0dzsNwvEMf9HI2 hw68Er2Z+ngi8NMw+INP9JI59JOM0sME/LtEyIDGq0r+fBYjH2jXscit0H7W6+SEt5KkOdUGiGS zTrU0PeYwlnRCNxdfQj24BYEXM/cBRspNZQBYVQNywCooos/OtPhtR8lQzNj69+2KwjPMeamkX0 uQBwMa7v/9j3zuDnUV4DNry+mjw29Gohl2MLD+UDu216RbRwXRDYjFPedOOGb3ft+UqW/qPjVHV S17aM3525ckR4iucigR3HFFLGncZxMBvh0s/CCOvRsuToHVaCtavsQoQNcIVJL18f1ageUQTV5U 56gYkVzwm0GFqqi6hrIdOVptQd X-Received: by 2002:a17:902:d550:b0:2ca:d344:7752 with SMTP id d9443c01a7336-2cfbd6a970amr27757825ad.8.1784885300129; Fri, 24 Jul 2026 02:28:20 -0700 (PDT) Received: from smtpclient.apple ([23.247.139.92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f310644sm48128715ad.55.2026.07.24.02.28.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jul 2026 02:28:19 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.8\)) Subject: Re: [PATCH RFC v3 0/7] mfd: ls2kbmc: multiple fixes for this driver From: Miao Wang In-Reply-To: Date: Fri, 24 Jul 2026 17:27:58 +0800 Cc: Binbin Zhou , Chong Qiao , Lee Jones , Corey Minyard , Linus Walleij , Bartosz Golaszewski , Xi Ruoyao , WANG Xuerui , Yinbo Zhu , Jiaxun Yang , mfd@lists.linux.dev, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, openipmi-developer@lists.sourceforge.net Content-Transfer-Encoding: quoted-printable Message-Id: <8FCFD614-FEA4-475C-9E0C-50E075B49453@gmail.com> References: <20260710-ls2kbmc-mod-v3-0-ef718636e78e@gmail.com> To: Huacai Chen X-Mailer: Apple Mail (2.3826.700.81.1.8) Hi, > 2026=E5=B9=B47=E6=9C=8824=E6=97=A5 16:55=EF=BC=8CHuacai Chen = =E5=86=99=E9=81=93=EF=BC=9A >=20 > Hi, Miao, >=20 > On Fri, Jul 10, 2026 at 1:24=E2=80=AFAM Miao Wang via B4 Relay > wrote: >>=20 >> Previously, the driver has been introduced to support the Loongson 2K >> BMC running on the Loongson Servers, which is essential to prevent >> the system from hanging when the BMC is being reset and the default >> efi-framebuffer is being used. However, there are some drawbacks in = the >> driver. >>=20 >> Firstly, the driver tries to read and write to the connected PCI-E = host >> controller registers, assuming that the BMC is connected to LS7A = PCI-E >> host controller. This assumption should be true for real products, = but >> to prevent from accidentally reading and writing to the wrong PCI-E = host >> controller, this driver should be modified to check this before >> accessing the registers. >>=20 >> Secondly, the driver uses non-exported functions to tell the vt >> subsystem to redraw the screen, preventing the driver from being >> compiling as a module. This can be fixed by using the exported >> functions instead. > You can replace the redraw function, but I don't think it is necessary > to make the bmc driver modular. >=20 > BMC core, IPMI and simpledrm display are usually (if not always) > supposed to work as early as possible. I believe that it should be the user's decision to choose whether to compile a module into the kernel or as a module and it would be better if we can provide the possibilities for the user to choose from. Additionally, I don't think these modules are supposed to work that early. The mfd module provide two functions, the display and the ipmi device. In the aspect of graphical display, without this module, the user can still see the output during booting on their monitors, since efifb is working, providing a basic display function. In the aspect of the ipmi device, I don't think the lack of such device will influence the boot of the system, since it is a common practice to compile ipmi device drivers as modules on other architectures. As a result, neither of the two functions are required to be loaded that early and it is reasonable to at lease leave the choice to compile it as a module to the user. Cheers, Miao Wang