From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54F98204C3B for ; Wed, 24 Jun 2026 06:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782281830; cv=fail; b=XD3Ta6G8I/3AaATtjxAEjMNZHerD0wldqxG/amawdQpwujJff1MWFJNZjsG5KE5gHP8xr/fcahTFewxqOLpgoT46/UAM7mUqlaoh1g9GSPJU4n5bxN3tzRaFy+nfqcVDUOUkzlb8Hn3ZJSW9mNOIVEokwAr4HpQgD1uYyqtyx8E= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782281830; c=relaxed/simple; bh=SC0u+Z2PaJbTc/iyqcOGc0lVUzuDMGGFfbeE8wpXN+g=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=W3mOR6C2L1QAzxSi3GX9j55l1yMZv8zI90VMmK8Q12uUDJ4VsQyW7lUK4YuGyw9GUWL5PR7BNkoachES454OApFPixlE/hOP0lVmVfWf6TmMfAbeWjMHyf/rcaOg8hAMM9VyZ+s8i9S6aduMn0YgPZnsNR9S3ib+vptATWGgVdA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fdjW+gKb; arc=fail smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fdjW+gKb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782281829; x=1813817829; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=SC0u+Z2PaJbTc/iyqcOGc0lVUzuDMGGFfbeE8wpXN+g=; b=fdjW+gKbpLrGyGQocQfnzIR0K4lfsqdwq99m4rMOi6059f1Rp9wN2cmn InDEt3o4B/p6ngUbLzHoK8X+OVo8TBY0hsFFZEnu4QUtapA4ldv08H1eS 9G5i8huYPUkSdFbVO95zIoeneLa0+axFYkCvaZb8rwLOYx78lGlJvhCAN A0/lIcEZgWj6YjU7Jv6unyQgWEymIpOclEWoUFUJIh3aiNLEUpFf3y2ez eoHBwHYaJ65DoK4b2tJ68EKC6gsgKo0XfSX5lc8GdxrdMo1oGvvRfIxki rvddt46ws700U2cOgPQXXq4Jip0WHGoWoVVmlMKpzGcSdOPubmeMcL15z g==; X-CSE-ConnectionGUID: 2lVRbUAbRUCXbgNhJaOCRQ== X-CSE-MsgGUID: KTuzv7RuT3+DU9ELdsDkUQ== X-IronPort-AV: E=McAfee;i="6800,10657,11826"; a="93393264" X-IronPort-AV: E=Sophos;i="6.24,221,1774335600"; d="scan'208";a="93393264" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2026 23:17:08 -0700 X-CSE-ConnectionGUID: gTrZV3HgTNSmlw2NhSzYrQ== X-CSE-MsgGUID: typ9AvHQRjGVSiYwMEs/YQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,221,1774335600"; d="scan'208";a="246823320" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2026 23:17:08 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 23 Jun 2026 23:17:08 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 23 Jun 2026 23:17:08 -0700 Received: from CH5PR02CU005.outbound.protection.outlook.com (40.107.200.42) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 23 Jun 2026 23:17:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zJ2WSkyfjmAfkZ5giSogClwoXdm7+xNthKhLRIdIFFExut+TRPNIDURNL2hyTn6ixIzxxePDzb4EHUiX3wvcrGqKv5KH+XVhjZMeNCkUlHgFITxkV3cK6gqzu6VluU0aXo2WwBBUpHw6Ex65AbOgULGX0ZI7AT4bPyWU8i8iFN2fdEERJxWErQtx/SuOvGumT9ed4kWNxG/hD++GAbTwznJhZmUavZ6BO6gyNh3cKGwxmZiEK8TO/YAjLdUFnuXC/yu93kKl0HPzZTfUoj5nFZ+iHlpl4NotMx6EmKPbqtDPYCcmqAGkomiJNz5ksgqTcGREdJhkO+cdQB+RyLwy3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dCGXJBqueh9c4C3CbrGNaMswuqHYr0VkgD/Ia/T1ILk=; b=re+7tc76lvZlsKwH8MkOOegv2d8i9Pn5JxOb1bWQ5ahNx9X2TWu1JgyjT1uQSU/fslvLtNh+uKW8Lq70mTVlnH72EBPfUIXoObbBArsw5UdWfuAHGL6i1iDkMtm+Moaq7slRTdQmmQUSUhheP9JM+gt9NqhKW1P/f3iTyYrihVSyGewgNay1LmeQIZ0wqyh3eZA2JC6Fe0BU9GHiFhQH7dYpyAOYkBUw5wCYgNde52yn49S9oT/Teye20TQqbru5kCSPmLI5zoIJWsNQ7JoJ4nLc0PY058FqrSyBRDXs8VXGrkcOHN2PNyPG3BFTGkQQOuSRqxirAriQKqaSvOvsxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) by SA1PR11MB7131.namprd11.prod.outlook.com (2603:10b6:806:2b0::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.20; Wed, 24 Jun 2026 06:17:02 +0000 Received: from DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765]) by DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765%4]) with mapi id 15.21.0159.012; Wed, 24 Jun 2026 06:17:02 +0000 Message-ID: <8a00ee8b-0905-4d7f-aa7e-56adad39182d@intel.com> Date: Wed, 24 Jun 2026 14:16:51 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/6] x86/resctrl: Rename prev_msr to prev_mon_val To: Reinette Chatre CC: , , , , , , , , , , , , , References: <2e9bd6a1a012b937e9205908ab6bbb09a21e0f71.1781332698.git.yu.c.chen@intel.com> <3ee018f0-689d-4175-bfd2-dda62a4aa45b@intel.com> <4ee138d9-3d42-4452-a24d-b183690836ea@intel.com> <32f450b0-9357-42b6-b3c6-637bc99c5789@intel.com> Content-Language: en-US From: "Chen, Yu C" In-Reply-To: <32f450b0-9357-42b6-b3c6-637bc99c5789@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SGAP274CA0018.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::30) To DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6020:EE_|SA1PR11MB7131:EE_ X-MS-Office365-Filtering-Correlation-Id: 48976db0-64c3-4f13-e929-08ded1b83480 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|23010399003|7416014|376014|22082099003|18002099003|4143699003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: 1osRIuJX+uR15kmIUlBj8Q6EbmX8JSPpc8vTgj6IfFPhVmWhidAvV3e4OfbyFqjceWLb+0HPcBy+f65US4sN4O2aJJELIXg/XtusUNgG7WCVSCSTt2udj0I3eM5PSKmyBV/LZ8P19JBNE2ggb2Ok0sxI5kAs2v1kqBwB6KtH3XjtaE6ZSDqjFsJZpIe8o1l0BT3rwKUKAJl6DK8LlurnnZTgpHzoePVcOXj4DOxsptawwQ9Dog0g6dp6i29Yg5dtClb5tIzAlzulSCrTPY9VZrDcqAvEYlHUOhbkDk5GlATLDCz3aonE03IxV9dk3a7ANdzJRiZSWm5n80XSIGl24Wa8E/Z77Ed59DfRP1+3bpmMlHvx56yP3gPNnnmUU+ccYf137NzbTAEMfI/l3xMXrQyyGIYG2QDitH3lW3yw6Y2DL71veX2GTrDgtKUhw9o6A1WBVCJmIJZ/CCP/+MCQa4l34S6Kt7m1eX/RB4YyuRNZJL6iBMoUwZ/dmWBHKM++0/0IG4Y6PCa9IM1MVKygvfFQyS1uXRgoOJ0WhQpQRT8GEq1l1wZFMrHnNMLocXGcZpJDsNXwjIG+hK6qJX9pQDImueLXkuIh1Q1u+K/TqY7H1S2i0ujaiuCCjA6Yi5V81zGNnPvZZC+iFfSmq7KBJOFBPGB/mViqAKOEBklpj0Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6020.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(23010399003)(7416014)(376014)(22082099003)(18002099003)(4143699003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2dOZ2JQTkl3cVk0RmgvZWNoemV1eGlha2VwYmJVdnd3ZVZTYTRzQ2d5TFpi?= =?utf-8?B?TW1ualNyZkwzTjZwNlRGV0YwdWRGNmFHUjd3UkduUDBudGo5UzNEQkcxQXlN?= =?utf-8?B?SkppWUNtdFpTRjlkNWlRdXcyTHp6cXFsOXJBdWRQMHE3YXo2RDdBZWVLUGhT?= =?utf-8?B?dEtjeTk4aDYvQ0NYYmIvSzkxVVlwWklxMGhxd0Y3M1JBSmJxVDViQnQzL2hF?= =?utf-8?B?R3YvUjdLUGJjZjJKTWM1bnlkQ2tVSHQ1VEpYSFB4OUxjd3ZNdXZ6L3l3VE8w?= =?utf-8?B?SlQ1OU1UVk1BaWxyL1NKRlVUYnFYWkFFU1Vad05zWWZBM1pVWnhQQVBSeld6?= =?utf-8?B?dk8zQXIrWjMrdU54cWJQb3RxcTd4NFdYeXB0c295WEhwdUJKZk5GdUxWa0Vo?= =?utf-8?B?bVVrTHpBRkxrQ0FXL2h2T0pURFpuYmsxUDBvNXVoNjdTb3pDY2VrMmpEZFl0?= =?utf-8?B?b1NjQXRWeHFXR0NPMktPQkR4T1hKQU5rbXFRL0lJUG5UUTloZWloa1VTTlly?= =?utf-8?B?L0dsbGZuT29tV2FPOVJtcUNCQ1dpR2NRTzdSay8xOUdFVDVxQkIxR1dmb1dQ?= =?utf-8?B?c1M3TEZDMm5Lcjh3RHdqUit6ejRnY25nOC9tZVFKZUdSdFV6WWZSOVg2cHlF?= =?utf-8?B?ZmkxVG1SU0V2NmhOdE9PQ2JwUmJGdndlSGNuRXJmemlsV3UwTXJCUCs1QVdQ?= =?utf-8?B?a0VzTDZ0MUVsUkFkazJRblU5eHlvdlV0SjFXSDlvdFIxSDd3ZG1ES2J0RG15?= =?utf-8?B?NStQclhaNUZWVy85b3g4UmI2RVdhLzJYWm5xK01XNWdNODIybEI4QnR1QlFO?= =?utf-8?B?ODNYUk54RXpta0R5UVlyNHR6L3JyQzN6ZGdFLzQ3Q3BvY2tqVVJsRE9RNWsz?= =?utf-8?B?TEVLck5JWW9laTdsUHQ2TUJRNktubnNvdG0yRjV1Sy91UmkzZm0yNTBDcUxN?= =?utf-8?B?Q3hGZSs0L0V3dkx1eDVIL1VVSkcyd2FWV3gvaTh2Sk44M0NNMlFCL3RnU0wx?= =?utf-8?B?V2xRZDh1UkxkVFNSck45ajNGanNTajF2OHNTWmFRWEZQMk1KYVQ2OXBTTlhE?= =?utf-8?B?WTBxZHRGRWdIMmNMUnFUTkp1T3dlWU5ZNWdSS3FoSExTQ2Rhb1IydzdYSEpQ?= =?utf-8?B?K2pMUVB6UWVOZy9TVzVUZXV1eHYzbmMyc2c3RWI4WlRGR0VJREt0eEl5aUFM?= =?utf-8?B?dXNvVUsrT2RjTEM4d1dWU3U1cG9venZ6Q3hQbHcwVHAvSTYyT1NQV0MyTFU1?= =?utf-8?B?ZHp3UXV4SW9CNzVobHR6ZHlEbVg1dVhCSE9MOXVNUjcyLytIM044R2h3bWc2?= =?utf-8?B?Y0lJdDJ3MFlxLzFqdHRTbXdvQko0bCsvWDMxSTB0WmhOOVhROFZiMFp3bFFM?= =?utf-8?B?ZW5uMElSc0UwMnJXNlBhL2d1MDRuZHo0NzVqT3FCdzRwT3k0MWwyNFR3S0lz?= =?utf-8?B?eUl6SXJjb1JiVW4xNFNxTSszd0ZFSHhERHhlVFAreXlJdThVbzY0REYzRGdq?= =?utf-8?B?YkoyQ1NCQ1ZYU3pJM254cWFnVXl6cE85VHI3N2l4YjRHcmcrU05wckxKeXNq?= =?utf-8?B?QnN2VnMxYTh1TmkraGRRaG5LRWVUanhRdU82OXU1QmJobnVsaHVjT21RM21x?= =?utf-8?B?TjVTM3JjSEZqN2NSRmdXV2JtWTA3dENHeVRhZ293a1VvUFNSazVOTk5zbW1T?= =?utf-8?B?cTBCa1VyR0RiMkwrTk1LVGhCUW4vR2l4MEtLUkZpWCtUSkhZNUxUK1lHeDNY?= =?utf-8?B?bno1VFMwdWZwQnFlR0FKYW1mdmZnZW5nbXgwTDB4cCtTVUVEUStMbmhrdWhx?= =?utf-8?B?azU0enBlRFlSdDNYV29aS3UrZmVTeitzRlZLL2wrMXZtOTRoOUpCeHNnRmVw?= =?utf-8?B?RVlpNVQ2WXUyY3lBMDAvS0FWakZFZWszQ1dKOVRPT1oxTlFTTlNOeTY1Wmhj?= =?utf-8?B?MEVFWE5KaHFVOVNYMkJiek0vai9EOFFvdHQrVldrMlpYUG04YllhV0ZtS0Ft?= =?utf-8?B?eG5hb1E4WDNLQWVLWmxOb0pVRnhRWGZScE1MVU5BeitxTjFuWWRlcm03NjNI?= =?utf-8?B?WkxOREk3TCs1N0tKTXQrYlZmWEpUUmozaUNldThBaVNFekxVQk5hQmtIUGJz?= =?utf-8?B?WWxlREllTHFBOWFOK3JPUXUzSUtpWm9uMFIwWTNNUzlLWncrOEl2cXgrVU5x?= =?utf-8?B?NTdXZXRma3lGU2lHK1ZZTlFkaVkycU01cStMRWxZMjY4NXd0ZXdZL2d3d2ZG?= =?utf-8?B?UWxhQy8ycFVldHdVc0MyWFl5bGNPMTh1N1RpQmFqRVlHWkZoSkZxb0hwRTh4?= =?utf-8?B?eTVQeWN0S1BzT0x1bngwb2xnYUNkSThlb0o2dmREcmtKT244ck1CQT09?= X-Exchange-RoutingPolicyChecked: MLAKPsrlNsUPrMb+PiPh+/vNQrCKjwiIL3xTdj9s1wFThpcLz7vkMvOS0Km0KMc1JgQCuj1icnufa+TrPBMJ1gbiO8K3nbOLet+j1rI0vR3KaIrUK6aWbspt/DOSa1QqhvM4EXOGip3TAhy/tlMrGuyYeZasX+6Ww7BVynlBimtNM8bxI6ObAQC7k2Tru5r0vdkVaRsmXBNUCS3zEIJmeWf8m8FUAOZyvAsM1Yk05PqbZbzomFtEMb1ZK9ESoIAJU00s4IOiudqtNXWVVzzEqR//DCfVJZDzgW6P9rh3l6w6Ksotn5xzZdLvC1XfsppOQCSQwqwQdaTnBP2EsJMlYw== X-MS-Exchange-CrossTenant-Network-Message-Id: 48976db0-64c3-4f13-e929-08ded1b83480 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2026 06:17:02.0878 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZqBj1LEyJLijj+EP7QBhYh01X00rp8DqDaKk8CC6Fpecm511EAnXw/Pta9qUwe+b7HakHyEMLWPhFMoy+Tm7Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7131 X-OriginatorOrg: intel.com Hi Reinette, On 6/24/2026 12:47 AM, Reinette Chatre wrote: > Hi Chenyu, > > On 6/23/26 12:48 AM, Chen, Yu C wrote: >> On 6/23/2026 5:29 AM, Reinette Chatre wrote: >> Would the following be appropriate? >> >> x86/resctrl: Replace "msr" in monitoring data identifiers >> >> Monitoring counter values are currently obtained via MSR and many >> identifiers involved in processing these values contain "msr" >> as part of their names, for example "prev_msr" and "msr_val". >> >> The ERDT ACPI table describes MMIO registers for monitoring access. >> A subsequent patch adds MMIO-based L3 occupancy reads. Rename "msr" > > Please drop the "A subsequent patch ...". Apart from it resembling the > dreaded "this patch", once it is merged the intended meaning is lost. As an > alternative the second paragraph can be: > The ERDT ACPI table describes MMIO registers for monitoring data > access. Rename "msr"-based identifiers to be interface-agnostic > to support their upcoming use for MMIO-read values. > > No functional change. > >> based identifiers to interface-agnostic names so they remain accurate >> as monitoring values may no longer originate exclusively from MSR. >> >> No functional change. OK, will do. thanks, Chenyu