From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758554AbcHYLdG (ORCPT ); Thu, 25 Aug 2016 07:33:06 -0400 Received: from mout.web.de ([212.227.17.11]:56723 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758525AbcHYLdE (ORCPT ); Thu, 25 Aug 2016 07:33:04 -0400 To: xen-devel@lists.xenproject.org, x86@kernel.org, Boris Ostrovsky , David Vrabel , "H. Peter Anvin" , Ingo Molnar , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Thomas Gleixner Cc: LKML , "kernel-janitors@vger.kernel.org" , Julia Lawall , Paolo Bonzini From: SF Markus Elfring Subject: [PATCH] xen/grant-table: Use kmalloc_array() in arch_gnttab_valloc() Message-ID: <8a04e3d1-2756-9e3a-e5ba-f5d0e6495df7@users.sourceforge.net> Date: Thu, 25 Aug 2016 13:30:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:uTi8zCxkz8SmXVgr5tX3yTYfAgGsyxwZyGzj2iW9GBX3JHQHCUm fPTcLjirYdH+CogariokjskQZqTXZP3ac0sHAbw6M7zmk9m5M/cxKgTNbhlujltZkqFf7vZ QWdkFkEETN+SjpriNa0PB1Lgxj7tdADws9NyD4PMaYkqbyiXvj2MR1xhAnitPGK6tVTwZ68 FG3PCgBsSfx4zCkulwVlw== X-UI-Out-Filterresults: notjunk:1;V01:K0:dF6to/j8z2A=:fi4azY/1NximMc9wotF2OU pAj22p5E0x7ZXosKhlZ6csaGOTxd58vsQlR3y2Q2sNGB7SRpBhOuBMzGylZiEqaMvb76dWrZk bHE7VrcbPW36yqRxAbjU2A039Q8zLHUsw7V9KFLYe4k+SKDt86QCM+YS+Hyoc9FnAaVJdspEz 8iK9VmSgrVnMTbxTARVD0L4pYbopZnszX3u7V0O8Bs0s40DhCZGexbcY28CmunHmEeU8ijqF6 xNxoqgf5bOcr8Apk7pJ46UtV/BDYy9MhOQgVAQcRipExKaPksFHd7NkDpRk83/GwQRo/nD1r1 LKtV8sAX0NbhIi1LHCnHnRjY7QP2a21ZbCZ24mgtI/vz/o3qjHyA39NSpv4lvX80BbDXbxghf n247NcPEYA6JunLEpaKePrEcRENY0U3vwh85oi5cGOMag0/ieSWKV1o2Azd+emJ1OE4qBIABR G9jATmfTKHOfN1lfU4lFyx4EmUZt5JaNdoC2UkugFWGEymJQ7v8Nhpjn/I7NFKg5Z/SlzTUGE b2Qj6S5kOCr+h08BpejqCiaFX77WZvOPP+941LJgJLKQmdS9L1V1U2YW1PGDhSY47ECAgZ4rG a42HGGZ0gsoEmuirrjPHoxrGEwUD0YkWem0X2Cfu8WzeaT7oI0tvTLFY2owydoOid6it6YEeC 3wYh4lI1FSi0XnRGa7IW321BuaWL8p4Y2aPVXbZzMVkLvP1qRZJ+k21s7gHmdYoIbv+21y3C+ eKL8krAYJcab2390wE8UxdATXyIXajMraklyv+SRoLkxDGnHcw8uM9KBxZ6X9V67T25rSBmaY yeQzAKX Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 Aug 2016 13:23:06 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/x86/xen/grant-table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/grant-table.c b/arch/x86/xen/grant-table.c index de4144c..809b6c8 100644 --- a/arch/x86/xen/grant-table.c +++ b/arch/x86/xen/grant-table.c @@ -89,7 +89,7 @@ void arch_gnttab_unmap(void *shared, unsigned long nr_gframes) static int arch_gnttab_valloc(struct gnttab_vm_area *area, unsigned nr_frames) { - area->ptes = kmalloc(sizeof(pte_t *) * nr_frames, GFP_KERNEL); + area->ptes = kmalloc_array(nr_frames, sizeof(*area->ptes), GFP_KERNEL); if (area->ptes == NULL) return -ENOMEM; -- 2.9.3