From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E7452ED17F for ; Fri, 25 Jul 2025 13:15:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753449343; cv=none; b=NWYuy3JOC8molL7rl5ZIH5ncuw6/YRnLGhTZU0wgpoY7tqWClYf/asiTc2YVAHfTzfG+a7vGrRW4vVcow8yMSUi8vBxXer4y3zt5DTmoZJd9PIMAlAC5eSshU/cv1RvaOGO4uzI3IpJJE4m35GodbIPJn7ZQ10Fw5EzTPd4Ty00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753449343; c=relaxed/simple; bh=y4LvTg8Vl0ihFpvurwo/P/l0P11SNHTq4D6tssmg0pw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g76xsN7xh56y30TH3osi8Bl8/CQjeeP4Ut/Jk4cSPLpGtFzUhTvAqFnrbAgXLAnQyIkpXRFYO+tEeVViYYs4bpOVwFWhBZl4Z+3YGsLASYEicfuDhCadmahXd9m6Dgjbq3DIu1SXlITFekV+kd3WqDcWigPvqHPiF84VEhYHrgw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=y3820aIg; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y3820aIg" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3a54700a46eso1120757f8f.1 for ; Fri, 25 Jul 2025 06:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1753449340; x=1754054140; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qphveX+IcbsowGUL4p1sm6U/t7i7Pc1D4Xjo/RMMv1k=; b=y3820aIgYOZqF970gq7SVTnV1Ha+a3lAni3B/9WoltwDXotfYVwV+Ld/ViX7ce1JNl OJGIkOv5hd2q6n7xYxjVv9Qu6dBpCRH1Lq50Agux9ySoi7qBtPAx/Zk/8KPkeHNXIFZj mbt5ch8s7Ri+60++Db0/3w0XgCt64fL3D6R7DHzqTzzZnlv/H5+yQV2c149+Eixafkc8 3BgF8u8p7cg9SZnNU9xpt8dvZAGzPe/ONZ16VTLWYJG4JG0CIFZ9G1yI9WZdya5LSbiO AujdA4w/fEVOxfpgN7aPkZZswa8/O2jDG2vdkgqJqArzEXuZyQTve+BlV0h5U9HPcmo9 BuQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753449340; x=1754054140; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qphveX+IcbsowGUL4p1sm6U/t7i7Pc1D4Xjo/RMMv1k=; b=lnDP6C/hz+MLoOPsC8Rl/yN+AEHgkFrQmwAmNCU01gJ4tCQEodsPsGN4wkUdR4CFEj 1KZ7iTiLPb4cqTKdlb9vPoZi3KaUqE9Wub/CzdH8ZSVmn1YJ679BFfkYyOHCkwbr8nIg Cvj5sN7cHzEKhUM122/DscRexCl9xRXJwoS28BSjARa7dnZZgu5FQnl6fleESrEqoZpD qj8scFOEIF1Jjfq/v8pdOB6u4dIYAZs3CCKvycVdnS2SW0eXrZ2v+LAzvvEw8iDT1h7U 36KwjlY4jvqfhP4CMeyCOjbt7aBF2L7WQuHh4Fn3+sgBciH4U/BD/7P7YiA/hn3829yA aiUQ== X-Gm-Message-State: AOJu0Yyf6p0uGlGghRCMLitLaPSeNQpqO84y2h9Dl8nWrahXf7Hq4BWS VqW9ZkNdr6sq2nrAV1xPytkncN7O7FmskuHGm+FGnJE77jx2Fkf8X9hBqfTN1fr5MH4= X-Gm-Gg: ASbGncv9gudcismttiGsxVoQcM4Rww24fZSGXpHw2gt7rcYh1erR8etVIePEOkcESqq iHyJJLY7PpjLIvSvDXq72nDt8eWxY816bAz/CSLGT4bGvtVRBSu5NHfcpJ+Z8mML4eAK9sPfjy8 wNHP46C9zyl1VqlRdwB17QGbb0hQG9IdZHDeESE0N1sjUVTzZoZX+kGPXll/JLrlBN+31XC7KnK Ht33B789STL4UxDWMI4P8w0kkrh7NyNNa4Rz3it+EJDzgajZ4nXxb8B0kHrh3sHVRbUUjDX3gMi yAcqw7sbDVkWTZVgTYCkjxe9iKEmmS0TigidSVsbdTBaM/GDL6NGsMcolevwHlMOQU31DbIYaIK PIRX7GAw1iKLJfQqP5E8vL3H/Wi7lyl/YgQtvwfFvTQLkSlzJMLcIQsbq5U77Dw== X-Google-Smtp-Source: AGHT+IGVp1L9DRHNP0CIZJjhCbFFiMb9Q/eMfhwleA0Cy0iT2RjxXfOV27ER9+Eq/tU6xxkCYqXfpQ== X-Received: by 2002:a05:6000:3111:b0:3b7:6828:4205 with SMTP id ffacd0b85a97d-3b77675fbf3mr1441404f8f.32.1753449339443; Fri, 25 Jul 2025 06:15:39 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3b76fcb83c5sm5039599f8f.60.2025.07.25.06.15.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Jul 2025 06:15:38 -0700 (PDT) Message-ID: <8a0662b7-2801-47a2-9c91-4eb0e7ef307b@linaro.org> Date: Fri, 25 Jul 2025 15:15:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [tip: timers/clocksource] clocksource/drivers/exynos_mct: Don't register as a sched_clock on arm64 To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , linux-tip-commits@vger.kernel.org, Donghoon Yu , Youngmin Nam , John Stultz , Will McVicker , x86@kernel.org, Krzysztof Kozlowski , Arnd Bergmann References: <20250620181719.1399856-3-willmcvicker@google.com> <175325504976.1420.2666973232153470630.tip-bot2@tip-bot2> Content-Language: en-US From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 25/07/2025 12:34, Ingo Molnar wrote: > > * Daniel Lezcano wrote: [ ... ] >>> 3) >>> >>> There's also a stray Tested-by tag by one of the SOB entries: >>> >>>> Signed-off-by: Youngmin Nam >>>> Reviewed-by: Youngmin Nam >>>> Tested-by: Youngmin Nam >>> >>> When someone passes along a patch, it's implicit that they not only >>> have reviewed the patch, but have also tested it to a certain extent >> >> In this specific case where the original commit is from AOSP, this chain >> seems to make sense. Souns like: >> >> "I was in the original commit delivery path" >> "I reviewed this patch carried to Linux" >> "I tested it on Linux" > > Yeah, so then this should be documented by adding a comment to the tag > itself: > > Signed-off-by: Donghoon Yu > Signed-off-by: Youngmin Nam > Signed-off-by: Will McVicker > Signed-off-by: Daniel Lezcano > Tested-by: Youngmin Nam # AOSP -> Linux port > Reviewed-by: Youngmin Nam # AOSP -> Linux port > > Otherwise it's just confusing as to why there's duplicate SOB and > Reviewed-by entries. Yes, I agree it is more clear. > But as long as the porting was basically just a cherry-pick, these > extra tags are probably superfluous. If there was a conflict resolved > by one of the maintainers along the SOB chain, that should be marked > explicitly, which I see was already done in some cases: > > [ dlezcano : Fixed conflict with 20250614175556.922159-2-linux@roeck-us.net ] Ok, noted for the next time. >>> 4) >>> >>> Why is the 'Link' tag just in the middle of the SOB chain, instead at the end of it? >> >> I don't know. Link must be at the end It is stated somewhere in the >> documentation? >> >> I use git b4 -s and the tool adds the Link then my sign off. > > Yeah, so using tools and not looking at the end result will often just > create a random tag order that looks messy. > > On preferred tag ordering, see: > > Documentation/process/maintainer-tip.rst > > Ordering of commit tags > ^^^^^^^^^^^^^^^^^^^^^^^ > ... > > 'Link' is at the end of the list of tags. > > There's some logic to the -tip tag ordering (more important tags go > before less important tags), but it's mostly just an arbitrary order > that we try to stick to within -tip. Thanks for the pointer ! >>> Presumably this is the proper SOB chain: >>> >>>> Author: Donghoon Yu >>> >>>> Signed-off-by: Donghoon Yu >>>> Signed-off-by: Youngmin Nam >>>> Signed-off-by: Will McVicker >>>> Signed-off-by: Daniel Lezcano >>>> Acked-by: John Stultz >>>> Link: https://lore.kernel.org/r/20250620181719.1399856-3-willmcvicker@google.com >>> >>> Correct? >> >> > > So I got no answer for this question, but I suppose my assumption is > correct - so I've rebased the tip:timers/clocksource commits to fix the > misattribution and a number of other problems, and also fixed various > typos, spelling mistakes and inconsistencies in the changelogs while at > it. Let me know if I got something wrong. If the rebase is possible, I suggest to take the opportunity to remove the following patches: commit 5d86e479193b - clocksource/drivers/exynos_mct: Add module support commit 7e477e9c4eb4 - clocksource/drivers/exynos_mct: Fix section mismatch from the module conversion Because of: [1] https://lore.kernel.org/all/20250725090349.87730-2-krzysztof.kozlowski@linaro.org/ [2] https://lore.kernel.org/all/bccb77b9-7cdc-4965-aa05-05836466f81f@app.fastmail.com/ > I've attached a delta-patch of the changelog changes below - note that > I skipped the commit IDs to make the diff easier to read. I have one question regarding the 'handler', when there is a message like: [ handler: I did some changes ] ... Signed-off-by: John Doe Does the 'handler' have to match the email name ? For example below, there is: [ dlezcano : Fixed conflict with 20250614175556.922159-2-linux@roeck-us.net ] Signed-off-by: Daniel Lezcano Is this form ok, or should it be: [ daniel.lezcano: Fixed conflict with 20250614175556.922159-2-linux@roeck-us.net ] ? > ===================> > --- 2025-07-25 12:15:26.024284067 +0200 > +++ 2025-07-25 12:15:18.761435799 +0200 > @@ -10,6 +10,7 @@ Date: Tue Jul 15 14:18:33 2025 +0200 > the module loading. > > Fix this by adding the __init_or_module annotation for the functions: > + If my understanding of the documentation is correct, it seems to me the delta is ok. Until now, I was relying on the tool to put the different tags in the correct order, I thought it was in the arrival order. Thanks for fixing this. Is there an existing script checking the tags order is correct regarding the tip criteria ? Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog