From: Daniel Borkmann <daniel@iogearbox.net>
To: Magnus Karlsson <magnus.karlsson@gmail.com>,
Kal Conley <kal.conley@dectris.com>
Cc: "Björn Töpel" <bjorn@kernel.org>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf v3] xsk: Add missing overflow check in xdp_umem_reg
Date: Thu, 16 Mar 2023 22:13:59 +0100 [thread overview]
Message-ID: <8a076362-c98e-9268-47bd-91f5f8e57449@iogearbox.net> (raw)
In-Reply-To: <CAJ8uoz1f1RSWtFspPQsEBoH_j3=jUYkDmye3nHRQ_xvgHiusHg@mail.gmail.com>
On 3/16/23 1:52 PM, Magnus Karlsson wrote:
> On Wed, 8 Mar 2023 at 18:51, Kal Conley <kal.conley@dectris.com> wrote:
>>
>> The number of chunks can overflow u32. Make sure to return -EINVAL on
>> overflow.
>>
>> Also remove a redundant u32 cast assigning umem->npgs.
>
> Thanks!
>
> Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
>
>> Fixes: bbff2f321a86 ("xsk: new descriptor addressing scheme")
>> Signed-off-by: Kal Conley <kal.conley@dectris.com>
Looks like patchbot was on partial strike, this was applied to bpf, thanks!
prev parent reply other threads:[~2023-03-16 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 17:40 Kal Conley
2023-03-16 12:52 ` Magnus Karlsson
2023-03-16 21:13 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a076362-c98e-9268-47bd-91f5f8e57449@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kal.conley@dectris.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®