From: Vlastimil Babka <vbabka@suse.cz>
To: thunder.leizhen@huaweicloud.com, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
linux-mm@kvack.org, "Paul E . McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Neeraj Upadhyay <quic_neeraju@quicinc.com>,
Joel Fernandes <joel@joelfernandes.org>,
Josh Triplett <josh@joshtriplett.org>,
Boqun Feng <boqun.feng@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Zqiang <qiang.zhang1211@gmail.com>,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: Re: [PATCH v5 3/3] mm: Dump the memory of slab object in kmem_dump_obj()
Date: Thu, 3 Aug 2023 12:34:57 +0200 [thread overview]
Message-ID: <8a08b7aa-ce1f-4b3d-abb5-cf3191474725@suse.cz> (raw)
In-Reply-To: <20230803101754.1149-4-thunder.leizhen@huaweicloud.com>
On 8/3/23 12:17, thunder.leizhen@huaweicloud.com wrote:
> From: Zhen Lei <thunder.leizhen@huawei.com>
>
> The contents of the slab object may contain some magic words and other
> useful information that may be helpful in locating problems such as
> memory corruption and use-after-free.
>
> To avoid print flooding, dump up to "16 * sizeof(int) = 64" bytes
> centered on argument 'ojbect'.
>
> For example:
> slab kmalloc-64 start ffff4043802d8b40 pointer offset 24 size 64
> [8b40]: 12345678 00000000 8092d000 ffff8000
> [8b50]: 00101000 00000000 8199ee00 ffff4043
> [8b60]: 00000000 00000000 00000000 00000100
> [8b70]: 00000000 9abcdef0 a8744de4 ffffc7fe
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> mm/slab_common.c | 30 +++++++++++++++++++++++++++---
> 1 file changed, 27 insertions(+), 3 deletions(-)
>
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index ee6ed6dd7ba9fa5..0232de9a3b29cf5 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -553,7 +553,7 @@ static void kmem_obj_info(struct kmem_obj_info *kpp, void *object, struct slab *
> bool kmem_dump_obj(void *object)
> {
> char *cp = IS_ENABLED(CONFIG_MMU) ? "" : "/vmalloc";
> - int i;
> + int i, object_size = 0;
> struct slab *slab;
> unsigned long ptroffset;
> struct kmem_obj_info kp = { };
> @@ -580,12 +580,36 @@ bool kmem_dump_obj(void *object)
> ptroffset = ((char *)object - (char *)kp.kp_objp) - kp.kp_data_offset;
> pr_cont(" pointer offset %lu", ptroffset);
> }
> - if (kp.kp_slab_cache && kp.kp_slab_cache->object_size)
> - pr_cont(" size %u", kp.kp_slab_cache->object_size);
> + if (kp.kp_slab_cache && kp.kp_slab_cache->object_size) {
> + object_size = kp.kp_slab_cache->object_size;
> + pr_cont(" size %u", object_size);
> + }
> if (kp.kp_ret)
> pr_cont(" allocated at %pS\n", kp.kp_ret);
> else
> pr_cont("\n");
> +
> + /* Dump a small piece of memory centered on 'object' */
> + if (kp.kp_objp && object_size) {
> + int *p = object, n = 16;
> +
> + p += n / 2;
> + if ((void *)p > kp.kp_objp + object_size)
> + p = kp.kp_objp + object_size;
> +
> + p -= n;
> + if ((void *)p < kp.kp_objp)
> + p = kp.kp_objp;
> +
> + n = min_t(int, object_size / sizeof(int), n);
> + for (i = 0; i < n; i++, p++) {
> + if (i % 4 == 0)
> + pr_info("[%04lx]:", 0xffff & (unsigned long)p);
> + pr_cont(" %08x", *p);
> + }
> + pr_cont("\n");
There's a print_hex_dump() for this, see how it's used from e.g. __dump_page().
> + }
> +
> for (i = 0; i < ARRAY_SIZE(kp.kp_stack); i++) {
> if (!kp.kp_stack[i])
> break;
next prev parent reply other threads:[~2023-08-03 10:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 10:17 [PATCH v5 0/3] rcu: Dump memory object info if callback function is invalid thunder.leizhen
2023-08-03 10:17 ` [PATCH v5 1/3] mm: Remove kmem_valid_obj() thunder.leizhen
2023-08-03 10:17 ` [PATCH v5 2/3] rcu: Dump memory object info if callback function is invalid thunder.leizhen
2023-08-03 10:17 ` [PATCH v5 3/3] mm: Dump the memory of slab object in kmem_dump_obj() thunder.leizhen
2023-08-03 10:34 ` Vlastimil Babka [this message]
2023-08-04 1:44 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a08b7aa-ce1f-4b3d-abb5-cf3191474725@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=cl@linux.com \
--cc=frederic@kernel.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=penberg@kernel.org \
--cc=qiang.zhang1211@gmail.com \
--cc=quic_neeraju@quicinc.com \
--cc=rcu@vger.kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=rostedt@goodmis.org \
--cc=thunder.leizhen@huawei.com \
--cc=thunder.leizhen@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®