From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hugo Villeneuve <hugo@hugovil.com>, Rob Herring <robh@kernel.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
bruno.thomsen@gmail.com,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: rtc: pcf2127: add missing pcf/pca2129 entries
Date: Tue, 20 Dec 2022 11:17:37 +0100 [thread overview]
Message-ID: <8a0a38e2-9907-fa2e-a8a6-4cbc4dceb0a2@linaro.org> (raw)
In-Reply-To: <20221219175205.2989b6bf86941ec4774dab37@hugovil.com>
On 19/12/2022 23:52, Hugo Villeneuve wrote:
> On Mon, 19 Dec 2022 16:03:35 -0600
> Rob Herring <robh@kernel.org> wrote:
>
>> On Mon, Dec 19, 2022 at 02:42:40PM -0500, Hugo Villeneuve wrote:
>>> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>>>
>>> The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also
>>> contains:
>>> nxp,pcf2129
>>> ncp,pca2129
>>>
>>> Add these missing entries.
>>>
>>> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>>> ---
>>> Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
>>> index cde7b1675ead..00dbae7e23c2 100644
>>> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
>>> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
>>> @@ -14,7 +14,10 @@ maintainers:
>>>
>>> properties:
>>> compatible:
>>> - const: nxp,pcf2127
>>> + enum:
>>> + - nxp,pcf2127
>>> + - nxp,pcf2129
>>> + - ncp,pca2129
>>
>> Check Documentation/devicetree/bindings/rtc/trivial-rtc.yaml.
>>
>> Maybe they aren't trivial after all and should be removed? Or
>> nxp,pcf2127 is also trivial?
>
> Hi Rob,
> the pcf2127, and also the pca/pcf2129, can use the "reset-source" property. Are they still considered "trivial" devices then?
Then they do not look trivial, so please remove them from trivial-rtc.yaml.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-20 10:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 19:42 Hugo Villeneuve
2022-12-19 22:03 ` Rob Herring
2022-12-19 22:52 ` Hugo Villeneuve
2022-12-20 10:17 ` Krzysztof Kozlowski [this message]
2022-12-20 10:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a0a38e2-9907-fa2e-a8a6-4cbc4dceb0a2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bruno.thomsen@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®