From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Ondrej Zary <linux@zary.sk>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Tim Waugh <tim@cyberelk.net>, <linux-block@vger.kernel.org>,
<linux-parport@lists.infradead.org>, <linux-ide@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/18] pata_parport: protocol drivers fixes and cleanups
Date: Wed, 15 Feb 2023 20:14:51 +0300 [thread overview]
Message-ID: <8a0bd9fb-c667-8871-1955-3e4eb880f43d@omp.ru> (raw)
In-Reply-To: <6ce57b8c-7f0c-f3d1-6938-c87fa4ab650d@opensource.wdc.com>
On 2/15/23 2:50 AM, Damien Le Moal wrote:
[...]
>> This patch series fixes two bugs and cleans up pata_parport protocol drivers,
>> making the code simpler with no changes in behavior (except logged messages).
>>
>> Signed-off-by: Ondrej Zary <linux@zary.sk>
>
> Sergey did send you some reviewed-by tags for some of the patches. But I
> do not see any in this v2. Did you forget to add the tags to the reviewed
> patches ? That is nice to do so that I do not have to keep track of
> reviews across series versions...
Yes, it would also simplify my further reviews (I have low bandwidth currently
due to being somewhat overload at work)...
>> ---
>> Changes in v2:
>> - added two bugfixes (first two patches)
>> - addressed Sergey's comments (mostly split patches)
Well, you're supposed to be more detailed about what you really
did to the series, preferably listing the changes in each patch (usually
after the --- tearline)...
[...]
MBR, Sergey
prev parent reply other threads:[~2023-02-15 17:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 22:59 Ondrej Zary
2023-02-14 22:59 ` [PATCH 01/18] pata_parport: fix EPAT C7/C8 Kconfig Ondrej Zary
2023-02-15 17:19 ` Sergey Shtylyov
2023-02-14 22:59 ` [PATCH 02/18] pata_parport: probe all units automatically Ondrej Zary
2023-02-14 22:59 ` [PATCH 03/18] pata_parport: Remove pi_swab16 and pi_swab32 Ondrej Zary
2023-02-14 22:59 ` [PATCH 04/18] pata_parport: remove useless printks at module_init of bpck6 Ondrej Zary
2023-02-14 22:59 ` [PATCH 05/18] pata_parport: Introduce module_pata_parport_driver macro Ondrej Zary
2023-02-14 22:59 ` [PATCH 06/18] pata_parport: remove devtype from struct pi_adapter Ondrej Zary
2023-02-14 22:59 ` [PATCH 07/18] pata_parport: remove device " Ondrej Zary
2023-02-14 23:00 ` [PATCH 08/18] pata_parport: remove typedef struct PIA Ondrej Zary
2023-02-14 23:00 ` [PATCH 09/18] pata_parport: remove verbose parameter from log_adapter() Ondrej Zary
2023-02-14 23:00 ` [PATCH 10/18] pata_parport: remove scratch " Ondrej Zary
2023-02-14 23:00 ` [PATCH 11/18] pata_parport: use dev_* instead of printk Ondrej Zary
2023-02-14 23:00 ` [PATCH 12/18] pata_parport: use print_hex_* Ondrej Zary
2023-02-14 23:00 ` [PATCH 13/18] pata_parport: simplify log_adapter prints, remove VERSION defines Ondrej Zary
2023-02-14 23:00 ` [PATCH 14/18] pata_parport: remove bpck6 verbose parameter Ondrej Zary
2023-02-14 23:00 ` [PATCH 15/18] pata_parport: remove verbose parameter from test_proto() Ondrej Zary
2023-02-14 23:00 ` [PATCH 16/18] pata_parport: remove scratch " Ondrej Zary
2023-02-14 23:00 ` [PATCH 17/18] pata_parport: remove obsolete changelogs Ondrej Zary
2023-02-14 23:00 ` [PATCH 18/18] pata_parport: move pata_parport.h to drivers/ata/pata_parport Ondrej Zary
2023-02-14 23:50 ` [PATCH v2 0/18] pata_parport: protocol drivers fixes and cleanups Damien Le Moal
2023-02-15 17:14 ` Sergey Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a0bd9fb-c667-8871-1955-3e4eb880f43d@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=linux@zary.sk \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®