From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81C27168492; Mon, 12 Aug 2024 20:58:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723496319; cv=none; b=EXTIjDyoG1rruT+Bi1TBsBL5gkPX5PBVOIKkQy+vze8B8U4zxNRMJIn/wBKGkwWevnOBBHQPXs82kFvR6zdF2y93TjPp/kkELDztfEvQcuwItipt9LLR10QPT/GFm8hklJm7wlqnWJ4MEFNWFlcnRzaTXn4dklum1NEIwZFNHWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723496319; c=relaxed/simple; bh=m6uB3b8dXxVe7SvzlOGq6Avjl6gISjkwjewZ12XxR9Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sl/rYxgQXI//eQKcx87jjlY4EJGBb425LlhNpVDEZFYonomOWGra2noelDtnp4C7XwC9KTAl6y4sQOuWB0JuPjcJ9AKfbNZrfQN44qTeEnwTL+bjXxSO4SGWY2Im+T/3USpY0zYdetncX7VjC057m8XVbS7Z+0m1vatT1YJ4lOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=PMfx645k; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="PMfx645k" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=+eV/a4UVEKW9ggK78KVIpd8kPWb1ysRXIsOH546oDOY=; b=PM fx645komuOtTmoyYtMCVZx0hz6B6WvL7RRImRuubWSU0kNWjO+y6kMB7mhJhP/p3QiJoIsBiF6ljl tvJ3hL6WA5wj1ALL1QmrF7cu11mIizix4FlkOt3VX87f8FhbsIAf6kH5hlKfrzP8r74hIq0SWrWIX VVhNFH533F6Igp8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sdc7d-004cOs-Dw; Mon, 12 Aug 2024 22:58:33 +0200 Date: Mon, 12 Aug 2024 22:58:33 +0200 From: Andrew Lunn To: =?iso-8859-1?B?Q3Pza+FzLA==?= Bence Cc: Jakub Kicinski , imx@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Simon Horman , Frank Li , Wei Fang , Shenwei Wang , Clark Wang , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran Subject: Re: [PATCH v3 net-next 1/2] net: fec: Move `fec_ptp_read()` to the top of the file Message-ID: <8a0c15d0-c2ac-4de6-b011-d79b579ce7c8@lunn.ch> References: <20240812094713.2883476-1-csokas.bence@prolan.hu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240812094713.2883476-1-csokas.bence@prolan.hu> On Mon, Aug 12, 2024 at 11:47:13AM +0200, Csókás, Bence wrote: > This function is used in `fec_ptp_enable_pps()` through > struct cyclecounter read(). Moving the declaration makes > it clearer, what's happening. > > Fixes: 61d5e2a251fb ("fec: Fix timer capture timing in `fec_ptp_enable_pps()`") > Suggested-by: Frank Li > Link: https://lore.kernel.org/netdev/20240805144754.2384663-1-csokas.bence@prolan.hu/T/#ma6c21ad264016c24612048b1483769eaff8cdf20 > Signed-off-by: Csókás, Bence Reviewed-by: Andrew Lunn Andrew