From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933737AbdGLIJr (ORCPT ); Wed, 12 Jul 2017 04:09:47 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:30023 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933702AbdGLIJo (ORCPT ); Wed, 12 Jul 2017 04:09:44 -0400 Subject: Re: [PATCH 1/2] pinctrl: stm32: select IRQ_DOMAIN_HIERARCHY instead of depends on To: Masahiro Yamada , CC: Arnd Bergmann , Linus Walleij , , Maxime Coquelin , References: <1499814710-16686-1-git-send-email-yamada.masahiro@socionext.com> <1499814710-16686-2-git-send-email-yamada.masahiro@socionext.com> From: Alexandre Torgue Message-ID: <8a12356e-14bf-9044-ddc7-ba3087843ee0@st.com> Date: Wed, 12 Jul 2017 10:09:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1499814710-16686-2-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG3NODE2.st.com (10.75.127.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-12_01:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 07/12/2017 01:11 AM, Masahiro Yamada wrote: > Drivers that need IRQ_DOMAIN_HIERARCHY should "select" it, but > drivers/pinctrl/stm32/Kconfig is the only exception that uses > "depends on" syntax. This prevents GPIO drivers from select'ing > IRQ_DOMAIN_HIERARCHY. > > For example, if I add "select IRQ_DOMAIN_HIERARCHY" to GPIO_XGENE_SB, > I get the following recursive dependency error. > > drivers/gpio/Kconfig:13:error: recursive dependency detected! > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/gpio/Kconfig:13: symbol GPIOLIB is selected by PINCTRL_STM32 > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/pinctrl/stm32/Kconfig:3: symbol PINCTRL_STM32 is selected by PINCTRL_STM32F429 > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/pinctrl/stm32/Kconfig:11: symbol PINCTRL_STM32F429 depends on IRQ_DOMAIN_HIERARCHY > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > kernel/irq/Kconfig:67: symbol IRQ_DOMAIN_HIERARCHY is selected by GPIO_XGENE_SB > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/gpio/Kconfig:502: symbol GPIO_XGENE_SB depends on GPIOLIB > > Signed-off-by: Masahiro Yamada --- Thanks for the patch. Tested-by: Alexandre TORGUE regards Alex > > drivers/pinctrl/stm32/Kconfig | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig > index 3b8026fca057..7e1fe39a56a5 100644 > --- a/drivers/pinctrl/stm32/Kconfig > +++ b/drivers/pinctrl/stm32/Kconfig > @@ -6,29 +6,30 @@ config PINCTRL_STM32 > select PINMUX > select GENERIC_PINCONF > select GPIOLIB > + select IRQ_DOMAIN_HIERARCHY > select MFD_SYSCON > > config PINCTRL_STM32F429 > bool "STMicroelectronics STM32F429 pin control" if COMPILE_TEST && !MACH_STM32F429 > - depends on OF && IRQ_DOMAIN_HIERARCHY > + depends on OF > default MACH_STM32F429 > select PINCTRL_STM32 > > config PINCTRL_STM32F469 > bool "STMicroelectronics STM32F469 pin control" if COMPILE_TEST && !MACH_STM32F469 > - depends on OF && IRQ_DOMAIN_HIERARCHY > + depends on OF > default MACH_STM32F469 > select PINCTRL_STM32 > > config PINCTRL_STM32F746 > bool "STMicroelectronics STM32F746 pin control" if COMPILE_TEST && !MACH_STM32F746 > - depends on OF && IRQ_DOMAIN_HIERARCHY > + depends on OF > default MACH_STM32F746 > select PINCTRL_STM32 > > config PINCTRL_STM32H743 > bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743 > - depends on OF && IRQ_DOMAIN_HIERARCHY > + depends on OF > default MACH_STM32H743 > select PINCTRL_STM32 > endif >