mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@kernel.org>
To: "Vladimir Murzin" <vladimir.murzin@arm.com>,
	"Changyul Lee" <lcy8047@gmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>
Cc: "Liviu Dudau" <liviu.dudau@arm.com>,
	"Sudeep Holla" <sudeep.holla@kernel.org>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: mps2-uart: Remove the ports_idr entry when probe fails
Date: Wed, 11 Nov 2026 17:30:31 +0100	[thread overview]
Message-ID: <8a20b9a9-b10c-4b7f-8d42-2e8c60edd943@app.fastmail.com> (raw)
In-Reply-To: <89544da0-7c18-4fe5-8005-131760a2b8b5@arm.com>

On Wed, Nov 11, 2026, at 15:17, Vladimir Murzin wrote:
> On 11/6/26 01:06, Changyul Lee wrote:
>
> Before getting into the review, I'd like to clarify a few things:
>
> - This driver is only used on a NOMMU platform, where any code
>   can write to any memory location, so the security impact of
>   this issue is likely minimal
>
> - The only platform that uses this driver is deprecated and
>   scheduled for removal [1], with the driver to be removed
>   afterwards
>
> @Arnd, could you please advise on how to proceed? Should we
> review the patch, leave things as they are, or take a different
> approach?
>
> [1] 
> https://lore.kernel.org/linux-arm-kernel/20260908152808.3928630-12-arnd@kernel.org/

I don't think it's super important, either applying as-is
or ignoring seems fine, just don't spend too much time
on a review.

For some of the platforms I'm planning to remove it would
be nice to backport fixesto the LTS kernels in case there
are some users after all.

Chanyul, it looks like you've done a thorough job testing this
patch, and you probably have similar work for other drivers
coming. I would suggest you try to prioritize the drivers that
are likely to be in use somewhere.

I have a branch for removing a lot of drivers including this
one, maybe check your other patches to see which ones are
obsolete.

      Arnd

[1] https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=board-remove-7.4

      reply	other threads:[~2026-11-11 16:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  1:06 Changyul Lee
2026-11-11 14:17 ` Vladimir Murzin
2026-11-11 16:30   ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a20b9a9-b10c-4b7f-8d42-2e8c60edd943@app.fastmail.com \
    --to=arnd@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=lcy8047@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=lpieralisi@kernel.org \
    --cc=sudeep.holla@kernel.org \
    --cc=vladimir.murzin@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®