From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1F59C433EF for ; Tue, 26 Oct 2021 04:30:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBFE361074 for ; Tue, 26 Oct 2021 04:30:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233518AbhJZEcl (ORCPT ); Tue, 26 Oct 2021 00:32:41 -0400 Received: from smtprelay0215.hostedemail.com ([216.40.44.215]:37350 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230414AbhJZEck (ORCPT ); Tue, 26 Oct 2021 00:32:40 -0400 Received: from omf01.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 0B9871829805C; Tue, 26 Oct 2021 04:30:16 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf01.hostedemail.com (Postfix) with ESMTPA id 9DC7917276; Tue, 26 Oct 2021 04:30:14 +0000 (UTC) Message-ID: <8a28c2abf1857c631bd6af52364d7f055a6c0ee9.camel@perches.com> Subject: Re: [PATCH] staging: rtl8723bs: core: remove local variable and goto statement From: Joe Perches To: Saurav Girepunje , gregkh@linuxfoundation.org, fabioaiuto83@gmail.com, ross.schm.dev@gmail.com, marcocesati@gmail.com, matthew.v.deangelis@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com Date: Mon, 25 Oct 2021 21:30:13 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9DC7917276 X-Stat-Signature: rqs99ogcamans6mwa5jtuzrr116szy8u X-Rspamd-Server: rspamout02 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19mwDJx49hqd+DvWov5aICK54jupwZnYlQ= X-HE-Tag: 1635222614-65343 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2021-10-26 at 09:54 +0530, Saurav Girepunje wrote: > In the function rtw_validate_bssid() remove the goto statement. > As on goto exit label, function is returning without any cleanup. > In this function goto statement can be replace by simple return > statement, which will improve readability. After replacing > the goto statement local variable ret is also not needed. So > remove the ret local variable. [] > diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c [] > @@ -24,15 +24,10 @@ u8 rtw_validate_bssid(u8 *bssid) > > u8 rtw_validate_ssid(struct ndis_802_11_ssid *ssid) > { > - u8 ret = true; > - > - if (ssid->ssid_length > 32) { > - ret = false; > - goto exit; > - } > + if (ssid->ssid_length > 32) > + return false; > > -exit: > - return ret; > + return true; > } bool rtw_validate_ssid(const struct ndis_802_11_ssid *ssid) { return ssid->ssid_length <= 32; }