From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sanjay Suthar <sanjaysuthar661996@gmail.com>,
linux-kernel@vger.kernel.org
Cc: dt-bindings@lists.infradead.org, skhan@linuxfoundation.org,
Neil Armstrong <neil.armstrong@linaro.org>,
- Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH] docs: devicetree: fix duplicated 'is is' in amlogic-dwmac and ti,dac7612
Date: Sun, 20 Jul 2025 14:33:16 +0200 [thread overview]
Message-ID: <8a2b80f2-87a3-4446-b42e-7a985ef4bd10@kernel.org> (raw)
In-Reply-To: <CADU64hCr7mshqfBRE2Wp8zf4BHBdJoLLH=VJt2MrHeR+zHOV4w@mail.gmail.com>
On 19/07/2025 22:09, Sanjay Suthar wrote:
> Hi all,
>
> This patch fixes a minor grammatical issue by removing duplicated "is is" in
> the Amlogic DWMAC and TI DAC7612 binding documentation files.
Your Cc is completely broken... Except maybe Neil and Martin.
<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
Please kindly resend and include all necessary To/Cc entries.
</form letter>
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Also, please use standard way of sending patches, not as attachment. See
submitting patches.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-20 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-19 20:09 Sanjay Suthar
2025-07-20 12:33 ` Krzysztof Kozlowski [this message]
2025-07-20 18:26 ` >
2025-07-20 19:30 ` David Lechner
2025-07-21 6:52 ` Re: Krzysztof Kozlowski
[not found] ` <CADU64hDZeyaCpHXBmSG1rtHjpxmjejT7asK9oGBUMF55eYeh4w@mail.gmail.com>
2025-07-21 14:09 ` Re: David Lechner
2025-07-21 7:52 ` Re: Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a2b80f2-87a3-4446-b42e-7a985ef4bd10@kernel.org \
--to=krzk@kernel.org \
--cc=dt-bindings@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=sanjaysuthar661996@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox