From: Dan Carpenter <error27@gmail.com>
To: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
Cc: Michael.Hennerich@analog.com, lars@metafoo.de, jic23@kernel.org,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Outreachy Linux Kernel <outreachy@lists.linux.dev>
Subject: Re: Outreachy
Date: Wed, 15 Mar 2023 17:03:20 +0300 [thread overview]
Message-ID: <8a30c3d1-a1a4-468c-a9f4-d15e0f418ef6@kili.mountain> (raw)
In-Reply-To: <ec13bbba-88ec-64b0-58ae-eee8617990b8@gmail.com>
On Wed, Mar 15, 2023 at 03:17:28PM +0200, Menna Mahmoud wrote:
> Hi Mentors,
>
>
> I am Menna, Outreachy applicant and I work on my clean-up patches.
>
> Is it Okay to work on this error reported by checkpatch script?
>
>
> drivers/staging/iio/frequency/ad9832.c
> --------------------------------------
> ERROR: Use 4 digit octal (0777) not decimal permissions
> #256: FILE: drivers/staging/iio/frequency/ad9832.c:256:
> +static IIO_DEV_ATTR_FREQ(0, 1, 0200, NULL, ad9832_write, AD9832_FREQ1HM);
What??? Is it complaining about the 0200? That is octal. Why is
checkpatch complaining about this? Am I wrong? Maybe I am misreading.
I could investigate, but I am leaving that task to you. It may be that
checkpatch has a problem and you can fix that instead.
regards,
dan carpenter
next prev parent reply other threads:[~2023-03-15 14:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 13:17 Outreachy Menna Mahmoud
2023-03-15 14:03 ` Dan Carpenter [this message]
2023-03-15 19:24 ` Outreachy Randy Dunlap
2023-03-15 20:09 ` Outreachy Lars-Peter Clausen
2023-03-19 11:20 ` Outreachy Menna Mahmoud
-- strict thread matches above, loose matches on Subject: below --
2017-03-09 20:36 outreachy Julia Lawall
2017-03-09 20:51 ` outreachy Scott Branden
2017-03-09 20:56 ` outreachy Stephen Warren
2017-03-09 21:20 ` outreachy Greg KH
2017-03-09 22:15 ` outreachy Florian Fainelli
2017-03-10 6:01 ` outreachy Greg KH
2017-03-17 15:25 ` outreachy Pavel Machek
2017-03-17 16:55 ` outreachy Julia Lawall
2017-03-20 10:20 ` outreachy Pavel Machek
2017-03-20 10:30 ` outreachy Greg KH
2017-03-20 16:14 ` outreachy Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a30c3d1-a1a4-468c-a9f4-d15e0f418ef6@kili.mountain \
--to=error27@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=eng.mennamahmoud.mm@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®