From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com,
rfoss@kernel.org, todor.too@gmail.com, andersson@kernel.org,
mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] media: qcom: camss: Convert to per-VFE pointer for power-domain linkages
Date: Thu, 26 Oct 2023 22:08:19 +0200 [thread overview]
Message-ID: <8a36e61a-5397-4513-ae0d-eb68ccd8e584@linaro.org> (raw)
In-Reply-To: <20231026155042.551731-3-bryan.odonoghue@linaro.org>
On 10/26/23 17:50, Bryan O'Donoghue wrote:
> Right now we use the top-level camss structure to provide pointers via
> VFE id index back to genpd linkages.
>
> In effect this hard-codes VFE indexes to power-domain indexes in the
> dtsi and mandates a very particular ordering of power domains in the
> dtsi, which bears no relationship to a real hardware dependency.
>
> As a first step to rationalising the VFE power-domain code and breaking
> the magic indexing in dtsi use per-VFE pointers to genpd linkages.
>
> The top-level index in msm_vfe_subdev_init is still used to attain the
> initial so no functional or logical change arises from this change.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> + if (vfe->id >= camss->res->vfe_num)
> return 0;
P.S. this seems better suited for some warning, I think
next prev parent reply other threads:[~2023-10-26 20:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 15:50 [PATCH v2 0/5] media: qcom: camss: Introduce support for named power-domains Bryan O'Donoghue
2023-10-26 15:50 ` [PATCH v2 1/5] media: qcom: camss: Flag which VFEs require a power-domain Bryan O'Donoghue
2023-10-26 20:05 ` Konrad Dybcio
2023-10-26 15:50 ` [PATCH v2 2/5] media: qcom: camss: Convert to per-VFE pointer for power-domain linkages Bryan O'Donoghue
2023-10-26 20:08 ` Konrad Dybcio [this message]
2023-10-27 9:10 ` Bryan O'Donoghue
2023-10-27 9:38 ` Bryan O'Donoghue
2023-10-26 15:50 ` [PATCH v2 3/5] media: qcom: camss: Use common VFE pm_domain_on/pm_domain_off where applicable Bryan O'Donoghue
2023-10-26 15:50 ` [PATCH v2 4/5] media: qcom: camss: Move VFE power-domain specifics into vfe.c Bryan O'Donoghue
2023-10-31 10:54 ` Konrad Dybcio
2023-10-31 11:51 ` Bryan O'Donoghue
2023-10-31 15:04 ` Konrad Dybcio
2023-10-26 15:50 ` [PATCH v2 5/5] media: qcom: camss: Add support for named power-domains Bryan O'Donoghue
2023-10-31 10:53 ` Konrad Dybcio
2023-10-31 11:38 ` Bryan O'Donoghue
2023-10-31 17:10 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a36e61a-5397-4513-ae0d-eb68ccd8e584@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®