From: Tengfei Fan <quic_tengfan@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<andersson@kernel.org>, <konrad.dybcio@linaro.org>,
<linus.walleij@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel@quicinc.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: pinctrl: qcom: consolidate functions to match with driver
Date: Wed, 31 Jan 2024 16:24:34 +0800 [thread overview]
Message-ID: <8a3866ee-d70b-419c-bde4-7bf55415402e@quicinc.com> (raw)
In-Reply-To: <aa870f52-d956-4c3e-82a4-980a32f5f698@linaro.org>
On 1/29/2024 7:24 PM, Krzysztof Kozlowski wrote:
> On 29/01/2024 10:25, Tengfei Fan wrote:
>> Consolidate functions to match with SM4450 pinctrl driver, because
>> consolidate functions are being used in SM4450 pinctrl driver.
>
> It's very difficult to see what changed from the diff, so please explain
> brieflyl changes here.
>
> What is that "consolidate functions" that you use in the driver?
>
> Best regards,
> Krzysztof
>
please help to comfirm that the following description as commit message
whether it covers your concerns:
Pin alternative functions are consolidated(like: atest_char, phase_flag,
qdss_gpio etc.) in SM4450 pinctrl driver while they are still split in
DeviceTree binding file. SM4450 pinctrl function is broken if current
binding doc is followed. Update SM4450 pinctrl DeviceTree binding doc to
align with driver.
--
Thx and BRs,
Tengfei Fan
next prev parent reply other threads:[~2024-01-31 8:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 9:25 [PATCH v2 0/2] update SM4450 pinctrl document Tengfei Fan
2024-01-29 9:25 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom: update compatible name for match with driver Tengfei Fan
2024-01-29 11:22 ` Krzysztof Kozlowski
2024-02-27 13:37 ` Rob Herring
2024-03-08 20:10 ` Rob Herring
2024-03-09 23:44 ` Linus Walleij
2024-03-11 2:27 ` Tengfei Fan
2024-03-11 6:48 ` Krzysztof Kozlowski
2024-03-11 9:43 ` Tengfei Fan
2024-03-11 9:58 ` Krzysztof Kozlowski
2024-03-09 23:44 ` Linus Walleij
2024-01-29 9:25 ` [PATCH v2 2/2] dt-bindings: pinctrl: qcom: consolidate functions to " Tengfei Fan
2024-01-29 11:24 ` Krzysztof Kozlowski
2024-01-31 8:24 ` Tengfei Fan [this message]
2024-01-31 8:34 ` Krzysztof Kozlowski
2024-01-31 8:40 ` Tengfei Fan
2024-01-30 4:38 ` Bjorn Andersson
2024-01-31 8:28 ` Tengfei Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a3866ee-d70b-419c-bde4-7bf55415402e@quicinc.com \
--to=quic_tengfan@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®