From: Chengming Zhou <zhouchengming@bytedance.com>
To: Tejun Heo <tj@kernel.org>,
peterz@infradead.org, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com
Cc: mingo@redhat.com, juri.lelli@redhat.com, rostedt@goodmis.org,
bsegall@google.com, vschneid@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 7/9] sched/fair: allow changing cgroup of new forked task
Date: Tue, 16 Aug 2022 21:14:39 +0800 [thread overview]
Message-ID: <8a38c9aa-8404-e50a-58b1-7a87bf887d06@bytedance.com> (raw)
In-Reply-To: <Yvq2ZiQL/iHNAaLh@slm.duckdns.org>
On 2022/8/16 05:11, Tejun Heo wrote:
> On Mon, Aug 08, 2022 at 08:57:43PM +0800, Chengming Zhou wrote:
>> commit 7dc603c9028e ("sched/fair: Fix PELT integrity for new tasks")
>> introduce a TASK_NEW state and an unnessary limitation that would fail
>> when changing cgroup of new forked task.
>>
>> Because at that time, we can't handle task_change_group_fair() for new
>> forked fair task which hasn't been woken up by wake_up_new_task(),
>> which will cause detach on an unattached task sched_avg problem.
>>
>> This patch delete this unnessary limitation by adding check before do
>> detach or attach in task_change_group_fair().
>>
>> So cpu_cgrp_subsys.can_attach() has nothing to do for fair tasks,
>> only define it in #ifdef CONFIG_RT_GROUP_SCHED.
>>
>> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
>
> I don't know cfs enough to review this but it'd be really great to remove
> this restriction.
Thanks for your reply!
Friendly ping :-)
next prev parent reply other threads:[~2022-08-16 13:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 12:57 [PATCH v4 0/9] sched/fair: task load tracking optimization and cleanup Chengming Zhou
2022-08-08 12:57 ` [PATCH v4 1/9] sched/fair: maintain task se depth in set_task_rq() Chengming Zhou
2022-08-08 12:57 ` [PATCH v4 2/9] sched/fair: remove redundant cpu_cgrp_subsys->fork() Chengming Zhou
2022-08-08 12:57 ` [PATCH v4 3/9] sched/fair: reset sched_avg last_update_time before set_task_rq() Chengming Zhou
2022-08-08 12:57 ` [PATCH v4 4/9] sched/fair: update comments in enqueue/dequeue_entity() Chengming Zhou
2022-08-08 12:57 ` [PATCH v4 5/9] sched/fair: combine detach into dequeue when migrating task Chengming Zhou
2022-08-08 12:57 ` [PATCH v4 6/9] sched/fair: fix another detach on unattached task corner case Chengming Zhou
2022-08-17 15:01 ` Vincent Guittot
2022-08-17 15:04 ` Chengming Zhou
2022-08-17 15:08 ` Vincent Guittot
2022-08-17 15:10 ` Chengming Zhou
2022-08-08 12:57 ` [PATCH v4 7/9] sched/fair: allow changing cgroup of new forked task Chengming Zhou
2022-08-08 14:57 ` Chengming Zhou
2022-08-08 16:42 ` kernel test robot
2022-08-15 21:11 ` Tejun Heo
2022-08-16 13:14 ` Chengming Zhou [this message]
2022-08-08 12:57 ` [PATCH v4 8/9] sched/fair: defer task sched_avg attach to enqueue_entity() Chengming Zhou
2022-08-08 12:57 ` [PATCH v4 9/9] sched/fair: don't init util/runnable_avg for !fair task Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a38c9aa-8404-e50a-58b1-7a87bf887d06@bytedance.com \
--to=zhouchengming@bytedance.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®