mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Yicheng Li <yichengli@chromium.org>, LKML <linux-kernel@vger.kernel.org>
Cc: bleung@chromium.org, groeck@chromium.org, lee.jones@linaro.org,
	gwendal@chromium.org, andriy.shevchenko@linux.intel.com,
	Jonathan.Cameron@huawei.com, evgreen@chromium.org,
	rushikesh.s.kadam@intel.com, tglx@linutronix.de
Subject: Re: [PATCH v6] platform/chrome: cros_ec: Query EC protocol version if EC transitions between RO/RW
Date: Tue, 11 Feb 2020 10:42:17 +0100	[thread overview]
Message-ID: <8a4273cc-3700-8398-598e-cbcb05e6e595@collabora.com> (raw)
In-Reply-To: <20200203225356.203946-1-yichengli@chromium.org>


On 3/2/20 23:53, Yicheng Li wrote:
> RO and RW of EC may have different EC protocol version. If EC transitions
> between RO and RW, but AP does not reboot (this is true for fingerprint
> microcontroller / cros_fp, but not true for main ec / cros_ec), the AP
> still uses the protocol version queried before transition, which can
> cause problems. In the case of fingerprint microcontroller, this causes
> AP to send the wrong version of EC_CMD_GET_NEXT_EVENT to RO in the
> interrupt handler, which in turn prevents RO to clear the interrupt
> line to AP, in an infinite loop.
> 
> Once an EC_HOST_EVENT_INTERFACE_READY is received, we know that there
> might have been a transition between RO and RW, so re-query the protocol.
> 
> Signed-off-by: Yicheng Li <yichengli@chromium.org>
> ---

Queued for 5.7 with all the collected tags, thanks.

      parent reply	other threads:[~2020-02-11  9:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03 22:53 Yicheng Li
     [not found] ` <CGME20200204073034eucas1p1592fa2436b5567c2d15cf2935c3a8804@eucas1p1.samsung.com>
2020-02-04  7:30   ` Marek Szyprowski
2020-02-04 20:40     ` Gwendal Grignou
2020-02-05  9:06       ` Enric Balletbo i Serra
2020-02-11  9:42 ` Enric Balletbo i Serra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a4273cc-3700-8398-598e-cbcb05e6e595@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bleung@chromium.org \
    --cc=evgreen@chromium.org \
    --cc=groeck@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rushikesh.s.kadam@intel.com \
    --cc=tglx@linutronix.de \
    --cc=yichengli@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®