From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4366D13DDAE for ; Fri, 6 Feb 2026 01:20:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770340825; cv=none; b=mq5KUCdRPqi7Her5FT8yLWLASa4mX7TzNpS04l3sTRCfKV2bKuTDAlFWg3eTJ5YBikNZcDdxnZ0QIISVpQ74fskkVwdHllyLLhXkJMJbOSDf7dSDzFc4qawVvIq6v9gS+4N1hhZ8+Rh8oUT5hFq9qEN5TvQJ+ee0uNYrzf1PFxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770340825; c=relaxed/simple; bh=GyR6KWVzKhyYrBtw6VfJhs3npmSjck6zK96gQJMdCcI=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=AwedAdaiseJXx/hI5OjckCVVZkt/GGzsaTuMtbUf1MYLiHjgx/hdXul35/kG7Oj9CWF4XGl2CfhMUJsiuB3olq0LicdD5D06zuIPUVg/pFSx+c24xXD+azSTw9hAI46sqI/VZSsY+SMIjK8tVnuH1ncgl5mqDVOr7XoHoOBrGEE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=e8qEFJzr; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=YLXMO6l9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e8qEFJzr"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="YLXMO6l9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770340824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V7b157Yafq4kRhiEXcxD2sEQIhOvtPF12svPXHHFHG0=; b=e8qEFJzr00C5TWhv7F6yUKzuUy+Kn5L5FpTqsZcE/N/9C/cPhqJ50Iwdpj9uA611i2fA/z UcdLfGVhFQemOC28P0ogbUCQaNJypXa+u2FcHbI2zb+GiriLvwI6LJ/gO19YJFXXidLsXB RMl5zGyyeZ9ZMObvA9O2+FwofgOHCsY= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-543-R0rS3SVDOTqjy0BqM1RQkg-1; Thu, 05 Feb 2026 20:20:23 -0500 X-MC-Unique: R0rS3SVDOTqjy0BqM1RQkg-1 X-Mimecast-MFC-AGG-ID: R0rS3SVDOTqjy0BqM1RQkg_1770340823 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c52d3be24cso266138985a.0 for ; Thu, 05 Feb 2026 17:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770340822; x=1770945622; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=V7b157Yafq4kRhiEXcxD2sEQIhOvtPF12svPXHHFHG0=; b=YLXMO6l9J3Xesf0NkjWM0oRGRrjwo7g1oKljch8+ZZxxI/asBHLf87RXZSdpqXPnVq nyY8Y4eZ3bK2AnkZjcZZ1xQvhK39BDIcaPwfdLdQbETcXJtSwYMXfNcLfbsh+QEQEHEU 2zDhlSsh063Kk3FLm9vQNrbpG3LhIzT8D4jyQqLWHv+rAlnvCCIuKtIy0dC58d/5ypFr tbTf/ZOt6ZVvi9ctHWkBw6QACV2Z3hlGzGSAy9Br2VZj2TUYzdREKpt9bGF+Jq9f8HHu 0mPIW6HWDWDN4Ie5Jbe/IS08EBdSDjvhMOeOQlrAbFoI/X2Pl1bEor8qK5umBREKyIn/ K77A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770340822; x=1770945622; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V7b157Yafq4kRhiEXcxD2sEQIhOvtPF12svPXHHFHG0=; b=DdzHfDm9WraHcZVJMENIPPpg85YYJVAomssdcJXXTjwtkzE7RzbhBZ3I5m1d4zsW3L RLpG2eoXi0s14xtSUjZfNGZ0PzhizAzUHZpv0j5eEWMPUIzbibndsoXhTSmioSaFFYWS 7Lose3fowZLjqSYTiA//lgj1EZY7QYYeqfWGiIvf97EBxxhyj71PKU7bGQZl0py100It J0KJZs4UR/y/2yTY4AiwFyQaErWjChtkZlv7no1+Gsz/duIgkU4y5pTYxPcrBgsCihAX oP8BaKN8JmS9UV6VaQuqg3pFBfwlIt1xFyVpkZe1vH9UApLWAmWbQfgDcB+5TSUoldJ7 r2Mw== X-Forwarded-Encrypted: i=1; AJvYcCVjPxsrCYcIpzwJGZm3Kk2rbnyqmDbj91GRaG4u64XbCEbGzN/WnYImMILV1hjonNtGB1Iv2yVEivb3L8s=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+f2+NZ32ux6khOszFoPzb2gq4NO+oVCyV2lTfWlRXbWmifduS GMJU7HlGonzgZg2+XkQKl0fGHR33jAewtM/WrT6AIotZS8IE5vQ7Oq5tsjGRHjNdz2XCvCnElmX 4w+2KSczfycE97uvDBdhfoFDhckto9iTBwwDSIvow5P4z8/MAmeqT1SWH5wYLsXwNqQ== X-Gm-Gg: AZuq6aIK4kxQlUwRqT5N61GWZv05T3izpfiCCZ9uSD2hUAuvlYuaDwWOh51BBDKJtRU Ktum1zHzpzaSEDoWHz5DH0h7Dw7e1z1yIP7GNWXbVUzKU92kswPBUJYn5U1uiVhgVCQ22pzPjkw vYVY4sy/8VQ6EEKN908w5S8FhnN7yRtlYBpq2AfQYspG3K+6AhEg2OOSkq3ZnjJxyaskgxzLVIm 6fYBVEJ7ocjj5DMZe/w9mZnHgXtgzVhwW6FzOiG5hP/cAUdEd56O+SEo8WP8D8JZxDMj2WWiVPT jupvQDvkWCuClf6e7koWiy/Q90C86CsyJ4Ysfp9C+XSsnltBfA54OTKJaJ0PQsKfCX4+mqu9gRX cQdx7H5W5FbrXaJP5GJoAcoc8hwMgN3v+ZS+YSW9FmzQDUXlA5DsIoT7q X-Received: by 2002:a05:620a:bd5:b0:8c7:808:3d0e with SMTP id af79cd13be357-8caf0963662mr154635485a.49.1770340822647; Thu, 05 Feb 2026 17:20:22 -0800 (PST) X-Received: by 2002:a05:620a:bd5:b0:8c7:808:3d0e with SMTP id af79cd13be357-8caf0963662mr154633285a.49.1770340822247; Thu, 05 Feb 2026 17:20:22 -0800 (PST) Received: from ?IPV6:2601:188:c102:b180:1f8b:71d0:77b1:1f6e? ([2601:188:c102:b180:1f8b:71d0:77b1:1f6e]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8953bf5484dsm7302076d6.17.2026.02.05.17.20.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Feb 2026 17:20:20 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <8a456257-6f7e-4d0a-b38d-3c2aefee76bb@redhat.com> Date: Thu, 5 Feb 2026 20:20:19 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] audit: Avoid excessive dput/dget in audit_context setup and reset paths To: Al Viro , Waiman Long Cc: Paul Moore , Eric Paris , Christian Brauner , linux-kernel@vger.kernel.org, audit@vger.kernel.org, Richard Guy Briggs , Ricardo Robaina References: <20260203200505.GH3183987@ZenIV> <590a36e6-8d11-411a-8fcd-d93eef96f0e9@redhat.com> <20260203215002.GI3183987@ZenIV> <20260203232634.GJ3183987@ZenIV> <6661f966-5235-49ca-bf1f-d1ae2ae32f0d@redhat.com> <20260204062614.GK3183987@ZenIV> <46d5c480-87d0-4f6a-bcc2-6c936c87e216@redhat.com> <20260204201815.GP3183987@ZenIV> <50054d23-0a89-41ec-b28b-b1ed77d93b00@redhat.com> <20260205235351.GU3183987@ZenIV> Content-Language: en-US In-Reply-To: <20260205235351.GU3183987@ZenIV> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/5/26 6:53 PM, Al Viro wrote: > On Wed, Feb 04, 2026 at 11:45:17PM -0500, Waiman Long wrote: > >> @@ -70,6 +74,8 @@ void chroot_fs_refs(const struct path *old_root, const >> struct> >>                                 count++; >>                                 path_get(new_root); >>                         } >> +                       count += fs->pwd_xrefs; >> +                       fs->pwd_xrefs = 0; >>                         write_sequnlock(&fs->seq); > Nope - you only need that for threads that have ->pwd equal to old_root. > Incidentally, I'd forgotten about that sucker - it kills the idea of > fdget-like tricks dead, more's the pity. Third-party modification of > task->fs->pwd (under task->lock and task->fs->seq), possible even with > task->fs->users == 1. Yes, I am aware of that when I took a further look at the patch that I sent out yesterday. I am testing the updated patch now and is trying to figure out why I get a warning from mntput_no_expire_slowpath() with a count of -1 when doing an umount. It is off by 1 somewhere. I will post the patch once I resolve this bug. Thanks, Longman