From: "Christian König" <christian.koenig@amd.com>
To: Danilo Krummrich <dakr@kernel.org>,
Chris Bainbridge <chris.bainbridge@gmail.com>
Cc: nouveau@lists.freedesktop.org, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
simona@ffwll.ch, lyude@redhat.com, sumit.semwal@linaro.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/prime: fix drm_prime_gem_destroy comment
Date: Fri, 28 Mar 2025 13:46:23 +0100 [thread overview]
Message-ID: <8a4772c0-7789-4697-94c7-5cb364fc4ee6@amd.com> (raw)
In-Reply-To: <Z-aBkc2p5BZLrBJH@pollux>
Am 28.03.25 um 12:01 schrieb Danilo Krummrich:
> On Wed, Mar 26, 2025 at 01:10:58PM +0000, Chris Bainbridge wrote:
>> Edit the comments on correct usage of drm_prime_gem_destroy to note
>> that, if using TTM, drm_prime_gem_destroy must be called in the
>> ttm_buffer_object.destroy hook, to avoid the dma_buf being freed leaving
>> a dangling pointer which will be later dereferenced by
>> ttm_bo_delayed_delete.
>>
>> Signed-off-by: Chris Bainbridge <chris.bainbridge@gmail.com>
>> Suggested-by: Christian König <christian.koenig@amd.com>
> Can you please send new version of patches as a new mail thread (not in reply to
> previous versions) please?
>
> Otherwise,
>
> Reviewed-by: Danilo Krummrich <dakr@kernel.org>
>
> @Christian, I assume you will pick this one up?
Sure, I can take care of that.
Regards,
Christian.
prev parent reply other threads:[~2025-03-28 12:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 13:09 [PATCH] drm/nouveau: prime: fix ttm_bo_delayed_delete oops Chris Bainbridge
2025-03-12 13:23 ` Christian König
2025-03-19 12:54 ` [PATCH v2] " Chris Bainbridge
2025-03-19 13:04 ` Danilo Krummrich
2025-03-19 14:06 ` Christian König
2025-03-19 14:18 ` Danilo Krummrich
2025-03-26 12:52 ` [PATCH v3] " Chris Bainbridge
2025-03-28 10:59 ` Danilo Krummrich
2025-03-26 12:53 ` [PATCH] drm/nouveau: prime: drm_prime_gem_destroy comment Chris Bainbridge
2025-03-26 13:05 ` Christian König
2025-03-26 13:10 ` [PATCH v2] drm/prime: fix " Chris Bainbridge
2025-03-28 11:01 ` Danilo Krummrich
2025-03-28 12:46 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a4772c0-7789-4697-94c7-5cb364fc4ee6@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@gmail.com \
--cc=chris.bainbridge@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=sumit.semwal@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®