From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46A18C77B75 for ; Tue, 23 May 2023 02:46:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232682AbjEWCq2 (ORCPT ); Mon, 22 May 2023 22:46:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232594AbjEWCqZ (ORCPT ); Mon, 22 May 2023 22:46:25 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E9A4ECA; Mon, 22 May 2023 19:46:15 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A36B411FB; Mon, 22 May 2023 19:47:00 -0700 (PDT) Received: from [10.162.42.7] (unknown [10.162.42.7]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CC1CA3F67D; Mon, 22 May 2023 19:46:09 -0700 (PDT) Message-ID: <8a47f7dd-4c53-50bf-0296-45a3f4f80067@arm.com> Date: Tue, 23 May 2023 08:16:06 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH V3 6/6] coresight: platform: acpi: Ignore the absence of graph Content-Language: en-US To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org Cc: Ganapatrao Kulkarni , Steve Clevenger , Rob Herring , Frank Rowand , Russell King , Greg Kroah-Hartman , "Rafael J. Wysocki" , Len Brown , Sudeep Holla , Lorenzo Pieralisi , Mathieu Poirier , Mike Leach , Leo Yan , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org References: <20230519052149.1367814-1-anshuman.khandual@arm.com> <20230519052149.1367814-7-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/19/23 18:10, Suzuki K Poulose wrote: > On 19/05/2023 06:21, Anshuman Khandual wrote: >> From: Suzuki K Poulose >> >> Some components may not have graph connections for describing >> the trace path. e.g., ETE, where it could directly use the per >> CPU TRBE. Ignore the absence of graph connections >> >> Signed-off-by: Suzuki K Poulose >> Signed-off-by: Anshuman Khandual > > Please could you move this before the Patch 5, where we add > ACPI support for etm4x with system instructions ? That way > the support is up with that patch, without an error that > is fixed by this patch. Sure, will move it before adding the ACPI support patch. > > Suzuki > > >> --- >>   drivers/hwtracing/coresight/coresight-platform.c | 6 +++++- >>   1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c >> index 475899714104..c4b4fbde8550 100644 >> --- a/drivers/hwtracing/coresight/coresight-platform.c >> +++ b/drivers/hwtracing/coresight/coresight-platform.c >> @@ -692,8 +692,12 @@ static int acpi_coresight_parse_graph(struct acpi_device *adev, >>         pdata->nr_inport = pdata->nr_outport = 0; >>       graph = acpi_get_coresight_graph(adev); >> +    /* >> +     * There are no graph connections, which is fine for some components. >> +     * e.g., ETE >> +     */ >>       if (!graph) >> -        return -ENOENT; >> +        return 0; >>         nlinks = graph->package.elements[2].integer.value; >>       if (!nlinks) >