From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 342A5C433EF for ; Mon, 9 May 2022 23:15:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232236AbiEIXTX (ORCPT ); Mon, 9 May 2022 19:19:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231384AbiEIXTV (ORCPT ); Mon, 9 May 2022 19:19:21 -0400 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FA822A376E; Mon, 9 May 2022 16:15:26 -0700 (PDT) Received: by mail-ot1-x32f.google.com with SMTP id h10-20020a056830400a00b00605e92cc450so11101392ots.11; Mon, 09 May 2022 16:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=VlZ9NTH9fu3pqFxNk7Bf2+YqFMFkydcVnpc8dIcGFDU=; b=qpnvEl5DDPtXKM46kOOYT+iy4jUlZB2OjwIqmVKmKNc52UUNSD8Re60PO0xfNzQEPb klsKfDgW50906FYzAKCp7qATDSnX4FOoiypqqdbwpcueXh4PgKHWCbITsw592hVwcTsM k52+V3tLQDaIeGAq5Hd4RfUU9PsqSwsisWfC7D0S/r6muIrDMogE4CzboArhZqbIXXUP sRsdfD9cnIbwIT44YplLs3j1fNuzAkXhMSH69U6nettgglvda98PbtzEUXURbJT7OMbn hYH/pF1BwpPEM8AiDOTSyJjXkfj7LkG4jX+1ffGRxSVZLNKrlVjujYwzGpXyvpvzZ2it LEoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=VlZ9NTH9fu3pqFxNk7Bf2+YqFMFkydcVnpc8dIcGFDU=; b=UpjhMjn7Y/d511JKurkSI38Fm/cfcUi+6JLPFn777Z4Djv2qIobNmG6zEWCIqgo7Fe TNUCr8fCJ28UtyF1sq7BuzlHajB0oJaS7032Cqibnehn0M+LbWPTsEosJdzNVRRy30Nw eqybCtY92x1VBpuefW79Y/MrNkhYHQMC0ld5jhBBMWK4h5e59rjGao14Lh4NV+Dws2wr 3zgEnskqoID17Ou7rwe2AKjJSeKJzDGseT2oFLVnvSRmXDh6ibINfvJD7H+Ia1CuMucr u0LWz/dxQOyi+UJmvK9u5c2MQVvDuMZL99HfEW4T1z2C9XwuIsojC2O/sOotQ3AEc0T8 JEAw== X-Gm-Message-State: AOAM533sxysqlwsRUl391aql9JhArPA3SbNnpMx7ifXReMYRUoW46QUO KJosND7PskxFKSbxEAv6mus= X-Google-Smtp-Source: ABdhPJyCWQNSswuT2wag/aifPUNjcw6imCiwDC+bS5fSMyomniLnx7g42y3+PP0gFkYoEfR/5+pttA== X-Received: by 2002:a05:6830:911:b0:606:36b4:69b3 with SMTP id v17-20020a056830091100b0060636b469b3mr6653039ott.176.1652138125448; Mon, 09 May 2022 16:15:25 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id g126-20020aca3984000000b0032643374d17sm4893619oia.41.2022.05.09.16.15.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 May 2022 16:15:23 -0700 (PDT) Sender: Guenter Roeck Message-ID: <8a48ba53-7182-10fa-72cd-fbcee0e4369a@roeck-us.net> Date: Mon, 9 May 2022 16:15:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] Watchdog: sp5100_tco: Lower verbosity of disabled watchdog hardware Content-Language: en-US To: "Limonciello, Mario" , Wim Van Sebroeck , "open list:WATCHDOG DEVICE DRIVERS" , open list Cc: "ionut_n2001@yahoo.com" References: <20220509163304.86-1-mario.limonciello@amd.com> From: Guenter Roeck In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/9/22 16:10, Limonciello, Mario wrote: > [Public] > > > >> -----Original Message----- >> From: Guenter Roeck On Behalf Of Guenter Roeck >> Sent: Monday, May 9, 2022 17:56 >> To: Limonciello, Mario ; Wim Van Sebroeck >> ; open list:WATCHDOG DEVICE DRIVERS > watchdog@vger.kernel.org>; open list >> Cc: ionut_n2001@yahoo.com >> Subject: Re: [PATCH] Watchdog: sp5100_tco: Lower verbosity of disabled >> watchdog hardware >> >> On 5/9/22 09:33, Mario Limonciello wrote: >>> If watchdog hardware has been disabled, currently the kernel driver >>> will show at err level during probe: >>> >>> "Watchdog hardware is disabled" >>> >>> This is unnecessarily verbose as there is already a -ENODEV returned. >>> Lower the level to debug. >> >> Is it ? Without this message, a user may try to load the driver, >> get an error message, and have no idea why the driver was not >> enabled even though the hardware exists. If anything , -ENODEV >> is less than perfect. Unfortunately there does not seem to be >> a better error code, or at least I don't see one. > > If it didn't have modaliases and users only manually loaded it; I would agree > with you. However it has MODULE_DEVICE_TABLE, so if that PCI device is around > then the driver will load either way. That would translate into an "error message" > on every boot if you have this module compiled and didn't manually try to load it. > Why don't you just blacklist the driver ? Guenter